GNU bug report logs - #18487
`server-running-p' not autoloaded

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18487 in the body.
You can then email your comments to 18487 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Emilio Lopes <eclig <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: `server-running-p' not autoloaded
Date: Tue, 16 Sep 2014 22:11:21 +0200

The function `server-running-p' is not autoloaded.  That means that
the following code in
the user's init-file will result in an error:

    (unless (or noninteractive
                (server-running-p))
      (server-start))

On the other hand, `server-start' doesn't signal an error if called
when a server process is already running.
So the test using `server-running-p' is indeed not necessary (anymore?).

Anyway, the following patch adds the `autoload cookie' for `server-running-p':

--- lisp/ChangeLog    2014-09-16 00:28:28 +0000
+++ lisp/ChangeLog    2014-09-16 13:36:04 +0000
@@ -1,3 +1,7 @@
+2014-09-16  Emilio C. Lopes  <eclig <at> gmx.net>
+
+    * server.el (server-running-p): add autoload cookie.
+
 2014-09-16  Stefan Monnier  <monnier <at> iro.umontreal.ca>

     * msb.el (msb--make-keymap-menu, msb-menu-bar-update-buffers):

=== modified file 'lisp/server.el'
--- lisp/server.el    2014-07-08 19:15:28 +0000
+++ lisp/server.el    2014-09-16 13:36:04 +0000
@@ -704,6 +704,7 @@
       (file-error
        (message "No connection file %S" file)))))

+;;;###autoload
 (defun server-running-p (&optional name)
   "Test whether server NAME is running.

Message #8 received at 18487 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Emilio Lopes <eclig <at> gmx.net>
Cc: 18487 <at> debbugs.gnu.org
Subject: Re: bug#18487: `server-running-p' not autoloaded
Date: Wed, 17 Sep 2014 15:43:15 -0400

Emilio Lopes wrote:

> The function `server-running-p' is not autoloaded.  That means that
> the following code in
> the user's init-file will result in an error:
>
>     (unless (or noninteractive
>                 (server-running-p))
>       (server-start))

Since it's not interactive, why does it matter?
Ie, just stick a (require 'server) in there.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.