From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 14 18:15:19 2014 Received: (at submit) by debbugs.gnu.org; 14 Sep 2014 22:15:19 +0000 Received: from localhost ([127.0.0.1]:41000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTI4k-0005ni-IS for submit@debbugs.gnu.org; Sun, 14 Sep 2014 18:15:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36928) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTI4i-0005na-87 for submit@debbugs.gnu.org; Sun, 14 Sep 2014 18:15:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTI4X-0003AC-P1 for submit@debbugs.gnu.org; Sun, 14 Sep 2014 18:15:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTI4X-00039o-MW for submit@debbugs.gnu.org; Sun, 14 Sep 2014 18:15:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTI4O-00011h-TP for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 18:15:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTI4F-0002to-Vh for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 18:14:56 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTI4F-0002ti-Ou for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 18:14:47 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s8EMEkHa012909 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 14 Sep 2014 22:14:46 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s8EMEjkD014070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 14 Sep 2014 22:14:46 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s8EMEiGv014052 for ; Sun, 14 Sep 2014 22:14:45 GMT MIME-Version: 1.0 Message-ID: <5e3be79b-89f5-40a1-8024-be65f99af255@default> Date: Sun, 14 Sep 2014 15:14:43 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.4.50; doc string of `clone-indirect-buffer' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) .. should say that it returns the indirect buffer created. In GNU Emacs 24.4.50.1 (i686-pc-mingw32) of 2014-08-15 on LEG570 Bzr revision: 117706 rgm@gnu.org-20140815043406-p5hbu97cbm7pulcn Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking 'CFLAGS=3D-O0 -g3' CPPFLAGS=3D-DGLYPH_DEBUG= =3D1' From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 17 18:49:28 2014 Received: (at 18478) by debbugs.gnu.org; 17 Sep 2014 22:49:28 +0000 Received: from localhost ([127.0.0.1]:43682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUO2R-0002a8-WF for submit@debbugs.gnu.org; Wed, 17 Sep 2014 18:49:28 -0400 Received: from r0.smtpout1.alwaysdata.com ([176.31.58.0]:40346) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUO2O-0002Zz-Pv for 18478@debbugs.gnu.org; Wed, 17 Sep 2014 18:49:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=alwaysdata.net; s=ryuslash; h=Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From; bh=kF+t9s6FC6i1+0Y5UZljiI1MLijZw0EgvQB5F1rW2yA=; b=AAFR9+Y12D8iVDz41Srrg8nc2kAAJnMpOhNw1wP4ERJgM+cR5ZquWf1UsyPPQT/wiIzACeINblSE4OSceIOjzbC1JqKe0xnwx5wCIQJYZzd4w/uljteg5zkvumm1vhVaESFvnneIYSCRCCMbEBUGOD1QzRTtTRD8meJK3IVjCT0=; Received: from [2a02:1812:2193:2c00:f24d:a2ff:fede:451c] (helo=localhost) by smtpout1.alwaysdata.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.77) (envelope-from ) id 1XUO2I-0002cC-Q1; Thu, 18 Sep 2014 00:49:18 +0200 From: Tom Willemse To: 18478@debbugs.gnu.org Subject: [Patch] Mention the return value of `clone-indirect-buffer' Date: Thu, 18 Sep 2014 00:49:18 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-alwaysdata-ID: 22003230 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18478 Cc: drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Hey, I hope it's ok that I'm replying to this bug. I've attached a suggestion for mentioning the return value for `clone-indirect-buffer'. Please let me know what you think. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=fix-18478.patch Content-Description: Patch mentioning the return value # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: tom@ryuslash.org-20140917220512-i61eqo2e0ir8dhdl # target_branch: bzr://bzr.sv.gnu.org/emacs/trunk/ # testament_sha1: 14f39b93edb4937309c738111fb8220fc3776acd # timestamp: 2014-09-18 00:10:58 +0200 # base_revision_id: eggert@cs.ucla.edu-20140917195831-xarn36t9318izhtl # # Begin patch === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2014-09-17 09:17:27 +0000 +++ lisp/ChangeLog 2014-09-17 22:05:12 +0000 @@ -1,3 +1,7 @@ +2014-09-17 Tom Willemse + + * simple.el (clone-indirect-buffer): Mention the return value. + 2014-09-17 Reuben Thomas * progmodes/js.el: Add interpreter-mode-alist support for various === modified file 'lisp/simple.el' --- lisp/simple.el 2014-08-28 01:59:29 +0000 +++ lisp/simple.el 2014-09-17 22:05:12 +0000 @@ -7577,7 +7577,9 @@ This is always done when called interactively. Optional third arg NORECORD non-nil means do not put this buffer at the -front of the list of recently selected ones." +front of the list of recently selected ones. + +This function returns the newly created indirect buffer." (interactive (progn (if (get major-mode 'no-clone-indirect) # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWRFVfucAAiffgAAwUHP/91oG BIC////wUAR28NGmxzklac2hJSmmFPFNN6AnpTxI8KNPUaA0DBlBMAEU/SE0bUAAaAABIkCmE0Ta Kek21Q00aNDTQHqZMMNDQAAAaAAAAAEkUyNAmCMRNMJPU8ojIabINEDW8RUos8613hLcssjmq15g GkWwhmzUh0Ut7GUCrDrL2mP8d6/s67G4zZSThHHHQj8l3/ofqOfgT2jqS5wP+iYTKXUcI0xDy4X4 +X21cg5Hf3CZhG5ccT014fgqtPYrHIJgGDeW3gYzalPqwt/JQ0bDdV91BFvGsRJZmBdbIy1toFey 0cwm7YJTMJRJlI9SAuLAZ2EfnYJwUPiVzKpM6hAIzEsqQLVdc6dc+MrjV0KcDeYODMSBiJWS5tN5 SChrEoIO0ClxpKRro2GyiDsC600ee1YixTM+BcYGzLQCUKCJe8kF4qu7oUBagTxQPwIPVWUnA/Us CNU+0xdErrD5gZkDWNNb4FJBVqu6DMLytCsu5Kcnsvm+RBnyMVrsVMhiDqsLdbShuNNsCxljqusP 2K3VqM6qVyiBNfaV5Wvt84KKtKafGwgfkXPyFfrIoKTmByVWht0FKwpJjIfNPGUNsxsIOqLHApaW fBOVkTWqwziDsJ43vk5zNewLlfNRwd92cILSIsoutoCZpYAQsnhPZExTNXCgq4whXnauOI5l4ZuM jHeZ/Yz6OjK69vZCOGt1xhTgHW6kmrkW1M7F6jd03sfFQ+sfz5eBFl3pDsXjG3+7SMCb7GSqPBo+ ndMOSgX+0pYXdctDjn5bN/ZijLmTk+uZYukSoVIhxsZnWd5mUM7nMxHaF1QrxSDscMlIcZ7bssLX oF8kzeSjCNiswvejwq6A1DvIOxCKIRLmHA6KK9AJ7V/TC2HUiE5kTJcjQB/ja/M4HbodzsVXNUzz 0jI2d0PVQnFQic6MWETHWlqrjRBHCxn1qHNHzav0bmngaBtVdVEkivbfuJAHvCJGveVqvQ3jeD94 uGMBQPWGakJlivgvY6nc6ZuYwZ8loCuvoZDG9XKPflxEcncX4czA4hd+uixRA5gW2l03uho1LeL3 Ji5FXJDISX0sa9EokWASrSpHis4DVosX857ClE0puTEwwwVorcJ1MI9DwhjAYi9FB9TTrukdqSwl U54dp8WI61Q5YHrpOamjAc1UY01kV10AmEHgsrBUTyQTsFbrd7ASFRUe952MBGNQEDtRJTo/wFYt ZlfvM/zTowwTKLIo0h6+BaAb2E2IA8j1vJZwJSX8SS0AqdooyDSjHLCrnG6Hgd4InZdTG7F8AtGw IQdtQsae6KELEgOW4IWJIRAGNa7YH/FPMJHSFcYpaW0NGE+F2Ba8+SeZmmU7jJEQkwfbHFdjcmCL 81icl5le5cxGZ4FUv7tR0/18BZCj3LxhGze2SYjTeKnoLuSKcKEgIqr9zg== --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 17 18:55:23 2014 Received: (at 18478) by debbugs.gnu.org; 17 Sep 2014 22:55:23 +0000 Received: from localhost ([127.0.0.1]:43689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUO89-0002jE-Oz for submit@debbugs.gnu.org; Wed, 17 Sep 2014 18:55:22 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21984) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUO87-0002j5-AN for 18478@debbugs.gnu.org; Wed, 17 Sep 2014 18:55:19 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s8HMtGtv030517 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 17 Sep 2014 22:55:18 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s8HMtF42020278 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Sep 2014 22:55:16 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s8HMtFW5020273; Wed, 17 Sep 2014 22:55:15 GMT MIME-Version: 1.0 Message-ID: <9cf30244-8e2e-4c74-8cf8-1476ec97c61f@default> Date: Wed, 17 Sep 2014 15:55:14 -0700 (PDT) From: Drew Adams To: Tom Willemse , 18478@debbugs.gnu.org Subject: RE: [Patch] Mention the return value of `clone-indirect-buffer' References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 18478 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > I've attached a suggestion for mentioning the return value for > `clone-indirect-buffer'. Please let me know what you think. Looks OK to me. You can also simplify it to just "Returns...". From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 17 19:11:45 2014 Received: (at 18478) by debbugs.gnu.org; 17 Sep 2014 23:11:45 +0000 Received: from localhost ([127.0.0.1]:43701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUOO1-00039I-9z for submit@debbugs.gnu.org; Wed, 17 Sep 2014 19:11:45 -0400 Received: from r0.smtpout1.alwaysdata.com ([176.31.58.0]:41790) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUONz-00039A-7X for 18478@debbugs.gnu.org; Wed, 17 Sep 2014 19:11:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=alwaysdata.net; s=ryuslash; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=vy/f/Z7CHqCEWiMTAY9DSfmS4G0qrrlX/JstLLG/Ftk=; b=cuPBlWivxrt7WYHmEkpEk8RQretap9qL3XK7T/tAzdK7tW07J6mbv0AefrqJkjE9c+iN6EAuXRm4+5hS3994kWjBt4LPxmYAx6IIP7KlaIAjPUBSUs70oqEK148btwSOElV9mcMp2XyZHWMbvDcCQSIHNjGPQXj5JXNBX9R/Jqc=; Received: from [2a02:1812:2193:2c00:f24d:a2ff:fede:451c] (helo=localhost) by smtpout1.alwaysdata.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.77) (envelope-from ) id 1XUONu-0002Dd-0B; Thu, 18 Sep 2014 01:11:38 +0200 From: Tom Willemse To: Drew Adams Subject: Re: [Patch] Mention the return value of `clone-indirect-buffer' References: <9cf30244-8e2e-4c74-8cf8-1476ec97c61f@default> Date: Thu, 18 Sep 2014 01:11:37 +0200 In-Reply-To: <9cf30244-8e2e-4c74-8cf8-1476ec97c61f@default> (Drew Adams's message of "Wed, 17 Sep 2014 15:55:14 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-alwaysdata-ID: 22006156 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18478 Cc: 18478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Hey Drew, Drew Adams writes: >> I've attached a suggestion for mentioning the return value for >> `clone-indirect-buffer'. Please let me know what you think. > > Looks OK to me. You can also simplify it to just "Returns...". Certainly, if that has your preference. I just thought that because it is a new paragraph and the ones before it talk about the meanings of the arguments it would be clearer to explicitly state it's about the function. I actually would have liked to start the docstring off with "Create and return ..." as the docstring for `clone-buffer' does, but checkdoc then started complaining about the line being more than 80 characters long. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 17 21:47:09 2014 Received: (at 18478) by debbugs.gnu.org; 18 Sep 2014 01:47:09 +0000 Received: from localhost ([127.0.0.1]:43765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUQoO-00070v-OA for submit@debbugs.gnu.org; Wed, 17 Sep 2014 21:47:09 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:28252) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUQoM-00070n-UX for 18478@debbugs.gnu.org; Wed, 17 Sep 2014 21:47:07 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s8I1l4E7030226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 18 Sep 2014 01:47:05 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s8I1l3wW028452 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 18 Sep 2014 01:47:03 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s8I1l2XV006235; Thu, 18 Sep 2014 01:47:02 GMT MIME-Version: 1.0 Message-ID: <4919c10d-ac35-475d-9b66-12deaa8d7fbe@default> Date: Wed, 17 Sep 2014 18:47:01 -0700 (PDT) From: Drew Adams To: Tom Willemse Subject: RE: [Patch] Mention the return value of `clone-indirect-buffer' References: <9cf30244-8e2e-4c74-8cf8-1476ec97c61f@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 18478 Cc: 18478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > >> I've attached a suggestion for mentioning the return value for > >> `clone-indirect-buffer'. Please let me know what you think. > > > > Looks OK to me. You can also simplify it to just "Returns...". >=20 > Certainly, if that has your preference. I have no preference. And my preference doesn't count for anything. I just reported the bug. > I just thought that because it is a new paragraph and the ones > before it talk about the meanings of the arguments it would be > clearer to explicitly state it's about the function. Yes, but I don't see any chance for confusion there. It is only the function return value that matters. And arguments do not "return". They are evaluated, of course, and their values are returned by that evaluation. But we just speak of their "values". > I actually would have liked to start the docstring off with "Create > and return ..." as the docstring for `clone-buffer' does, but checkdoc > then started complaining about the line being more than 80 characters > long. FWIW, I don't put a lot of stock in checkdoc, personally. ;-) From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 17 22:40:25 2014 Received: (at 18478) by debbugs.gnu.org; 18 Sep 2014 02:40:25 +0000 Received: from localhost ([127.0.0.1]:43790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XURdv-0008OQ-RR for submit@debbugs.gnu.org; Wed, 17 Sep 2014 22:40:24 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:24097) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XURdo-0008OC-SZ for 18478@debbugs.gnu.org; Wed, 17 Sep 2014 22:40:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNFpZEG/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOI1cHhDgBA6kZgWqDTCGBLQ X-IPAS-Result: ArUGAIDvNVNFpZEG/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOI1cHhDgBA6kZgWqDTCGBLQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="90144422" Received: from 69-165-145-6.dsl.teksavvy.com (HELO pastel.home) ([69.165.145.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Sep 2014 22:40:16 -0400 Received: by pastel.home (Postfix, from userid 20848) id 1EECC60776; Wed, 17 Sep 2014 22:40:16 -0400 (EDT) From: Stefan Monnier To: Drew Adams Subject: Re: bug#18478: [Patch] Mention the return value of `clone-indirect-buffer' Message-ID: References: <9cf30244-8e2e-4c74-8cf8-1476ec97c61f@default> <4919c10d-ac35-475d-9b66-12deaa8d7fbe@default> Date: Wed, 17 Sep 2014 22:40:16 -0400 In-Reply-To: <4919c10d-ac35-475d-9b66-12deaa8d7fbe@default> (Drew Adams's message of "Wed, 17 Sep 2014 18:47:01 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18478 Cc: 18478@debbugs.gnu.org, Tom Willemse X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> I actually would have liked to start the docstring off with "Create >> and return ..." as the docstring for `clone-buffer' does, but checkdoc >> then started complaining about the line being more than 80 characters >> long. > FWIW, I don't put a lot of stock in checkdoc, personally. ;-) Its recommendations shouldn't be heeded blindly, indeed, but the 80-columns limit is something that should really be obeyed whenever possible. Stefan PS: Thanks Tom. Your patch looks good, as does the one for prog-mode-hook. Hopefully someone else will get to install them before I do. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 18 00:05:35 2014 Received: (at 18478) by debbugs.gnu.org; 18 Sep 2014 04:05:35 +0000 Received: from localhost ([127.0.0.1]:43798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUSyN-00024h-2M for submit@debbugs.gnu.org; Thu, 18 Sep 2014 00:05:35 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:28059) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUSyK-00024U-7s for 18478@debbugs.gnu.org; Thu, 18 Sep 2014 00:05:33 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s8I45Sm4013259 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 18 Sep 2014 04:05:30 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s8I45Q43000903 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 18 Sep 2014 04:05:27 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s8I45P0w014249; Thu, 18 Sep 2014 04:05:26 GMT MIME-Version: 1.0 Message-ID: <15a58b6b-44ef-47d7-8f34-73ac54b6c16d@default> Date: Wed, 17 Sep 2014 21:05:24 -0700 (PDT) From: Drew Adams To: Stefan Monnier Subject: RE: bug#18478: [Patch] Mention the return value of `clone-indirect-buffer' References: <9cf30244-8e2e-4c74-8cf8-1476ec97c61f@default> <4919c10d-ac35-475d-9b66-12deaa8d7fbe@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 18478 Cc: 18478@debbugs.gnu.org, Tom Willemse X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > > FWIW, I don't put a lot of stock in checkdoc, personally. ;-) >=20 > Its recommendations shouldn't be heeded blindly, indeed, but the > 80-columns limit is something that should really be obeyed > whenever possible. Agreed wrt respecting doc-string line-length conventions. But 80 chars is the absolute limit. Doc strings should really be=20 quite a bit shorter than that. `emacs-lisp-docstring-fill-column' defaults to 65, for example. The actual convention is this (from (elisp) `Documentation Tips'): Format the documentation string so that it fits in an Emacs window on an 80-column screen. It is a good idea for most lines to be no wider than 60 characters. The first line should not be wider than ^^^^^^^^^^^^^ 67 characters or it will look bad in the output of `apropos'. You can fill the text if that looks good. Emacs Lisp mode fills documentation strings to the width specified by `emacs-lisp-docstring-fill-column'. However, you can sometimes make a documentation string much more readable by adjusting its line breaks with care. Use blank lines between sections if the documentation string is long. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 20 19:51:11 2014 Received: (at 18478) by debbugs.gnu.org; 20 Sep 2014 23:51:11 +0000 Received: from localhost ([127.0.0.1]:46912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVUQo-0002Gg-V7 for submit@debbugs.gnu.org; Sat, 20 Sep 2014 19:51:11 -0400 Received: from r0.smtpout1.alwaysdata.com ([176.31.58.0]:58424) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVUQm-0002GX-Ek for 18478@debbugs.gnu.org; Sat, 20 Sep 2014 19:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=alwaysdata.net; s=ryuslash; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=xfJ3D6tLbHlAQL6mbs5AhrMxUwL02xH+XNfSiD1BruA=; b=GC2BEJhKRDP7sRgs7ioonPFVFHe7ziBz3lG1Kl2KrMj9ejgF//gr+qmm39udrdHSrOlASEAnsT8fA8F1cghHLH4y/5E4qR/UJ+bW1Qea5YbBGvvVZZ+YXcqPDnqIuHFHhxcAKFF4dd3fpC/zvz5T/psxrM1fxBcqoSQRv5SRsUQ=; Received: from [2a02:1812:2193:2c00:f24d:a2ff:fede:451c] (helo=localhost) by smtpout1.alwaysdata.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.77) (envelope-from ) id 1XVUQd-0000T3-Ey; Sun, 21 Sep 2014 01:50:59 +0200 From: Tom Willemse To: Drew Adams , Stefan Monnier Subject: Re: bug#18478: [Patch] Mention the return value of `clone-indirect-buffer' References: <9cf30244-8e2e-4c74-8cf8-1476ec97c61f@default> <4919c10d-ac35-475d-9b66-12deaa8d7fbe@default> <15a58b6b-44ef-47d7-8f34-73ac54b6c16d@default> Date: Sun, 21 Sep 2014 01:50:59 +0200 In-Reply-To: <15a58b6b-44ef-47d7-8f34-73ac54b6c16d@default> (Drew Adams's message of "Wed, 17 Sep 2014 21:05:24 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-alwaysdata-ID: 22639614 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18478 Cc: 18478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Hey Drew, Stefan, Thanks for both your responses. I've attached the same patch with the simplification suggested by Drew. Whomever applies one can pick which they prefer. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=fix-18478-2.patch Content-Description: Patch # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: tom@ryuslash.org-20140920232659-ssj464v1st1f79od # target_branch: bzr://bzr.sv.gnu.org/emacs/trunk/ # testament_sha1: fffb97df6a9ff5f3ca2f27f89d88d4797e7ab334 # timestamp: 2014-09-21 01:27:28 +0200 # base_revision_id: dgutov@yandex.ru-20140919173311-0sqv853yxogkno1j # # Begin patch === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2014-09-19 17:33:11 +0000 +++ lisp/ChangeLog 2014-09-20 23:26:59 +0000 @@ -1,3 +1,7 @@ +2014-09-20 Tom Willemse + + * simple.el (clone-indirect-buffer): Mention the return value. + 2014-09-19 Dmitry Gutov * emacs-lisp/lisp.el (lisp-completion-at-point): Only calculate === modified file 'lisp/simple.el' --- lisp/simple.el 2014-08-28 01:59:29 +0000 +++ lisp/simple.el 2014-09-20 23:26:59 +0000 @@ -7577,7 +7577,9 @@ This is always done when called interactively. Optional third arg NORECORD non-nil means do not put this buffer at the -front of the list of recently selected ones." +front of the list of recently selected ones. + +Returns the newly created indirect buffer." (interactive (progn (if (get major-mode 'no-clone-indirect) # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWed9NqYAAi1fgAAwUHP/91oG FIC////wUAR5XgTm1yhAEEkk0qfo1T9GEYBNMKj9SepmoPUNNAJVGKaaeU9TZT1GmgGgAAAAEoIT SNHkkZpB6gABo0GgBgNAAANAAAAAAEkhMU2QBIT9TCh6mTaUZBp6noyKYWl7ukttey9ZvW3RoTTq vjnQRYznqjYshW7Y+ZOp3EFRRduxN0Jbyq16kXVkMMuI3qW/sT2bWPQWI+6B9oRy93UcD/WgMJ7G u8WOOcpXLsEDCKVjyM7Lt4fRjQ+So0AUDIwcJpWpPconEoD61rvwdC2wQ9g0N5Wkjst7ZCoywdo/ rYk+bhJxGA8DeVHCeWHT0I9aicAWKZGD8ohVXso2Bz2oczYr0tDQWFKCjJ32uxfq5oDxMPErgvxO O74lKKa1MA7D5UkS4WZitmGb9MzI15AeQfoCOZWj96VfJyFACAvWQGw9+mBjjYBP21L5QNXIwOWG 2M9zoEigbrh4uNoFA2gOtnaTxmV8wptULSt4wgtEri5jnEzfgC4E6PIK42nKikloMQAdNZAghcZT I8LEsNKMgNQiO36JiJMnhJbWHzVAwgWICYTCCqlUtMIBMLkc0joQwbTAibRE6sl8opIhhbA3PeDB RKtBFfQpa12CZKHsqojFUg6uTrktJnaOCscnzfK6WOEYiwAawgJwMDMB8HQ1U+a0uMbjMXAbClFe mdRZzB7mWUmSDAsrWik0LJqc6anzvtY0cw5vAbrw/sd90jvCSoMzN/0nlSDeDD7hpGR6dnhcUkAr 7SL/U2HZ90miPhSTEz/MJVpbIlmIuOLa2QZm7UfAQDvmXziwFqXmF11yHd3Ett2eU7/9M8ph5jJk MWmXN/YePzpgEg8HPRH6UwsC8OScooZBcDEyCOIpHpVv9FPn2MumOxqQk2znbuAyKp9rWCGTeXks YvlhwFryaiMr80Sx4tV4cX1HI5r9knkoAnUl1ceU+WBvPZkP3huRDmYFBkba4gQFoupoc1eJlQtV +jQ2NKXHF7UKpI0+MTIYeD/W0OvQRzc4Xq44hW5DjvtK/z7oayq7Be48uRp+ENIr9u3B8yaKLNH1 XSA5gPkGGpkjyDDegkibgcI4nihgfA+hrwzic5FxOJ6a8jBhHBWHbQ32QgoIoNAiMi8jBDAyeD3P WewVFKU0EmCjlv4BuF4gTqe2R6h7mgjWqVh/E9yij7pF62es2DvO703fBhgeosiW0N4pht3CaaOu lNFYk43cHKSQ+fJ6qscoYRjmDLxEZQnk7MuuwEN3sXEDn+G0RAtAoHTQRYdQvqA/oA+4V/bTJwzg HuOQPZ8Lsg4sEN/C0tWpqmH+BcixaA0mDLFdCAMD6ZTosI6FiI1DuB7BzCo+guC8p0d24imE4JAZ E1DMZh4cI/IYVqL/i7kinChIc76bUwA= --=-=-= Content-Type: text/plain Cheers, Tom --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 21 18:10:11 2014 Received: (at 18478) by debbugs.gnu.org; 21 Sep 2014 22:10:12 +0000 Received: from localhost ([127.0.0.1]:47780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVpKc-000519-Qo for submit@debbugs.gnu.org; Sun, 21 Sep 2014 18:10:11 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:20390) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVpKa-000510-0k for 18478@debbugs.gnu.org; Sun, 21 Sep 2014 18:10:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNFpZEG/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOAEDqRmBaoNMIQ X-IPAS-Result: ArUGAIDvNVNFpZEG/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOAEDqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="90496466" Received: from 69-165-145-6.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.165.145.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 21 Sep 2014 18:10:07 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 5C317AE80E; Sun, 21 Sep 2014 18:10:07 -0400 (EDT) From: Stefan Monnier To: Tom Willemse Subject: Re: bug#18478: [Patch] Mention the return value of `clone-indirect-buffer' Message-ID: References: <9cf30244-8e2e-4c74-8cf8-1476ec97c61f@default> <4919c10d-ac35-475d-9b66-12deaa8d7fbe@default> <15a58b6b-44ef-47d7-8f34-73ac54b6c16d@default> Date: Sun, 21 Sep 2014 18:10:07 -0400 In-Reply-To: (Tom Willemse's message of "Sun, 21 Sep 2014 01:50:59 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18478 Cc: Drew Adams , 18478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Thanks for both your responses. I've attached the same patch with the > simplification suggested by Drew. Whomever applies one can pick which > they prefer. Thanks, installed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 09:53:42 2016 Received: (at control) by debbugs.gnu.org; 30 Apr 2016 13:53:42 +0000 Received: from localhost ([127.0.0.1]:56523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awVL4-00011h-MH for submit@debbugs.gnu.org; Sat, 30 Apr 2016 09:53:42 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:56828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awVL3-00011Z-8j for control@debbugs.gnu.org; Sat, 30 Apr 2016 09:53:41 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awVL1-0002tv-3Q for control@debbugs.gnu.org; Sat, 30 Apr 2016 15:53:40 +0200 Date: Sat, 30 Apr 2016 15:53:38 +0200 Message-Id: <87shy3qk2l.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #18478 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 18478 fixed close 18478 25.1 From unknown Thu Aug 14 18:38:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 29 May 2016 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator