From unknown Mon Aug 18 14:24:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18476 <18476@debbugs.gnu.org> To: bug#18476 <18476@debbugs.gnu.org> Subject: Status: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep Reply-To: bug#18476 <18476@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:24:48 +0000 retitle 18476 24.3.93; ede-emacs-version: Searching for program: no such fi= le or directory, egrep reassign 18476 emacs submitter 18476 Lars Ljung severity 18476 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 14 14:11:37 2014 Received: (at submit) by debbugs.gnu.org; 14 Sep 2014 18:11:37 +0000 Received: from localhost ([127.0.0.1]:40911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTEGu-0006rl-Ex for submit@debbugs.gnu.org; Sun, 14 Sep 2014 14:11:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40957) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTEGs-0006rd-7x for submit@debbugs.gnu.org; Sun, 14 Sep 2014 14:11:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTEGi-0001HX-04 for submit@debbugs.gnu.org; Sun, 14 Sep 2014 14:11:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTEGh-0001HO-SS for submit@debbugs.gnu.org; Sun, 14 Sep 2014 14:11:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTEGa-0000Kg-B0 for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 14:11:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTEGS-0001Eg-RU for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 14:11:16 -0400 Received: from mail3.surf-town.net ([212.97.132.43]:42078 helo=mailgw19.surf-town.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTEGS-0001EQ-Kv for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 14:11:08 -0400 Received: by mailgw19.surf-town.net (Postfix, from userid 65534) id C3247111887; Sun, 14 Sep 2014 20:11:06 +0200 (CEST) Received: from localhost (unknown [127.0.0.1]) by mailgw19.surf-town.net (Postfix) with ESMTP id A46B6111886 for ; Sun, 14 Sep 2014 20:11:06 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mailgw19.surf-town.net Received: from mailgw19.surf-town.net ([127.0.0.1]) by localhost (mailgw19.surf-town.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7J8TV3omW8JE for ; Sun, 14 Sep 2014 20:11:04 +0200 (CEST) Received: from [192.168.0.139] (unknown [80.216.209.105]) (Authenticated sender: lars@matholka.se) by mailgw19.surf-town.net (Postfix) with ESMTPSA id 46300111888 for ; Sun, 14 Sep 2014 20:11:04 +0200 (CEST) Message-ID: <5415DA37.8050904@matholka.se> Date: Sun, 14 Sep 2014 20:11:03 +0200 From: Lars Ljung User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, Every time I open a file in the Emacs source tree I see the message "ede-emacs-version: Searching for program: no such file or directory, egrep". Also, Emacs does not switch to the newly created buffer so I have to switch to it manually. This only happens on Windows, where I don't have egrep installed. It is caused by line 86 in lisp/cedet/ede/emacs.el: (call-process "egrep" nil buff nil "-n" "-e" "AC_INIT" configure_ac) I don't think this line is even necessary. The file content is inserted and parsed further down. Kind regards, Lars Ljung From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 15 16:16:18 2014 Received: (at 18476) by debbugs.gnu.org; 15 Sep 2014 20:16:18 +0000 Received: from localhost ([127.0.0.1]:41648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTch7-0006BV-EA for submit@debbugs.gnu.org; Mon, 15 Sep 2014 16:16:17 -0400 Received: from randomsample.de ([5.45.97.173]:32999) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTch4-0006BM-TB for 18476@debbugs.gnu.org; Mon, 15 Sep 2014 16:16:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=scApUV0RYmpdXUcICW06eBm8h2POl1fud6Svy07YXuk=; b=hnjb7Siz86jlZ2UUxUwLGCLLwC02+ItXtKA1hhD12m3RK2TyXWpSTwdqqXeKr9ubgGE9z3Qv3WCb1BKMXY0sVbeIWbq0BFz5j1V/FMnuiuldZe9PAYMBrv11mOry/86/; Received: from dslc-082-083-061-139.pools.arcor-ip.net ([82.83.61.139] helo=spaten) by randomsample.de with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XTch2-0008Vk-77; Mon, 15 Sep 2014 22:16:12 +0200 From: David Engster To: Lars Ljung Subject: Re: bug#18476: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep In-Reply-To: <5415DA37.8050904@matholka.se> (Lars Ljung's message of "Sun, 14 Sep 2014 20:11:03 +0200") References: <5415DA37.8050904@matholka.se> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.91 (gnu/linux) Mail-Copies-To: never Date: Mon, 15 Sep 2014 22:16:10 +0200 Message-ID: <87sijsljw5.fsf@engster.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 18476 Cc: 18476@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) --=-=-= Content-Type: text/plain Lars Ljung writes: > Every time I open a file in the Emacs source tree I see the message > "ede-emacs-version: Searching for program: no such file or directory, > egrep". Also, Emacs does not switch to the newly created buffer so I > have to switch to it manually. > > This only happens on Windows, where I don't have egrep installed. It is > caused by line 86 in lisp/cedet/ede/emacs.el: > > (call-process "egrep" nil buff nil "-n" "-e" "AC_INIT" configure_ac) > > I don't think this line is even necessary. The file content is inserted > and parsed further down. Indeed. That call to egrep seems to be some relict from the old days. Additionally, we should also make sure that configure.ac or configure.in exist. Stefan, would it be OK to install the attached patch to emacs-24, or should it go to trunk? -David --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=ede-emacs-patch.diff === modified file 'lisp/cedet/ede/emacs.el' --- lisp/cedet/ede/emacs.el 2014-04-02 15:14:50 +0000 +++ lisp/cedet/ede/emacs.el 2014-09-15 20:10:45 +0000 @@ -82,10 +82,6 @@ (setq default-directory (file-name-as-directory dir)) (or (file-exists-p configure_ac) (setq configure_ac "configure.in")) - ;(call-process "egrep" nil buff nil "-n" "-e" "^version=" "Makefile") - (call-process "egrep" nil buff nil "-n" "-e" "AC_INIT" configure_ac) - (goto-char (point-min)) - ;(re-search-forward "version=\\([0-9.]+\\)") (cond ;; Maybe XEmacs? ((file-exists-p "version.sh") @@ -113,7 +109,8 @@ ;; Insert other Emacs here... ;; Vaguely recent version of GNU Emacs? - (t + ((or (file-exists-p configure_ac) + (file-exists-p (setq configure_ac "configure.in"))) (insert-file-contents configure_ac) (goto-char (point-min)) (re-search-forward "AC_INIT(\\(?:GNU \\)?[eE]macs,\\s-*\\([0-9.]+\\)\\s-*[,)]") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 15 20:18:01 2014 Received: (at 18476) by debbugs.gnu.org; 16 Sep 2014 00:18:01 +0000 Received: from localhost ([127.0.0.1]:41858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTgT2-0003n1-KY for submit@debbugs.gnu.org; Mon, 15 Sep 2014 20:18:01 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:28708) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTgSz-0003ms-Os for 18476@debbugs.gnu.org; Mon, 15 Sep 2014 20:17:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArgGAIDvNVNFpZEG/2dsb2JhbABZgwY7gw/ANAmBFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BJoBjxiBaoFxgVsh X-IPAS-Result: ArgGAIDvNVNFpZEG/2dsb2JhbABZgwY7gw/ANAmBFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BJoBjxiBaoFxgVsh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="89808886" Received: from 69-165-145-6.dsl.teksavvy.com (HELO ceviche.home) ([69.165.145.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 15 Sep 2014 20:17:57 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 1CC9B660D3; Mon, 15 Sep 2014 20:17:52 -0400 (EDT) From: Stefan Monnier To: Lars Ljung Subject: Re: bug#18476: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep Message-ID: References: <5415DA37.8050904@matholka.se> <87sijsljw5.fsf@engster.org> Date: Mon, 15 Sep 2014 20:17:52 -0400 In-Reply-To: <87sijsljw5.fsf@engster.org> (David Engster's message of "Mon, 15 Sep 2014 22:16:10 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18476 Cc: 18476@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Indeed. That call to egrep seems to be some relict from the old > days. Additionally, we should also make sure that configure.ac or > configure.in exist. > Stefan, would it be OK to install the attached patch to emacs-24, or > should it go to trunk? The patch looks safe-ish, but I'm not sure what is its impact. Can you explain when it hits? Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 16 02:13:19 2014 Received: (at 18476) by debbugs.gnu.org; 16 Sep 2014 06:13:19 +0000 Received: from localhost ([127.0.0.1]:41981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTm0s-0004G9-73 for submit@debbugs.gnu.org; Tue, 16 Sep 2014 02:13:18 -0400 Received: from randomsample.de ([5.45.97.173]:33312) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTm0n-0004Fu-Vq for 18476@debbugs.gnu.org; Tue, 16 Sep 2014 02:13:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=+LAESdi5Q3vN9SeHC7WDcBnKtYU1LqC075BdMYK7vdc=; b=SOX89DjbScihEN+WBj8qHhG6l7Xkb4Ozbz86MyiSOjTrJs6CyOTIpWqJLd5/dNzaDO3orse9FBDNhwZ2gKQy8sti4DPeJwus9FfVroCQZvPWAkhISn4vGa83YbSFqEfz; Received: from dslc-082-083-061-226.pools.arcor-ip.net ([82.83.61.226] helo=spaten) by randomsample.de with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XTm0k-0005Mo-SY; Tue, 16 Sep 2014 08:13:11 +0200 From: David Engster To: Stefan Monnier Subject: Re: bug#18476: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep In-Reply-To: (Stefan Monnier's message of "Mon, 15 Sep 2014 20:17:52 -0400") References: <5415DA37.8050904@matholka.se> <87sijsljw5.fsf@engster.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.91 (gnu/linux) Date: Tue, 16 Sep 2014 08:13:05 +0200 Message-ID: <87oaugks9a.fsf@engster.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 18476 Cc: 18476@debbugs.gnu.org, Lars Ljung X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Stefan Monnier writes: >> Indeed. That call to egrep seems to be some relict from the old >> days. Additionally, we should also make sure that configure.ac or >> configure.in exist. > >> Stefan, would it be OK to install the attached patch to emacs-24, or >> should it go to trunk? > > The patch looks safe-ish, but I'm not sure what is its impact. Can you > explain when it hits? It hits when the user has any kind of S?X?Emacs source code checked out and - has enabled EDE mode, - has the Emacs source in a directory which is considered 'safe' (w.r.t. ede-project-directories), and - loads any file from the Emacs source. Then EDE will try to detect the Emacs project (S?X?Emacs and version). -David From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 16 09:51:02 2014 Received: (at 18476) by debbugs.gnu.org; 16 Sep 2014 13:51:03 +0000 Received: from localhost ([127.0.0.1]:42301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTt9p-0000jc-Hd for submit@debbugs.gnu.org; Tue, 16 Sep 2014 09:51:02 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:60366) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTt9m-0000jS-8u for 18476@debbugs.gnu.org; Tue, 16 Sep 2014 09:50:59 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 32F7684F94; Tue, 16 Sep 2014 09:50:57 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 3DC7C1E5913; Tue, 16 Sep 2014 09:50:26 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 23864B42B3; Tue, 16 Sep 2014 09:50:26 -0400 (EDT) From: Stefan Monnier To: David Engster Subject: Re: bug#18476: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep Message-ID: References: <5415DA37.8050904@matholka.se> <87sijsljw5.fsf@engster.org> <87oaugks9a.fsf@engster.org> Date: Tue, 16 Sep 2014 09:50:26 -0400 In-Reply-To: <87oaugks9a.fsf@engster.org> (David Engster's message of "Tue, 16 Sep 2014 08:13:05 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 18476 Cc: 18476@debbugs.gnu.org, Lars Ljung X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > It hits when the user has any kind of S?X?Emacs source code checked > out and > - has enabled EDE mode, OK, we can expect users to enable that, indeed. > - has the Emacs source in a directory which is considered 'safe' > (w.r.t. ede-project-directories), and I.e. either ede-project-directories explicitly accepts this particular directory or it's set to t. If the dir is explicitly listed, then we can say "the user gets what she asked for". But indeed if it's t we don't have that defense. You say "safe" but the docstring of ede-project-directories doesn't mention anything about safety or lack thereof. Is it dangerous to set it to t? By the way, looking at the code of ede-emacs-version, we need to fix all those "match-string without checking the success of the previous re-search-forward". Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 16 17:33:38 2014 Received: (at 18476) by debbugs.gnu.org; 16 Sep 2014 21:33:38 +0000 Received: from localhost ([127.0.0.1]:42738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XU0NV-00048Y-RK for submit@debbugs.gnu.org; Tue, 16 Sep 2014 17:33:38 -0400 Received: from randomsample.de ([5.45.97.173]:34025) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XU0NR-00048H-UJ for 18476@debbugs.gnu.org; Tue, 16 Sep 2014 17:33:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=tO8KrDhVssqllJnWhV3HN8bRc16Uo6J3o8j9qEQM+68=; b=S6akmCeGp80FlNB/vkMMZ8aJvDtfYe+fdhlUEWCNbt9JPoI1y8+4dKKxRZam30pL/UOSp8q4rHVbQSPX07qEC93mJkK8YACSNKTTNqvmHgYRxWlgzzOufZuh1h+DEdCJ; Received: from dslc-082-083-060-210.pools.arcor-ip.net ([82.83.60.210] helo=spaten) by randomsample.de with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XU0NO-0005Bq-Nm; Tue, 16 Sep 2014 23:33:31 +0200 From: David Engster To: Stefan Monnier Subject: Re: bug#18476: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep In-Reply-To: (Stefan Monnier's message of "Tue, 16 Sep 2014 09:50:26 -0400") References: <5415DA37.8050904@matholka.se> <87sijsljw5.fsf@engster.org> <87oaugks9a.fsf@engster.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.91 (gnu/linux) Date: Tue, 16 Sep 2014 23:33:22 +0200 Message-ID: <87d2avl07x.fsf@engster.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 18476 Cc: 18476@debbugs.gnu.org, Lars Ljung X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Stefan Monnier writes: >> - has the Emacs source in a directory which is considered 'safe' >> (w.r.t. ede-project-directories), and > > I.e. either ede-project-directories explicitly accepts this particular > directory or it's set to t. If the dir is explicitly listed, then we > can say "the user gets what she asked for". But indeed if it's t we > don't have that defense. > > You say "safe" but the docstring of ede-project-directories doesn't > mention anything about safety or lack thereof. Is it dangerous to set > it to t? I don't think so. The Long Answer: This variable was part of the EDE security fix which lead to the 23.4 release. If you remember, EDE used to simply evaluate the "Project.ede" files to load a project - code is data, after all - but that made it easy for an attacker to let your Emacs execute arbitrary code. The "real" fix was that EDE now parses the Project.ede files if it actually contains a project definition. However, that code which does the parsing isn't really trivial, so we also added `ede-project-directories' with 'nil' as default. The idea was that when people create their own projects, those should get added semi-automatically, but if you wanted to load external ones, you'd have to add those directories by hand. > By the way, looking at the code of ede-emacs-version, we need to fix all > those "match-string without checking the success of the previous > re-search-forward". Yes, definitely. I can do that, but at least for the emacs-24 branch I wanted to keep the patch short. -David From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 16 21:05:47 2014 Received: (at 18476) by debbugs.gnu.org; 17 Sep 2014 01:05:47 +0000 Received: from localhost ([127.0.0.1]:42796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XU3go-0000sX-HY for submit@debbugs.gnu.org; Tue, 16 Sep 2014 21:05:46 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:42619) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XU3gj-0000sN-Tm for 18476@debbugs.gnu.org; Tue, 16 Sep 2014 21:05:42 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNFpZEG/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqgXGBWyE X-IPAS-Result: ArYGAIDvNVNFpZEG/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCw4mEhQYDSSIBAjSGReOegeEOASpGYFqgXGBWyE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="89984336" Received: from 69-165-145-6.dsl.teksavvy.com (HELO ceviche.home) ([69.165.145.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 Sep 2014 21:05:40 -0400 Received: by ceviche.home (Postfix, from userid 20848) id CCD67660D3; Tue, 16 Sep 2014 21:05:40 -0400 (EDT) From: Stefan Monnier To: David Engster Subject: Re: bug#18476: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep Message-ID: References: <5415DA37.8050904@matholka.se> <87sijsljw5.fsf@engster.org> <87oaugks9a.fsf@engster.org> <87d2avl07x.fsf@engster.org> Date: Tue, 16 Sep 2014 21:05:40 -0400 In-Reply-To: <87d2avl07x.fsf@engster.org> (David Engster's message of "Tue, 16 Sep 2014 23:33:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18476 Cc: 18476@debbugs.gnu.org, Lars Ljung X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > The "real" fix was that EDE now parses the Project.ede files if it > actually contains a project definition. However, that code which does > the parsing isn't really trivial, so we also added > `ede-project-directories' with 'nil' as default. The idea was that when > people create their own projects, those should get added > semi-automatically, but if you wanted to load external ones, you'd have > to add those directories by hand. OK, if it doesn't end up taking some of that data and passing it to `eval' or pushing it onto a hook or somesuch, then it's OK. >> By the way, looking at the code of ede-emacs-version, we need to fix all >> those "match-string without checking the success of the previous >> re-search-forward". > Yes, definitely. I can do that, but at least for the emacs-24 branch I > wanted to keep the patch short. OK, sounds fair. Please install the patch. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 18 16:40:12 2014 Received: (at 18476-done) by debbugs.gnu.org; 18 Sep 2014 20:40:12 +0000 Received: from localhost ([127.0.0.1]:44825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUiUu-0006Qm-7J for submit@debbugs.gnu.org; Thu, 18 Sep 2014 16:40:12 -0400 Received: from randomsample.de ([5.45.97.173]:35996) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUiUq-0006QY-Mq for 18476-done@debbugs.gnu.org; Thu, 18 Sep 2014 16:40:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=fpIdAOJuH27XJR+Sh2Grg5nxkeM4WYhTjEvR2weXdJw=; b=AIdrD0E/3qSb8qrJ/YqNLkke6bSc+tzXthTj5HARPm0qT0c4LSVJuVMQQ4Bf5REQgcokmiZ8L3ocDsaTYXz2JKLSlGKHo4+kDlgGoB8PxuDI1rur7slwR5Xv9m21M3YE; Received: from dslc-082-083-041-092.pools.arcor-ip.net ([82.83.41.92] helo=spaten) by randomsample.de with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XUiUm-0005Xu-FS; Thu, 18 Sep 2014 22:40:06 +0200 From: David Engster To: Stefan Monnier Subject: Re: bug#18476: 24.3.93; ede-emacs-version: Searching for program: no such file or directory, egrep In-Reply-To: (Stefan Monnier's message of "Tue, 16 Sep 2014 21:05:40 -0400") References: <5415DA37.8050904@matholka.se> <87sijsljw5.fsf@engster.org> <87oaugks9a.fsf@engster.org> <87d2avl07x.fsf@engster.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.91 (gnu/linux) Mail-Copies-To: never Date: Thu, 18 Sep 2014 22:40:01 +0200 Message-ID: <87d2asbr32.fsf@engster.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18476-done Cc: Lars Ljung , 18476-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: > OK, sounds fair. Please install the patch. Done. -David From unknown Mon Aug 18 14:24:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 17 Oct 2014 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator