From unknown Sat Aug 16 18:45:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18468: Issues with alignment and m68k register naming Resent-From: Rob Browning Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 13 Sep 2014 18:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18468 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 18468@debbugs.gnu.org Cc: 649718-forwarded@bugs.debian.org, Thorsten Glaser , 649718@bugs.debian.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141063348712351 (code B ref -1); Sat, 13 Sep 2014 18:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Sep 2014 18:38:07 +0000 Received: from localhost ([127.0.0.1]:40407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XSsD0-0003D9-Q0 for submit@debbugs.gnu.org; Sat, 13 Sep 2014 14:38:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32782) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XSsCw-0003Cj-Aj for submit@debbugs.gnu.org; Sat, 13 Sep 2014 14:38:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSsCr-0001et-Mh for submit@debbugs.gnu.org; Sat, 13 Sep 2014 14:38:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSsCr-0001ep-Kc for submit@debbugs.gnu.org; Sat, 13 Sep 2014 14:37:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSsCn-0004UH-7j for bug-guile@gnu.org; Sat, 13 Sep 2014 14:37:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSsCe-0001ar-QH for bug-guile@gnu.org; Sat, 13 Sep 2014 14:37:53 -0400 Received: from defaultvalue.org ([70.85.129.156]:36885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSsCe-0001Y5-KS for bug-guile@gnu.org; Sat, 13 Sep 2014 14:37:44 -0400 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 2E0BF20B1C; Sat, 13 Sep 2014 13:37:43 -0500 (CDT) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id D9C1714E189; Sat, 13 Sep 2014 13:37:42 -0500 (CDT) From: Rob Browning In-Reply-To: References: <878uq9xfg8.fsf@glaurung.internal.golden-gryphon.com> <20140511104318.GA23754@bongo.bofh.it> <87a9anwfzq.fsf@glaurung.internal.golden-gryphon.com> <87y4y7uf4y.fsf@igel.home> User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 13 Sep 2014 13:37:42 -0500 Message-ID: <87bnqjz7rd.fsf@trouble.defaultvalue.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain [If possible, please preserve the -forwarded address in any replies.] This was reported to Debian a bit back, and I thought it might be appropriate for consideration upstream. Further details can be found here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649718 And here's a standalone version of the patch from the debdiff there: --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=9000-Fix-alignment-and-m68k-registers.patch Content-Transfer-Encoding: quoted-printable Content-Description: fix-alignment-and-m68k-register.diff >From schwab@linux-m68k.org Mon May 12 18:37:51 2014 From: Andreas Schwab Message-ID: <87y4y7uf4y.fsf@igel.home> To: Thorsten Glaser Cc: Manoj Srivastava , debian-68k@lists.debian.org Date: Mon, 12 May 2014 18:37:49 +0200 X-Original-Subject: Re: Guile language support in make Subject: Fix alignment and registers for m68k Fix bogus alignment assumptions (on some architectures, =E2=80=9Cnatural=E2= =80=9D alignment is not used, which means even an uint64_t is possibly unaligned, or aligned to only a 2 byte (m68k) or 4 byte boundary). Also, fix register name for m68k. -- Thorsten Glaser writes: > and the guile-2.0 Build-Depends on m68k because guile does not > work there (and nobody appears capable enough to debug it)? --- a/libguile/gsubr.c +++ b/libguile/gsubr.c @@ -213,7 +213,7 @@ */ static const struct { - scm_t_uint64 dummy; /* ensure 8-byte alignment; perhaps there's a better= way */ + scm_t_uint64 dummy SCM_ALIGNED (sizeof (scm_t_uint64)); /* ensure 8-byte= alignment; perhaps there's a better way */ const scm_t_uint8 bytes[121 * (sizeof (struct scm_objcode) + 16 + sizeof (struct scm_objcode) + 32)]; } raw_bytecode =3D { @@ -317,7 +317,7 @@ static const struct =20 static const struct { - scm_t_uint64 dummy; /* alignment */ + scm_t_uint64 dummy SCM_ALIGNED (sizeof (scm_t_uint64)); /* alignment */ scm_t_cell cells[121 * 2]; /* 11*11 double cells */ } objcode_cells =3D { 0, --- a/libguile/vm-engine.h +++ b/libguile/vm-engine.h @@ -74,7 +74,7 @@ #define FP_REG asm("%r16") #endif #ifdef __mc68000__ -#define IP_REG asm("a5") +#define IP_REG asm("a3") #define SP_REG asm("a4") #define FP_REG #endif --=-=-= Content-Type: text/plain -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 --=-=-=-- From unknown Sat Aug 16 18:45:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18468: Issues with alignment and m68k register naming Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 20 Sep 2014 12:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18468 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Rob Browning Cc: 649718-forwarded@bugs.debian.org, 18468@debbugs.gnu.org, Thorsten Glaser , 649718@bugs.debian.org Received: via spool by 18468-submit@debbugs.gnu.org id=B18468.14112177037748 (code B ref 18468); Sat, 20 Sep 2014 12:56:02 +0000 Received: (at 18468) by debbugs.gnu.org; 20 Sep 2014 12:55:03 +0000 Received: from localhost ([127.0.0.1]:46428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVKBq-00020u-05 for submit@debbugs.gnu.org; Sat, 20 Sep 2014 08:55:02 -0400 Received: from world.peace.net ([96.39.62.75]:49174) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVKBm-00020V-4r for 18468@debbugs.gnu.org; Sat, 20 Sep 2014 08:54:59 -0400 Received: from c-98-217-13-77.hsd1.ma.comcast.net ([98.217.13.77] helo=yeeloong.lan) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XVKBd-00067s-QX; Sat, 20 Sep 2014 08:54:49 -0400 From: Mark H Weaver References: <878uq9xfg8.fsf@glaurung.internal.golden-gryphon.com> <20140511104318.GA23754@bongo.bofh.it> <87a9anwfzq.fsf@glaurung.internal.golden-gryphon.com> <87y4y7uf4y.fsf@igel.home> <87bnqjz7rd.fsf@trouble.defaultvalue.org> Date: Sat, 20 Sep 2014 08:52:53 -0400 In-Reply-To: <87bnqjz7rd.fsf@trouble.defaultvalue.org> (Rob Browning's message of "Sat, 13 Sep 2014 13:37:42 -0500") Message-ID: <87wq8ylahm.fsf@yeeloong.lan> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649718 I pushed slightly different fixes to the stable-2.0 branch, commits 97c520fd3ff5ae0305b6d236e0bc31f794a6cce6 and 156119b0223cf14d335ebda84701a69b2ba95757. I'm closing this bug now. Thanks! Mark From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 20 08:56:47 2014 Received: (at control) by debbugs.gnu.org; 20 Sep 2014 12:56:47 +0000 Received: from localhost ([127.0.0.1]:46431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVKDW-00023A-5J for submit@debbugs.gnu.org; Sat, 20 Sep 2014 08:56:46 -0400 Received: from world.peace.net ([96.39.62.75]:49178) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVKDS-000231-TC for control@debbugs.gnu.org; Sat, 20 Sep 2014 08:56:43 -0400 Received: from c-98-217-13-77.hsd1.ma.comcast.net ([98.217.13.77] helo=yeeloong.lan) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XVKDN-00068e-Bg; Sat, 20 Sep 2014 08:56:37 -0400 From: Mark H Weaver To: control@debbugs.gnu.org Date: Sat, 20 Sep 2014 08:54:40 -0400 Message-ID: <87sijmlaen.fsf@yeeloong.lan> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 18468 thanks [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 18468 thanks [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject close 18468 thanks