GNU bug report logs - #18462
Emacs freeze with python mode and M-q

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18462 in the body.
You can then email your comments to 18462 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gaetan Kenway <gaetank <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Emacs freeze with python mode and M-q
Date: Fri, 12 Sep 2014 09:37:31 -0400

[Message part 1 (text/plain, inline)]

I ran across a odd bug the other day. Essentially, when M-q is run with an
open bracket in python mode, emacs will freeze.
To replicate the error:

$ emacs test.py

type:
def test(

then hit M-q

The version of emacs I'm using is:

GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.10.7)
 of 2014-03-07 on lamiak, modified by Debian

Its not a huge deal, it just struck me as odd since it generally really
difficult to get emacs to crash.

Thanks,

Gaetan

[Message part 2 (text/html, inline)]

Message #8 received at 18462 <at> debbugs.gnu.org (full text, mbox):

From: Leonardo Nobrega <leonobr <at> gmail.com>
To: 18462 <at> debbugs.gnu.org
Subject: Emacs freeze with python mode and M-q
Date: Tue, 30 Sep 2014 16:35:58 -0400

The second loop in python-fill-paren moves the point until the syntax
context changes. If it doesn't find a close-paren before the end of
the buffer, it loops forever.

ChangeLog entry:

    * lisp/progmodes/python.el (python-fill-paren): Break
    end-of-region loop when it reaches point-max.

Patch:

=== modified file 'lisp/progmodes/python.el'
*** lisp/progmodes/python.el    2014-09-29 18:14:08 +0000
--- lisp/progmodes/python.el    2014-09-30 20:14:37 +0000
*************** JUSTIFY should be used (if applicable) a
*** 3300,3306 ****
                            (end-of-line)
                            (when (not (python-syntax-context 'paren))
                              (skip-syntax-backward "^)")))
!                         (while (python-syntax-context 'paren)
                            (goto-char (1+ (point-marker))))
                          (point-marker)))
      (let ((paragraph-start "\f\\|[ \t]*$")
--- 3300,3307 ----
                            (end-of-line)
                            (when (not (python-syntax-context 'paren))
                              (skip-syntax-backward "^)")))
!                         (while (and (python-syntax-context 'paren)
!                                     (< (point) (point-max)))
                            (goto-char (1+ (point-marker))))
                          (point-marker)))
      (let ((paragraph-start "\f\\|[ \t]*$")

Message #13 received at 18462-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leonardo Nobrega <leonobr <at> gmail.com>
Cc: 18462-done <at> debbugs.gnu.org
Subject: Re: bug#18462: Emacs freeze with python mode and M-q
Date: Tue, 30 Sep 2014 19:01:05 -0400

> The second loop in python-fill-paren moves the point until the syntax
> context changes. If it doesn't find a close-paren before the end of
> the buffer, it loops forever.

Thanks, looks good, installed (using eobp).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.