From unknown Sun Jun 22 17:14:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved. Resent-From: Emilio Lopes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Sep 2014 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18461@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141053822717565 (code B ref -1); Fri, 12 Sep 2014 16:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Sep 2014 16:10:27 +0000 Received: from localhost ([127.0.0.1]:39587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XSTQX-0004ZE-KM for submit@debbugs.gnu.org; Fri, 12 Sep 2014 12:10:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42015) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XSTQV-0004Z6-PV for submit@debbugs.gnu.org; Fri, 12 Sep 2014 12:10:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSTQQ-0005u1-Hp for submit@debbugs.gnu.org; Fri, 12 Sep 2014 12:10:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSTQQ-0005tw-FW for submit@debbugs.gnu.org; Fri, 12 Sep 2014 12:10:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSTQO-0006Yd-T1 for bug-gnu-emacs@gnu.org; Fri, 12 Sep 2014 12:10:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSTQD-0005ds-Bc for bug-gnu-emacs@gnu.org; Fri, 12 Sep 2014 12:10:16 -0400 Received: from mail-vc0-x22c.google.com ([2607:f8b0:400c:c03::22c]:41156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSTQD-0005Ui-7u for bug-gnu-emacs@gnu.org; Fri, 12 Sep 2014 12:10:05 -0400 Received: by mail-vc0-f172.google.com with SMTP id hy10so929540vcb.3 for ; Fri, 12 Sep 2014 09:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=ao2YBOGlkQtyxa3Xk3i/9lD6pYLVu6VSeqAVMZHyJ/o=; b=TCh9PtdS9BhcjQKmE+5H4/rlGN3pYl8O/HqXs2N8alRCo/NtXwDe18xx7zb8dnIKW3 vghwYYpa+LykwCbFOqx5zSAPcH5pYPIGUzypy7mNG74E9Q9xOspEXfPkXcrXfd7Wg7MQ frXnPNjZWNSag0k7Rb/iSIlaZ2ZzQyb8Bs5+oS7GgdZETHO0wqABxZdg/9rZOSt6ldca 42P8jCkxTjcd9TWDM/+etFfUH7724rnWmVMD3K//ixV24t6OzQYeTmHWgMxSDUJ1BoYE c+lX9XQF+tZa8HXz1W7Y/MJ1kC8OuNcYayWAA8pSZeEDlRrLxM7d4FfrbVRgsUDn2qiL iowQ== X-Received: by 10.52.89.198 with SMTP id bq6mr1837795vdb.41.1410538200307; Fri, 12 Sep 2014 09:10:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.241.138 with HTTP; Fri, 12 Sep 2014 09:09:39 -0700 (PDT) From: Emilio Lopes Date: Fri, 12 Sep 2014 18:09:39 +0200 X-Google-Sender-Auth: FaSy9goXXOzQ89rXMuPt3z1b2B8 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Here is a typical backtrace: Debugger entered--Lisp error: (error "No such directory found via CDPATH environment variable") signal(error ("No such directory found via CDPATH environment variabl= e")) error("No such directory found via CDPATH environment variable") cd("~/projects/shg/firmware-trunk/master-device-control/system-superv= isor/") vc-svn-registered("~/projects/shg/firmware-trunk/master-device-contro= l/system-supervisor/") apply(vc-svn-registered "~/projects/shg/firmware-trunk/master-device-control/system-supervisor/") vc-call-backend(SVN registered "~/projects/shg/firmware-trunk/master-device-control/system-supervisor/") ... The following patch seems to fix the problem for me. Regards, Em=C3=ADlio =3D=3D=3D modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2014-09-08 13:57:19 +0000 +++ lisp/ChangeLog 2014-09-12 16:00:36 +0000 @@ -1,3 +1,10 @@ +2014-09-12 Emilio C. Lopes + + * vc/vc-svn.el (vc-svn-registered): `cd' to the project root, not + to the file's directory, in case the directory has been (re)moved, + and do this inside the `ignore-errors' form. + (vc-svn-state): Ditto, modulo `ignore-errors'. + 2014-09-08 Sam Steingold * progmodes/sql.el (sql-send-line-and-next): New command, =3D=3D=3D modified file 'lisp/vc/vc-svn.el' --- lisp/vc/vc-svn.el 2014-01-01 07:43:34 +0000 +++ lisp/vc/vc-svn.el 2014-09-12 16:00:36 +0000 @@ -135,30 +135,30 @@ (defun vc-svn-registered (file) "Check if FILE is SVN registered." - (when (vc-svn-root file) - (with-temp-buffer - (cd (file-name-directory file)) - (let* (process-file-side-effects - (status - (condition-case nil - ;; Ignore all errors. - (vc-svn-command t t file "status" "-v") - ;; Some problem happened. E.g. We can't find an `svn' - ;; executable. We used to only catch `file-error' but when - ;; the process is run on a remote host via Tramp, the error - ;; is only reported via the exit status which is turned int= o - ;; an `error' by vc-do-command. - (error nil)))) - (when (eq 0 status) - (let ((parsed (vc-svn-parse-status file))) - (and parsed (not (memq parsed '(ignored unregistered)))))))))) + (let ((dir (vc-svn-root file))) + (when dir + (with-temp-buffer + (let* (process-file-side-effects + (status + (ignore-errors + ;; In case some problem might happen. E.g. We can't + ;; find an `svn' executable. We used to only catch + ;; `file-error' but when the process is run on a + ;; remote host via Tramp, the error is only reported + ;; via the exit status which is turned into an + ;; `error' by vc-do-command. + (cd dir) + (vc-svn-command t t file "status" "-v")))) + (when (eq 0 status) + (let ((parsed (vc-svn-parse-status file))) + (and parsed (not (memq parsed '(ignored unregistered))))))))= ))) (defun vc-svn-state (file &optional localp) "SVN-specific version of `vc-state'." (let (process-file-side-effects) (setq localp (or localp (vc-stay-local-p file 'SVN))) (with-temp-buffer - (cd (file-name-directory file)) + (cd (vc-svn-root file)) (vc-svn-command t 0 file "status" (if localp "-v" "-u")) (vc-svn-parse-status file)))) From unknown Sun Jun 22 17:14:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved. Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Sep 2014 17:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Emilio Lopes Cc: 18461@debbugs.gnu.org Received: via spool by 18461-submit@debbugs.gnu.org id=B18461.141054299724952 (code B ref 18461); Fri, 12 Sep 2014 17:30:02 +0000 Received: (at 18461) by debbugs.gnu.org; 12 Sep 2014 17:29:57 +0000 Received: from localhost ([127.0.0.1]:39632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XSUfU-0006UN-Kv for submit@debbugs.gnu.org; Fri, 12 Sep 2014 13:29:57 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:52881) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XSUfR-0006UE-Nc for 18461@debbugs.gnu.org; Fri, 12 Sep 2014 13:29:54 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 4D10F8509A; Fri, 12 Sep 2014 13:29:53 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 73BCE1E5B8A; Fri, 12 Sep 2014 13:28:30 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 50BBAB41B5; Fri, 12 Sep 2014 13:28:30 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Fri, 12 Sep 2014 13:28:30 -0400 In-Reply-To: (Emilio Lopes's message of "Fri, 12 Sep 2014 18:09:39 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -4.5 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) > + (ignore-errors > + ;; In case some problem might happen. E.g. We can't > + ;; find an `svn' executable. We used to only catch > + ;; `file-error' but when the process is run on a > + ;; remote host via Tramp, the error is only reported > + ;; via the exit status which is turned into an > + ;; `error' by vc-do-command. > + (cd dir) > + (vc-svn-command t t file "status" "-v")))) Sounds OK, but I suggest we use with-demoted-errors, so the user is told in case there's a problem. Stefan From unknown Sun Jun 22 17:14:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved. Resent-From: Emilio Lopes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Sep 2014 20:38:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 18461@debbugs.gnu.org Received: via spool by 18461-submit@debbugs.gnu.org id=B18461.141055423710382 (code B ref 18461); Fri, 12 Sep 2014 20:38:05 +0000 Received: (at 18461) by debbugs.gnu.org; 12 Sep 2014 20:37:17 +0000 Received: from localhost ([127.0.0.1]:39674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XSXal-0002hM-AN for submit@debbugs.gnu.org; Fri, 12 Sep 2014 16:37:16 -0400 Received: from mail-vc0-f176.google.com ([209.85.220.176]:51620) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XSXaj-0002hB-0p for 18461@debbugs.gnu.org; Fri, 12 Sep 2014 16:37:13 -0400 Received: by mail-vc0-f176.google.com with SMTP id la4so1240204vcb.7 for <18461@debbugs.gnu.org>; Fri, 12 Sep 2014 13:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=e3wdL+ZngYHcs22DGpYHfREKKDsTQEd623pmYav/8pM=; b=S/uiw25wXFQM228tS0nppFUzq+HQ0hVJxXIqL1vyfezbnYJRmC/InwaaJV5viKKo6L 9gwP1wMCy9QtbmuBYwwEFrkwNVaGdgZMUBW6xWDYrbVjZynz9l60fPsXorogeKNHXBIu K9ptafyFu9e1l1FkSuI5zpc855R/7ORyAU/qVQ8Zd1EUqIK1HbUDpnGIgbs1YKHYOh6j rA8rIx134P9RGjU5zspej8pqS/iyjo5PssLxmBbyReNcqKjJltBwuWYb/hEVI52MIkhr 8FpcLdIHayaOVzKR/yLtlKBuaUv7YwwW5IKxrkVs7D+gAeUGIMWB6nlX0UmLWHVpjxb0 Aq4g== X-Received: by 10.52.35.105 with SMTP id g9mr4388282vdj.61.1410554232490; Fri, 12 Sep 2014 13:37:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.241.138 with HTTP; Fri, 12 Sep 2014 13:36:52 -0700 (PDT) In-Reply-To: References: From: Emilio Lopes Date: Fri, 12 Sep 2014 22:36:52 +0200 X-Google-Sender-Auth: DSyUNiSJEtZA70KlDhTH3wWxALw Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 2014-09-12 19:28 GMT+02:00 Stefan Monnier : >> + (ignore-errors >> + ;; In case some problem might happen. E.g. We can't >> + ;; find an `svn' executable. We used to only catch >> + ;; `file-error' but when the process is run on a >> + ;; remote host via Tramp, the error is only reported >> + ;; via the exit status which is turned into an >> + ;; `error' by vc-do-command. >> + (cd dir) >> + (vc-svn-command t t file "status" "-v")))) > > Sounds OK, but I suggest we use with-demoted-errors, so the user is told > in case there's a problem. Makes sense, thanks for looking at it. I'll submit a new patch the next da= ys. Em=C3=ADlio From unknown Sun Jun 22 17:14:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved. Resent-From: Emilio Lopes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Sep 2014 13:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 18461@debbugs.gnu.org Received: via spool by 18461-submit@debbugs.gnu.org id=B18461.141078768215992 (code B ref 18461); Mon, 15 Sep 2014 13:29:02 +0000 Received: (at 18461) by debbugs.gnu.org; 15 Sep 2014 13:28:02 +0000 Received: from localhost ([127.0.0.1]:41270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTWK1-00049p-Qe for submit@debbugs.gnu.org; Mon, 15 Sep 2014 09:28:02 -0400 Received: from mail-vc0-f171.google.com ([209.85.220.171]:45925) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XTWJx-00049V-5T for 18461@debbugs.gnu.org; Mon, 15 Sep 2014 09:27:57 -0400 Received: by mail-vc0-f171.google.com with SMTP id im17so3367525vcb.2 for <18461@debbugs.gnu.org>; Mon, 15 Sep 2014 06:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=79pcr02cCtzvFvMkXWCXQPfF3VYxjRaJ0e+veTSXbag=; b=CBwRp7W3hXcwaoNAYqPnSN/a2d58uPzNr0SeF6TjS0WxYpl17yiZw/uSLSVdTtqR0J aYz2gSwlLhvKxAeE4njJXeOemcgdCLFbrzRxZIck6QYTawRMfQZcr7ch8n2aeXH3hCB3 XQdEgHAc+Z7NuJ9a6jM7+kRFOq6Pv/jS5zxHos890zr85LneMyOAuGsZGOuuNiNM4fEa Fir7MYG7zp/MAktCIJjkiTL6wQl+v3qP9W6KXQ/daA+ekJ+bYjPtedopdWsi6ridBnzu 8e8cVtwffSTZp9zPyV1ibRCc+bSCqPTzoVRpHUtmNifo8H46uMCZI+NWhVcruayU1raS ZonA== X-Received: by 10.221.64.142 with SMTP id xi14mr23616381vcb.31.1410787676205; Mon, 15 Sep 2014 06:27:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.239.7 with HTTP; Mon, 15 Sep 2014 06:27:36 -0700 (PDT) In-Reply-To: References: From: Emilio Lopes Date: Mon, 15 Sep 2014 15:27:36 +0200 X-Google-Sender-Auth: 4-NT17VXeUfMa0RdKOmYH-MukdI Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Here is an updated patch: --- lisp/ChangeLog 2014-09-15 00:20:21 +0000 +++ lisp/ChangeLog 2014-09-15 13:22:54 +0000 @@ -1,3 +1,10 @@ +2014-09-15 Emilio C. Lopes + + * vc/vc-svn.el (vc-svn-registered): `cd' to the project root, not + to the file's directory, in case the directory has been (re)moved, + and do this inside a `with-demoted-errors' form. + (vc-svn-state): Ditto, modulo `with-demoted-errors'. + 2014-09-15 Glenn Morris * image.el (image-multi-frame-p): Fix thinko - do not force --- lisp/vc/vc-svn.el 2014-01-01 07:43:34 +0000 +++ lisp/vc/vc-svn.el 2014-09-15 13:22:54 +0000 @@ -135,30 +135,30 @@ (defun vc-svn-registered (file) "Check if FILE is SVN registered." - (when (vc-svn-root file) - (with-temp-buffer - (cd (file-name-directory file)) - (let* (process-file-side-effects - (status - (condition-case nil - ;; Ignore all errors. - (vc-svn-command t t file "status" "-v") - ;; Some problem happened. E.g. We can't find an `svn' - ;; executable. We used to only catch `file-error' but when - ;; the process is run on a remote host via Tramp, the error - ;; is only reported via the exit status which is turned into - ;; an `error' by vc-do-command. - (error nil)))) - (when (eq 0 status) - (let ((parsed (vc-svn-parse-status file))) - (and parsed (not (memq parsed '(ignored unregistered)))))))))) + (let ((dir (vc-svn-root file))) + (when dir + (with-temp-buffer + (let* ((process-file-side-effects nil) + (status + (with-demoted-errors "Error: %S" + ;; In case some problem might happen. E.g. We can't + ;; find an `svn' executable. We used to only catch + ;; `file-error' but when the process is run on a + ;; remote host via Tramp, the error is only reported + ;; via the exit status which is turned into an + ;; `error' by vc-do-command. + (cd dir) + (vc-svn-command t t file "status" "-v")))) + (when (eq 0 status) + (let ((parsed (vc-svn-parse-status file))) + (and parsed (not (memq parsed '(ignored unregistered))))))))))) (defun vc-svn-state (file &optional localp) "SVN-specific version of `vc-state'." (let (process-file-side-effects) (setq localp (or localp (vc-stay-local-p file 'SVN))) (with-temp-buffer - (cd (file-name-directory file)) + (cd (vc-svn-root file)) (vc-svn-command t 0 file "status" (if localp "-v" "-u")) (vc-svn-parse-status file)))) From unknown Sun Jun 22 17:14:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved. Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Feb 2016 12:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Emilio Lopes Cc: Stefan Monnier , 18461@debbugs.gnu.org Received: via spool by 18461-submit@debbugs.gnu.org id=B18461.145622937430378 (code B ref 18461); Tue, 23 Feb 2016 12:10:02 +0000 Received: (at 18461) by debbugs.gnu.org; 23 Feb 2016 12:09:34 +0000 Received: from localhost ([127.0.0.1]:39397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYBmY-0007tu-IF for submit@debbugs.gnu.org; Tue, 23 Feb 2016 07:09:34 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:43295) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYBmW-0007tl-0A for 18461@debbugs.gnu.org; Tue, 23 Feb 2016 07:09:32 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYBm3-0006D1-So; Tue, 23 Feb 2016 13:09:04 +0100 From: Lars Ingebrigtsen References: Date: Tue, 23 Feb 2016 23:08:58 +1100 In-Reply-To: (Emilio Lopes's message of "Mon, 15 Sep 2014 15:27:36 +0200") Message-ID: <8737sjpr1h.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYBm3-0006D1-So X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456834145.33312@Yi634lWFowHKAuR/mThHUw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Emilio Lopes writes: > + * vc/vc-svn.el (vc-svn-registered): `cd' to the project root, not > + to the file's directory, in case the directory has been (re)moved, > + and do this inside a `with-demoted-errors' form. > + (vc-svn-state): Ditto, modulo `with-demoted-errors'. >From the discussion, and glancing at the code, this seems like it should have gone in, but it apparently wasn't applied. Is this patch still required, and does it still work? (I'm not an svn user, so I can't really test.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 17:14:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved. Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2016 00:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen , Emilio Lopes Cc: Stefan Monnier , 18461@debbugs.gnu.org Received: via spool by 18461-submit@debbugs.gnu.org id=B18461.1456273353485 (code B ref 18461); Wed, 24 Feb 2016 00:23:01 +0000 Received: (at 18461) by debbugs.gnu.org; 24 Feb 2016 00:22:33 +0000 Received: from localhost ([127.0.0.1]:41808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYNDs-00007k-OJ for submit@debbugs.gnu.org; Tue, 23 Feb 2016 19:22:32 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35294) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYNDr-00007W-Pn for 18461@debbugs.gnu.org; Tue, 23 Feb 2016 19:22:32 -0500 Received: by mail-wm0-f47.google.com with SMTP id c200so246037764wme.0 for <18461@debbugs.gnu.org>; Tue, 23 Feb 2016 16:22:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=E/P/HSWpArVBUIhAc5z5u6jqlGWu5M58xdFr2Ibg4qs=; b=VyThdmDGA/PFQfw4PMWBHaVldt9D3qHjlnUKfieFSNcz4LTiUaKToBXAFSacY3QSMM KYLBRW7QpHWi4f6nbf8cU4NX3ttJJkoqrro7uSURkgdn+XnhHzDz4LSWIOoPcFDl5twx M9ng9IbijRuupIfP7MsQMoyRSnDNnVSSpT3DR1SDTHnND3YPmybsFwmDqFrZuUQrzFK9 5Ko79V4dHGSXI2bmz2L8lOozD/xI4U24qsbu/Z1kA/7jI7wFesI67koA9nyAwvgx346p JZt0jOX143s8wgsJqxAxaM9QNG7uLicP5L68Jq2BvmXQACKUGSi1d1Ok4YZxwVSmUbOM /cUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=E/P/HSWpArVBUIhAc5z5u6jqlGWu5M58xdFr2Ibg4qs=; b=iJzWb7R5TTCo1n8kwRgnpaopfHAXxCvQkkvfNnJJTqgLES8hBhT7qC64yVqqgMgh/R uh0N5TPpa1YE2DuJreUMX1jsLuhDN1KqDCqt5CDHLPTy2h4QxywfbB9fJHevHe+1Bdl4 ZLeJkSqZ9s/OdqQC6BG7HbCpHJhjLtEVp/ZnhRkZiLXj6uK/pOUjLCDUR6QYj2dV2iKc eMQzlCgDGcfNSJ+cQXyz2wABtOx69RGdJfCsXTxLFc0asa79SbjiXn7EpsAFS0H7JG8q 1e59kiZsn8keCrp28gFFgUleqzPsfmYMiH8LwOSVIdJb0AAPRAr3ppDuRi+Y0EVjYOaM ch1g== X-Gm-Message-State: AG10YOTSTguRKphgnQhr14IcMKzZyXNKJB0bwF7ehjT3V5zZ1z9ZEK+lQe2ZXaatiQfA9A== X-Received: by 10.28.135.4 with SMTP id j4mr21933887wmd.80.1456273346138; Tue, 23 Feb 2016 16:22:26 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id e9sm276421wja.25.2016.02.23.16.22.24 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Feb 2016 16:22:25 -0800 (PST) References: <8737sjpr1h.fsf@gnus.org> From: Dmitry Gutov Message-ID: <2f34d9d1-5630-5583-d2dc-bf7b594cce87@yandex.ru> Date: Wed, 24 Feb 2016 02:22:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <8737sjpr1h.fsf@gnus.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 02/23/2016 02:08 PM, Lars Ingebrigtsen wrote: > From the discussion, and glancing at the code, this seems like it should > have gone in, but it apparently wasn't applied. Is this patch still > required, and does it still work? (I'm not an svn user, so I can't > really test.) I _think_ this bug may have been fixed in 83114ccf77d2a5d59fccbdbda6edefacce1b979e, in the course of fixing http://debbugs.gnu.org/21984. (Either way, Emilio, please attach the patch as a file next time; I wasn't able to apply this one using any automated means). From unknown Sun Jun 22 17:14:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Emilio Lopes Subject: bug#18461: closed (Re: bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved.) Message-ID: References: <87bn76opcj.fsf@gnus.org> X-Gnu-PR-Message: they-closed 18461 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 18461@debbugs.gnu.org Date: Wed, 24 Feb 2016 01:44:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1456278242-27034-1" This is a multi-part message in MIME format... ------------=_1456278242-27034-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18461: `vc-svn-registered' signals an error if a directory has be (re)move= d. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18461@debbugs.gnu.org. --=20 18461: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18461 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1456278242-27034-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18461-done) by debbugs.gnu.org; 24 Feb 2016 01:43:41 +0000 Received: from localhost ([127.0.0.1]:41868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYOUP-00071N-KA for submit@debbugs.gnu.org; Tue, 23 Feb 2016 20:43:41 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:50698) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYOUO-00071F-3Y for 18461-done@debbugs.gnu.org; Tue, 23 Feb 2016 20:43:40 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYOTy-0004OW-0k; Wed, 24 Feb 2016 02:43:14 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#18461: `vc-svn-registered' signals an error if a directory has be (re)moved. References: <8737sjpr1h.fsf@gnus.org> <2f34d9d1-5630-5583-d2dc-bf7b594cce87@yandex.ru> Date: Wed, 24 Feb 2016 12:43:08 +1100 In-Reply-To: <2f34d9d1-5630-5583-d2dc-bf7b594cce87@yandex.ru> (Dmitry Gutov's message of "Wed, 24 Feb 2016 02:22:23 +0200") Message-ID: <87bn76opcj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYOTy-0004OW-0k X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456882995.13295@pmCtHaptM2MsbeSIMl0Xeg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18461-done Cc: Stefan Monnier , Emilio Lopes , 18461-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Dmitry Gutov writes: > I _think_ this bug may have been fixed in > 83114ccf77d2a5d59fccbdbda6edefacce1b979e, in the course of fixing > http://debbugs.gnu.org/21984. Ok; I'll close the bug. If it's still a problem, we can reopen... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ------------=_1456278242-27034-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Sep 2014 16:10:27 +0000 Received: from localhost ([127.0.0.1]:39587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XSTQX-0004ZE-KM for submit@debbugs.gnu.org; Fri, 12 Sep 2014 12:10:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42015) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XSTQV-0004Z6-PV for submit@debbugs.gnu.org; Fri, 12 Sep 2014 12:10:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSTQQ-0005u1-Hp for submit@debbugs.gnu.org; Fri, 12 Sep 2014 12:10:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSTQQ-0005tw-FW for submit@debbugs.gnu.org; Fri, 12 Sep 2014 12:10:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSTQO-0006Yd-T1 for bug-gnu-emacs@gnu.org; Fri, 12 Sep 2014 12:10:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSTQD-0005ds-Bc for bug-gnu-emacs@gnu.org; Fri, 12 Sep 2014 12:10:16 -0400 Received: from mail-vc0-x22c.google.com ([2607:f8b0:400c:c03::22c]:41156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSTQD-0005Ui-7u for bug-gnu-emacs@gnu.org; Fri, 12 Sep 2014 12:10:05 -0400 Received: by mail-vc0-f172.google.com with SMTP id hy10so929540vcb.3 for ; Fri, 12 Sep 2014 09:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=ao2YBOGlkQtyxa3Xk3i/9lD6pYLVu6VSeqAVMZHyJ/o=; b=TCh9PtdS9BhcjQKmE+5H4/rlGN3pYl8O/HqXs2N8alRCo/NtXwDe18xx7zb8dnIKW3 vghwYYpa+LykwCbFOqx5zSAPcH5pYPIGUzypy7mNG74E9Q9xOspEXfPkXcrXfd7Wg7MQ frXnPNjZWNSag0k7Rb/iSIlaZ2ZzQyb8Bs5+oS7GgdZETHO0wqABxZdg/9rZOSt6ldca 42P8jCkxTjcd9TWDM/+etFfUH7724rnWmVMD3K//ixV24t6OzQYeTmHWgMxSDUJ1BoYE c+lX9XQF+tZa8HXz1W7Y/MJ1kC8OuNcYayWAA8pSZeEDlRrLxM7d4FfrbVRgsUDn2qiL iowQ== X-Received: by 10.52.89.198 with SMTP id bq6mr1837795vdb.41.1410538200307; Fri, 12 Sep 2014 09:10:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.241.138 with HTTP; Fri, 12 Sep 2014 09:09:39 -0700 (PDT) From: Emilio Lopes Date: Fri, 12 Sep 2014 18:09:39 +0200 X-Google-Sender-Auth: FaSy9goXXOzQ89rXMuPt3z1b2B8 Message-ID: Subject: `vc-svn-registered' signals an error if a directory has be (re)moved. To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Here is a typical backtrace: Debugger entered--Lisp error: (error "No such directory found via CDPATH environment variable") signal(error ("No such directory found via CDPATH environment variabl= e")) error("No such directory found via CDPATH environment variable") cd("~/projects/shg/firmware-trunk/master-device-control/system-superv= isor/") vc-svn-registered("~/projects/shg/firmware-trunk/master-device-contro= l/system-supervisor/") apply(vc-svn-registered "~/projects/shg/firmware-trunk/master-device-control/system-supervisor/") vc-call-backend(SVN registered "~/projects/shg/firmware-trunk/master-device-control/system-supervisor/") ... The following patch seems to fix the problem for me. Regards, Em=C3=ADlio =3D=3D=3D modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2014-09-08 13:57:19 +0000 +++ lisp/ChangeLog 2014-09-12 16:00:36 +0000 @@ -1,3 +1,10 @@ +2014-09-12 Emilio C. Lopes + + * vc/vc-svn.el (vc-svn-registered): `cd' to the project root, not + to the file's directory, in case the directory has been (re)moved, + and do this inside the `ignore-errors' form. + (vc-svn-state): Ditto, modulo `ignore-errors'. + 2014-09-08 Sam Steingold * progmodes/sql.el (sql-send-line-and-next): New command, =3D=3D=3D modified file 'lisp/vc/vc-svn.el' --- lisp/vc/vc-svn.el 2014-01-01 07:43:34 +0000 +++ lisp/vc/vc-svn.el 2014-09-12 16:00:36 +0000 @@ -135,30 +135,30 @@ (defun vc-svn-registered (file) "Check if FILE is SVN registered." - (when (vc-svn-root file) - (with-temp-buffer - (cd (file-name-directory file)) - (let* (process-file-side-effects - (status - (condition-case nil - ;; Ignore all errors. - (vc-svn-command t t file "status" "-v") - ;; Some problem happened. E.g. We can't find an `svn' - ;; executable. We used to only catch `file-error' but when - ;; the process is run on a remote host via Tramp, the error - ;; is only reported via the exit status which is turned int= o - ;; an `error' by vc-do-command. - (error nil)))) - (when (eq 0 status) - (let ((parsed (vc-svn-parse-status file))) - (and parsed (not (memq parsed '(ignored unregistered)))))))))) + (let ((dir (vc-svn-root file))) + (when dir + (with-temp-buffer + (let* (process-file-side-effects + (status + (ignore-errors + ;; In case some problem might happen. E.g. We can't + ;; find an `svn' executable. We used to only catch + ;; `file-error' but when the process is run on a + ;; remote host via Tramp, the error is only reported + ;; via the exit status which is turned into an + ;; `error' by vc-do-command. + (cd dir) + (vc-svn-command t t file "status" "-v")))) + (when (eq 0 status) + (let ((parsed (vc-svn-parse-status file))) + (and parsed (not (memq parsed '(ignored unregistered))))))))= ))) (defun vc-svn-state (file &optional localp) "SVN-specific version of `vc-state'." (let (process-file-side-effects) (setq localp (or localp (vc-stay-local-p file 'SVN))) (with-temp-buffer - (cd (file-name-directory file)) + (cd (vc-svn-root file)) (vc-svn-command t 0 file "status" (if localp "-v" "-u")) (vc-svn-parse-status file)))) ------------=_1456278242-27034-1--