GNU bug report logs - #18454
Improve performance when -P (PCRE) is used in UTF-8 locales

Previous Next

Package: grep;

Reported by: Vincent Lefevre <vincent <at> vinc17.net>

Date: Fri, 12 Sep 2014 01:26:02 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>
Cc: Santiago Ruano Rincón <santiago <at> debian.org>, 18454 <at> debbugs.gnu.org
Subject: bug#18454: Improve performance when -P (PCRE) is used in UTF-8 locales
Date: Sat, 27 Sep 2014 15:36:37 -0700
[Message part 1 (text/plain, inline)]
Jim Meyering wrote:

> I've pushed this follow-up patch to suppress a new warning:

Thanks, I expect I didn't get that warning because I built on x86-64, which 
allows unaligned accesses so GCC doesn't complain.  (Incidentally, I had already 
tried modifying the code to exploit the fact that unaligned accesses are OK on 
x86ish platforms, but that made the word-by-word loop go slower, so no dice.)

Too bad GCC isn't smart enough to notice that the pointer must be aligned.  It 
strikes me that this problem must come up elsewhere, and that it's worth writing 
a macro to encapsulate the situation.  I pushed the attached follow-up patch, 
which is an attempt to move in that direction.
[0001-maint-generalize-the-Wcast-align-fix.patch (text/plain, attachment)]

This bug report was last modified 3 years and 181 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.