Subject: Re: bug#18426: [PATCH] Increase default size of imenu-auto-rescan-maxout

From: Alex Branham <[email-masked]>
Date: Fri, 31 Aug 2018 08:15:01 -0500

On Fri 31 Aug 2018 at 08:12, Robert Pluim <[email-masked]> wrote:

> Two nits, below

Thanks! updated patch attached

Alex

------------------------------------------------------------

>From 497e533884977caaf55db22d64164517bcdfc33b Mon Sep 17 00:00:00 2001
From: Alex Branham <[email-masked]>
Date: Fri, 31 Aug 2018 08:05:06 -0500
Subject: [PATCH] Increase default value for imenu-auto-rescan-maxout

* lisp/imenu.el (imenu-auto-rescan-maxout): Increase default value to
  600000.  (Bug#18426)
* doc/emacs/programs.texi (imenu-auto-rescan-maxout): Add
  documentation for imenu-auto-rescan-maxout.
---
 doc/emacs/programs.texi | 4 ++++
 etc/NEWS                | 4 ++++
 lisp/imenu.el           | 8 ++++----
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/doc/emacs/programs.texi b/doc/emacs/programs.texi
index 138f82a6bf..46711aaf30 100644
--- a/doc/emacs/programs.texi
+++ b/doc/emacs/programs.texi
@@ -308,6 +308,10 @@ Imenu
 a non-@code{nil} value.  There is no need to rescan because of small
 changes in the text.
 
+@vindex imenu-auto-rescan-maxout
+  @code{imenu-auto-rescan} will be disabled in buffers that are larger
+than @code{imenu-auto-rescan-maxout} in bytes.
+
 @vindex imenu-sort-function
   You can customize the way the menus are sorted by setting the
 variable @code{imenu-sort-function}.  By default, names are ordered as
diff --git a/etc/NEWS b/etc/NEWS
index f575d4dd00..90f98041be 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -50,6 +50,10 @@ often cause crashes.  Set it to nil if you really need those fonts.
 ---
 *** New toggle 'ibuffer-do-toggle-lock', bound to 'L'.
 
+** Imenu
+---
+*** The value for 'imenu-auto-rescan-maxout' has been increased to 600000.
+
 ** Gnus
 
 ---
diff --git a/lisp/imenu.el b/lisp/imenu.el
index 89114524eb..2608eb259a 100644
--- a/lisp/imenu.el
+++ b/lisp/imenu.el
@@ -96,11 +96,11 @@ imenu-auto-rescan
   :type 'boolean
   :group 'imenu)
 
-(defcustom imenu-auto-rescan-maxout 60000
-  "Imenu auto-rescan is disabled in buffers larger than this size (in bytes).
-This variable is buffer-local."
+(defcustom imenu-auto-rescan-maxout 600000
+  "Imenu auto-rescan is disabled in buffers larger than this size (in bytes)."
   :type 'integer
-  :group 'imenu)
+  :group 'imenu
+  :version "26.2")
 
 (defvar imenu-always-use-completion-buffer-p nil)
 (make-obsolete-variable 'imenu-always-use-completion-buffer-p
-- 
2.18.0

>From 497e533884977caaf55db22d64164517bcdfc33b Mon Sep 17 00:00:00 2001
From: Alex Branham <[email-masked]>
Date: Fri, 31 Aug 2018 08:05:06 -0500
Subject: [PATCH] Increase default value for imenu-auto-rescan-maxout

* lisp/imenu.el (imenu-auto-rescan-maxout): Increase default value to
  600000.  (Bug#18426)
* doc/emacs/programs.texi (imenu-auto-rescan-maxout): Add
  documentation for imenu-auto-rescan-maxout.
---
 doc/emacs/programs.texi | 4 ++++
 etc/NEWS                | 4 ++++
 lisp/imenu.el           | 8 ++++----
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/doc/emacs/programs.texi b/doc/emacs/programs.texi
index 138f82a6bf..46711aaf30 100644
--- a/doc/emacs/programs.texi
+++ b/doc/emacs/programs.texi
@@ -308,6 +308,10 @@ Imenu
 a non-@code{nil} value.  There is no need to rescan because of small
 changes in the text.
 
+@vindex imenu-auto-rescan-maxout
+  @code{imenu-auto-rescan} will be disabled in buffers that are larger
+than @code{imenu-auto-rescan-maxout} in bytes.
+
 @vindex imenu-sort-function
   You can customize the way the menus are sorted by setting the
 variable @code{imenu-sort-function}.  By default, names are ordered as
diff --git a/etc/NEWS b/etc/NEWS
index f575d4dd00..90f98041be 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -50,6 +50,10 @@ often cause crashes.  Set it to nil if you really need those fonts.
 ---
 *** New toggle 'ibuffer-do-toggle-lock', bound to 'L'.
 
+** Imenu
+---
+*** The value for 'imenu-auto-rescan-maxout' has been increased to 600000.
+
 ** Gnus
 
 ---
diff --git a/lisp/imenu.el b/lisp/imenu.el
index 89114524eb..2608eb259a 100644
--- a/lisp/imenu.el
+++ b/lisp/imenu.el
@@ -96,11 +96,11 @@ imenu-auto-rescan
   :type 'boolean
   :group 'imenu)
 
-(defcustom imenu-auto-rescan-maxout 60000
-  "Imenu auto-rescan is disabled in buffers larger than this size (in bytes).
-This variable is buffer-local."
+(defcustom imenu-auto-rescan-maxout 600000
+  "Imenu auto-rescan is disabled in buffers larger than this size (in bytes)."
   :type 'integer
-  :group 'imenu)
+  :group 'imenu
+  :version "26.2")
 
 (defvar imenu-always-use-completion-buffer-p nil)
 (make-obsolete-variable 'imenu-always-use-completion-buffer-p
-- 
2.18.0