GNU bug report logs - #18424
[PATCH 2/2] maint: avoid distcheck failure

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18424 in the body.
You can then email your comments to 18424 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: bug-grep <at> gnu.org
Subject: [PATCH 2/2] maint: avoid distcheck failure
Date: Mon, 8 Sep 2014 09:01:30 -0700

[Message part 1 (text/plain, inline)]

Surprised to see "make distcheck" failing.
Here's the fix:

[0002-maint-avoid-distcheck-failure.patch (application/octet-stream, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: bug-grep <at> gnu.org
Subject: Re: bug#18424: [PATCH 2/2] maint: avoid distcheck failure
Date: Mon, 08 Sep 2014 09:58:31 -0700

Thanks, that patch looks fine.

By the way, it's simpler for me (and I assume others) if patches like 
these are simply applied to the master.  Grep development is so 
lackadaisical that the hassle of dealing with patches floating around 
but not installed is greater than the hassle of dealing with the rare 
patches installed into the trunk too hastily.  Admittedly maintenance 
styles differ and the email style is good too, but I just thought I'd 
say what was on my mind....

Message #11 received at 18424 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 18424 <at> debbugs.gnu.org
Subject: Re: bug#18424: [PATCH 2/2] maint: avoid distcheck failure
Date: Wed, 10 Sep 2014 20:22:32 -0700

On Mon, Sep 8, 2014 at 9:58 AM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> Thanks, that patch looks fine.
>
> By the way, it's simpler for me (and I assume others) if patches like these
> are simply applied to the master.  Grep development is so lackadaisical that
> the hassle of dealing with patches floating around but not installed is
> greater than the hassle of dealing with the rare patches installed into the
> trunk too hastily.  Admittedly maintenance styles differ and the email style
> is good too, but I just thought I'd say what was on my mind....

Thanks for the review.

For a patch like this that is trivial, that approach makes sense.
For more involved ones, I find that waiting a day or so is prudent,
even if I'm the only one thinking about it.

Normally I do not wait as long between post and push as I did
for these two.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.