From unknown Fri Jun 20 07:18:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18413 <18413@debbugs.gnu.org> To: bug#18413 <18413@debbugs.gnu.org> Subject: Status: Inline part displayed in the middle of its button Reply-To: bug#18413 <18413@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:18:22 +0000 retitle 18413 Inline part displayed in the middle of its button reassign 18413 emacs,gnus submitter 18413 Stefan Monnier severity 18413 normal tag 18413 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 05 14:10:15 2014 Received: (at submit) by debbugs.gnu.org; 5 Sep 2014 18:10:15 +0000 Received: from localhost ([127.0.0.1]:60062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPxxf-0004dE-5E for submit@debbugs.gnu.org; Fri, 05 Sep 2014 14:10:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41251) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPxxc-0004d0-Ed for submit@debbugs.gnu.org; Fri, 05 Sep 2014 14:10:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPxxP-0000mF-0p for submit@debbugs.gnu.org; Fri, 05 Sep 2014 14:10:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPxxO-0000mB-Ty for submit@debbugs.gnu.org; Fri, 05 Sep 2014 14:09:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPxxH-0004Sj-Jh for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 14:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPxx8-0000dV-Cq for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 14:09:49 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:42250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPxx8-0000cb-5O for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2014 14:09:42 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id D5EA685039 for ; Fri, 5 Sep 2014 14:09:41 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 652BB1E5B8A for ; Fri, 5 Sep 2014 14:09:16 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 43388B41B5; Fri, 5 Sep 2014 14:09:16 -0400 (EDT) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: Inline part displayed in the middle of its button Date: Fri, 05 Sep 2014 14:09:16 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Package: emacs,gnus Version: 24.4.50 Here's what I do: - start Gnus - visit a message with an Elisp attachment (in my case I tested with a message from Tom on emacs-devel with subject "Re: History for query replace pairs" and with an attachment of type "application/emacs-lisp"). - place cursor in the middle of the attachment's button (using keyboard commands). - press E Result: the attachment is shown inline, but right in the middle of the button. IOW I get "[4. applicati" (from the button's text before point), followed by the attachment's content, followed by "on/emacs-lisp; hist.el]". The whole is in bold for me, because the button is an overlay with `bold' face, so the face ends up covering the inline attachment as well. It seems to be the result of the hunk below. Stefan revno: 117041 committer: Katsumi Yamaoka branch nick: trunk timestamp: Fri 2014-05-02 09:44:34 +0000 message: Gnus: Make gnus-mime-inline-part and gnus-mime-inline-part work similarly * gnus-art.el (gnus-mime-inline-part): Redisplay a button so as to show the displaying state of a part. (gnus-mime-inline-part): Don't insert a newline in the beginning of a part like gnus-mime-inline-part doesn't; work for XEmacs. * mm-decode.el (mm-display-part): Don't insert a newline in the top. (mm-shr): Make undisplayer unbreakable. * mm-view.el (mm-inline-image-emacs, mm-inline-image-xemacs): Don't insert excessive newline. (mm-inline-text-html-render-with-w3m, mm-inline-text) (mm-insert-inline): Make undisplayer unbreakable. --- lisp/gnus/mm-decode.el 2014-03-23 23:13:36 +0000 +++ lisp/gnus/mm-decode.el 2014-05-02 09:44:34 +0000 @@ -821,7 +821,6 @@ 'inline) ((and (mm-inlinable-p ehandle) (mm-inlined-p ehandle)) - (forward-line 1) (mm-display-inline handle) 'inline) ((or method From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 31 10:27:17 2014 Received: (at 18413) by debbugs.gnu.org; 31 Oct 2014 14:27:17 +0000 Received: from localhost ([127.0.0.1]:41228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XkDAa-0001jX-S7 for submit@debbugs.gnu.org; Fri, 31 Oct 2014 10:27:17 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:36451) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XkDAX-0001jH-0m for 18413@debbugs.gnu.org; Fri, 31 Oct 2014 10:27:14 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ag4NAOatTlRFpY87/2dsb2JhbABcgw6BLII2hn7LUwQCAoEcFwEBfIQDAQEDAVYoCws0EhQNCw03iCwDCQnFLQ2GOAEBCAIgjk6CQRaENQWbUJFihG6Bb4QUIS+CSwEBAQ X-IPAS-Result: Ag4NAOatTlRFpY87/2dsb2JhbABcgw6BLII2hn7LUwQCAoEcFwEBfIQDAQEDAVYoCws0EhQNCw03iCwDCQnFLQ2GOAEBCAIgjk6CQRaENQWbUJFihG6Bb4QUIS+CSwEBAQ X-IronPort-AV: E=Sophos;i="5.04,797,1406606400"; d="scan'208";a="95666448" Received: from 69-165-143-59.dsl.teksavvy.com (HELO pastel.home) ([69.165.143.59]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 31 Oct 2014 10:27:05 -0400 Received: by pastel.home (Postfix, from userid 20848) id C262A62BA; Fri, 31 Oct 2014 10:26:33 -0400 (EDT) From: Stefan Monnier To: 18413@debbugs.gnu.org Subject: Re: bug#18413: Inline part displayed in the middle of its button Message-ID: References: Date: Fri, 31 Oct 2014 10:26:33 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 05 Sep 2014 14:09:16 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18413 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Ping? Stefan >>>>> "Stefan" == Stefan Monnier writes: > Package: emacs,gnus > Version: 24.4.50 > Here's what I do: > - start Gnus > - visit a message with an Elisp attachment (in my case I tested with > a message from Tom on emacs-devel with subject > "Re: History for query replace pairs" and with an attachment of type > "application/emacs-lisp"). > - place cursor in the middle of the attachment's button (using keyboard > commands). > - press E > Result: the attachment is shown inline, but right in the middle of the > button. IOW I get "[4. applicati" (from the button's text before > point), followed by the attachment's content, followed by > "on/emacs-lisp; hist.el]". The whole is in bold for me, because the > button is an overlay with `bold' face, so the face ends up covering the > inline attachment as well. > It seems to be the result of the hunk below. > Stefan > revno: 117041 > committer: Katsumi Yamaoka > branch nick: trunk > timestamp: Fri 2014-05-02 09:44:34 +0000 > message: > Gnus: Make gnus-mime-inline-part and gnus-mime-inline-part work similarly > * gnus-art.el (gnus-mime-inline-part): Redisplay a button so as to show > the displaying state of a part. > (gnus-mime-inline-part): Don't insert a newline in the beginning of > a part like gnus-mime-inline-part doesn't; work for XEmacs. > * mm-decode.el (mm-display-part): Don't insert a newline in the top. > (mm-shr): Make undisplayer unbreakable. > * mm-view.el (mm-inline-image-emacs, mm-inline-image-xemacs): Don't > insert excessive newline. > (mm-inline-text-html-render-with-w3m, mm-inline-text) > (mm-insert-inline): Make undisplayer unbreakable. > --- lisp/gnus/mm-decode.el 2014-03-23 23:13:36 +0000 > +++ lisp/gnus/mm-decode.el 2014-05-02 09:44:34 +0000 > @@ -821,7 +821,6 @@ > 'inline) > ((and (mm-inlinable-p ehandle) > (mm-inlined-p ehandle)) > - (forward-line 1) > (mm-display-inline handle) > 'inline) > ((or method From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 13 23:31:06 2015 Received: (at 18413) by debbugs.gnu.org; 14 Feb 2015 04:31:06 +0000 Received: from localhost ([127.0.0.1]:42527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMUNm-00031a-7P for submit@debbugs.gnu.org; Fri, 13 Feb 2015 23:31:06 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:50992) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMUNk-0002zw-AU for 18413@debbugs.gnu.org; Fri, 13 Feb 2015 23:31:04 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t1E4V3Mu002144; Fri, 13 Feb 2015 23:31:03 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 18DD9AE0CA; Fri, 13 Feb 2015 23:31:03 -0500 (EST) From: Stefan Monnier To: 18413@debbugs.gnu.org Subject: Re: bug#18413: Inline part displayed in the middle of its button Message-ID: References: Date: Fri, 13 Feb 2015 23:31:03 -0500 In-Reply-To: (Stefan Monnier's message of "Fri, 05 Sep 2014 14:09:16 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5216=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5216> : inlines <2181> : streams <1389910> : uri <1854850> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 18413 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Ping? This is still bugging me. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 00:04:26 2015 Received: (at 18413) by debbugs.gnu.org; 14 Feb 2015 05:04:26 +0000 Received: from localhost ([127.0.0.1]:42548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMUu2-0005Tl-8F for submit@debbugs.gnu.org; Sat, 14 Feb 2015 00:04:26 -0500 Received: from smtp.syd.comcen.com.au ([203.23.236.77]:3396) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMUu0-0005Tc-6i for 18413@debbugs.gnu.org; Sat, 14 Feb 2015 00:04:25 -0500 Received: from building.gnus.org ([27.96.197.126]) by smtp.syd.comcen.com.au (8.13.4/8.12.9) with ESMTP id t1E53HKZ039289; Sat, 14 Feb 2015 16:03:18 +1100 (EST) From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#18413: Inline part displayed in the middle of its button References: Date: Sat, 14 Feb 2015 16:03:12 +1100 In-Reply-To: (Stefan Monnier's message of "Fri, 05 Sep 2014 14:09:16 -0400") Message-ID: <87oaoxgk4v.fsf@building.gnus.org> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-comcen-MailScanner-Information: Please contact the ISP for more information X-comcen-MailScanner: Found to be clean X-comcen-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=0.196, required 4, AWL -0.06, BAYES_50 0.00, RDNS_NONE 0.10, SUBJECT_FUZZY_TION 0.16) X-comcen-MailScanner-From: larsi@gnus.org X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18413 Cc: 18413@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: > --- lisp/gnus/mm-decode.el 2014-03-23 23:13:36 +0000 > +++ lisp/gnus/mm-decode.el 2014-05-02 09:44:34 +0000 > @@ -821,7 +821,6 @@ > 'inline) > ((and (mm-inlinable-p ehandle) > (mm-inlined-p ehandle)) > - (forward-line 1) > (mm-display-inline handle) > 'inline) > ((or method I think the bug here is that this function is called during article rendering as well as by the `E' command without any way of differentiating. I've now made `E' pass a `force' parameter to this function, so that `E' can move point to the right place before inserting inline. (In git Gnus, soon to be in the Emacs trunk.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 14 00:04:06 2015 Received: (at control) by debbugs.gnu.org; 14 Feb 2015 05:04:06 +0000 Received: from localhost ([127.0.0.1]:42545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMUth-0005TC-G8 for submit@debbugs.gnu.org; Sat, 14 Feb 2015 00:04:06 -0500 Received: from smtp.syd.comcen.com.au ([203.23.236.77]:4073) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMUte-0005Sp-6C for control@debbugs.gnu.org; Sat, 14 Feb 2015 00:04:03 -0500 Received: from building.gnus.org ([27.96.197.126]) by smtp.syd.comcen.com.au (8.13.4/8.12.9) with ESMTP id t1E53Uib039330 for ; Sat, 14 Feb 2015 16:03:30 +1100 (EST) Date: Sat, 14 Feb 2015 16:03:24 +1100 Message-Id: <87mw4hgk4j.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #18413 X-comcen-MailScanner-Information: Please contact the ISP for more information X-comcen-MailScanner: Found to be clean X-comcen-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=0.119, required 4, AWL 0.02, BAYES_50 0.00, RDNS_NONE 0.10) X-comcen-MailScanner-From: larsi@gnus.org X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 18413 fixed close 18413 25.1 From unknown Fri Jun 20 07:18:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 14 Mar 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator