GNU bug report logs - #18413
Inline part displayed in the middle of its button

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18413 in the body.
You can then email your comments to 18413 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: bug-gnu-emacs <at> gnu.org
Subject: Inline part displayed in the middle of its button
Date: Fri, 05 Sep 2014 14:09:16 -0400

Package: emacs,gnus
Version: 24.4.50


Here's what I do:
- start Gnus
- visit a message with an Elisp attachment (in my case I tested with
  a message from Tom <adatgyujto <at> gmail.com> on emacs-devel with subject
  "Re: History for query replace pairs" and with an attachment of type
  "application/emacs-lisp").
- place cursor in the middle of the attachment's button (using keyboard
commands).
- press E

Result: the attachment is shown inline, but right in the middle of the
button.  IOW I get "[4. applicati" (from the button's text before
point), followed by the attachment's content, followed by
"on/emacs-lisp; hist.el]".  The whole is in bold for me, because the
button is an overlay with `bold' face, so the face ends up covering the
inline attachment as well.

It seems to be the result of the hunk below.


        Stefan


revno: 117041
committer: Katsumi Yamaoka <yamaoka <at> jpl.org>
branch nick: trunk
timestamp: Fri 2014-05-02 09:44:34 +0000
message:
  Gnus: Make gnus-mime-inline-part and gnus-mime-inline-part work similarly
  
  * gnus-art.el (gnus-mime-inline-part): Redisplay a button so as to show
  the displaying state of a part.
  (gnus-mime-inline-part): Don't insert a newline in the beginning of
  a part like gnus-mime-inline-part doesn't; work for XEmacs.
  
  * mm-decode.el (mm-display-part): Don't insert a newline in the top.
  (mm-shr): Make undisplayer unbreakable.
  
  * mm-view.el (mm-inline-image-emacs, mm-inline-image-xemacs): Don't
  insert excessive newline.
  (mm-inline-text-html-render-with-w3m, mm-inline-text)
  (mm-insert-inline): Make undisplayer unbreakable.


--- lisp/gnus/mm-decode.el	2014-03-23 23:13:36 +0000
+++ lisp/gnus/mm-decode.el	2014-05-02 09:44:34 +0000
@@ -821,7 +821,6 @@
 	  'inline)
 	 ((and (mm-inlinable-p ehandle)
 	       (mm-inlined-p ehandle))
-	  (forward-line 1)
 	  (mm-display-inline handle)
 	  'inline)
 	 ((or method

Message #8 received at 18413 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 18413 <at> debbugs.gnu.org
Subject: Re: bug#18413: Inline part displayed in the middle of its button
Date: Fri, 31 Oct 2014 10:26:33 -0400

Ping?


        Stefan


>>>>> "Stefan" == Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> Package: emacs,gnus
> Version: 24.4.50


> Here's what I do:
> - start Gnus
> - visit a message with an Elisp attachment (in my case I tested with
>   a message from Tom <adatgyujto <at> gmail.com> on emacs-devel with subject
>   "Re: History for query replace pairs" and with an attachment of type
>   "application/emacs-lisp").
> - place cursor in the middle of the attachment's button (using keyboard
> commands).
> - press E

> Result: the attachment is shown inline, but right in the middle of the
> button.  IOW I get "[4. applicati" (from the button's text before
> point), followed by the attachment's content, followed by
> "on/emacs-lisp; hist.el]".  The whole is in bold for me, because the
> button is an overlay with `bold' face, so the face ends up covering the
> inline attachment as well.

> It seems to be the result of the hunk below.


>         Stefan


> revno: 117041
> committer: Katsumi Yamaoka <yamaoka <at> jpl.org>
> branch nick: trunk
> timestamp: Fri 2014-05-02 09:44:34 +0000
> message:
>   Gnus: Make gnus-mime-inline-part and gnus-mime-inline-part work similarly
  
>   * gnus-art.el (gnus-mime-inline-part): Redisplay a button so as to show
>   the displaying state of a part.
>   (gnus-mime-inline-part): Don't insert a newline in the beginning of
>   a part like gnus-mime-inline-part doesn't; work for XEmacs.
  
>   * mm-decode.el (mm-display-part): Don't insert a newline in the top.
>   (mm-shr): Make undisplayer unbreakable.
  
>   * mm-view.el (mm-inline-image-emacs, mm-inline-image-xemacs): Don't
>   insert excessive newline.
>   (mm-inline-text-html-render-with-w3m, mm-inline-text)
>   (mm-insert-inline): Make undisplayer unbreakable.


> --- lisp/gnus/mm-decode.el	2014-03-23 23:13:36 +0000
> +++ lisp/gnus/mm-decode.el	2014-05-02 09:44:34 +0000
> @@ -821,7 +821,6 @@
>  	  'inline)
>  	 ((and (mm-inlinable-p ehandle)
>  	       (mm-inlined-p ehandle))
> -	  (forward-line 1)
>  	  (mm-display-inline handle)
>  	  'inline)
>  	 ((or method

Message #11 received at 18413 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: 18413 <at> debbugs.gnu.org
Subject: Re: bug#18413: Inline part displayed in the middle of its button
Date: Fri, 13 Feb 2015 23:31:03 -0500

Ping?
This is still bugging me.


        Stefan

Message #14 received at 18413 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 18413 <at> debbugs.gnu.org
Subject: Re: bug#18413: Inline part displayed in the middle of its button
Date: Sat, 14 Feb 2015 16:03:12 +1100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> --- lisp/gnus/mm-decode.el	2014-03-23 23:13:36 +0000
> +++ lisp/gnus/mm-decode.el	2014-05-02 09:44:34 +0000
> @@ -821,7 +821,6 @@
>  	  'inline)
>  	 ((and (mm-inlinable-p ehandle)
>  	       (mm-inlined-p ehandle))
> -	  (forward-line 1)
>  	  (mm-display-inline handle)
>  	  'inline)
>  	 ((or method

I think the bug here is that this function is called during article
rendering as well as by the `E' command without any way of
differentiating.  I've now made `E' pass a `force' parameter to this
function, so that `E' can move point to the right place before inserting
inline.  (In git Gnus, soon to be in the Emacs trunk.)

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.