From unknown Sat Aug 16 16:11:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18409: 24.3; call-process-shell-command doc Resent-From: Devon Sean McCullough Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Sep 2014 22:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18409 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18409@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140987140526056 (code B ref -1); Thu, 04 Sep 2014 22:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Sep 2014 22:56:45 +0000 Received: from localhost ([127.0.0.1]:59136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPfxM-0006mC-Ew for submit@debbugs.gnu.org; Thu, 04 Sep 2014 18:56:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52648) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPfvX-0006iz-WB for submit@debbugs.gnu.org; Thu, 04 Sep 2014 18:54:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPfvI-0002kV-MG for submit@debbugs.gnu.org; Thu, 04 Sep 2014 18:54:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.1 required=5.0 tests=BAYES_50, RCVD_IN_BL_SPAMCOP_NET autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPfvI-0002kR-JC for submit@debbugs.gnu.org; Thu, 04 Sep 2014 18:54:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPfvA-0006Kg-8C for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2014 18:54:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPfv2-0002ih-1a for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2014 18:54:28 -0400 Received: from gateway07.websitewelcome.com ([69.56.170.18]:37936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPfv1-0002iX-SY for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2014 18:54:19 -0400 Received: by gateway07.websitewelcome.com (Postfix, from userid 5007) id 5886A826A430E; Thu, 4 Sep 2014 17:54:17 -0500 (CDT) Received: from leaf.websitewelcome.com (leaf.websitewelcome.com [192.185.82.99]) by gateway07.websitewelcome.com (Postfix) with ESMTP id 52F98826A42F0 for ; Thu, 4 Sep 2014 17:54:17 -0500 (CDT) Received: from [66.30.202.22] (port=50691 helo=[10.0.0.7]) by leaf.websitewelcome.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.82) (envelope-from ) id 1XPfuz-0005eB-0s for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2014 17:54:17 -0500 From: Devon Sean McCullough Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <65311DC8-1CA5-4E16-B2C7-7E261C36615E@jovi.net> Date: Thu, 4 Sep 2014 18:54:15 -0400 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) X-Mailer: Apple Mail (2.1878.6) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - leaf.websitewelcome.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jovi.net X-BWhitelist: no X-Source-IP: 66.30.202.22 X-Exim-ID: 1XPfuz-0005eB-0s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([10.0.0.7]) [66.30.202.22]:50691 X-Source-Auth: devon@jovi.net X-Email-Count: 1 X-Source-Cap: am92aW5ldDtkZXZvbjtsZWFmLndlYnNpdGV3ZWxjb21lLmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.1 (---) X-Mailman-Approved-At: Thu, 04 Sep 2014 18:56:42 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.1 (---) Make the rest args easier to spot in the documentation --- lisp/subr.el.~1~ 2014-09-04 11:46:00.000000000 -0400 +++ lisp/subr.el 2014-09-04 11:48:31.000000000 -0400 @@ -3027,7 +3027,7 @@ t (mix it with ordinary output), or a file name string. Fourth arg DISPLAY non-nil means redisplay buffer as output is inserted. -Remaining arguments are strings passed as additional arguments for = COMMAND. +Remaining ARGS are strings passed as additional arguments for COMMAND. Wildcards and redirection are handled as usual in the shell. If BUFFER is 0, `call-process-shell-command' returns immediately with = value nil. From unknown Sat Aug 16 16:11:14 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Devon Sean McCullough Subject: bug#18409: closed (Re: bug#18409: 24.3; call-process-shell-command doc) Message-ID: References: <65311DC8-1CA5-4E16-B2C7-7E261C36615E@jovi.net> X-Gnu-PR-Message: they-closed 18409 X-Gnu-PR-Package: emacs Reply-To: 18409@debbugs.gnu.org Date: Fri, 05 Sep 2014 01:23:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1409880183-7537-1" This is a multi-part message in MIME format... ------------=_1409880183-7537-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18409: 24.3; call-process-shell-command doc which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18409@debbugs.gnu.org. --=20 18409: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18409 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1409880183-7537-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18409-done) by debbugs.gnu.org; 5 Sep 2014 01:22:54 +0000 Received: from localhost ([127.0.0.1]:59178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPiEn-0001x6-MG for submit@debbugs.gnu.org; Thu, 04 Sep 2014 21:22:54 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:49760) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPiEk-0001wv-ON for 18409-done@debbugs.gnu.org; Thu, 04 Sep 2014 21:22:51 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s851MnUJ017418; Thu, 4 Sep 2014 21:22:49 -0400 Received: by pastel.home (Postfix, from userid 20848) id 43FD160BEC; Thu, 4 Sep 2014 21:22:49 -0400 (EDT) From: Stefan Monnier To: Devon Sean McCullough Subject: Re: bug#18409: 24.3; call-process-shell-command doc Message-ID: References: <65311DC8-1CA5-4E16-B2C7-7E261C36615E@jovi.net> Date: Thu, 04 Sep 2014 21:22:49 -0400 In-Reply-To: <65311DC8-1CA5-4E16-B2C7-7E261C36615E@jovi.net> (Devon Sean McCullough's message of "Thu, 4 Sep 2014 18:54:15 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5054=0 X-NAI-Spam-Version: 2.3.0.9378 : core <5054> : inlines <1245> : streams <1281642> : uri <1810413> X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 18409-done Cc: 18409-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > Make the rest args easier to spot in the documentation On the contrary, this `args' is just asking for trouble. Don't use it. We obsoleted it for start-process-shell-command in Emacs-23 and forgot to do it for the call-process variant, which I just fixed with the patch below. Thanks for bringing it up. Stefan === modified file 'etc/NEWS' --- etc/NEWS 2014-09-03 16:13:17 +0000 +++ etc/NEWS 2014-09-05 01:17:23 +0000 @@ -200,6 +200,9 @@ * Lisp Changes in Emacs 24.5 +*** call-process-shell-command and process-file-shell-command +don't take "&rest args" an more. + ** New function `funcall-interactively', which works like `funcall' but makes `called-interactively-p' treat the function as (you guessed it) called interactively. === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2014-09-05 01:04:47 +0000 +++ lisp/ChangeLog 2014-09-05 01:19:21 +0000 @@ -1,3 +1,10 @@ +2014-09-05 Stefan Monnier + + * subr.el (call-process-shell-command, process-file-shell-command): + Make the `args' obsolete (bug#18409). + (start-process-shell-command, start-file-process-shell-command): + Use `declare'. + 2014-09-05 Jay Belanger * calc/calc-forms.el (math-normalize-hms): Do a better check for === modified file 'lisp/subr.el' --- lisp/subr.el 2014-09-03 04:21:40 +0000 +++ lisp/subr.el 2014-09-05 01:12:43 +0000 @@ -2877,23 +2877,21 @@ An old calling convention accepted any number of arguments after COMMAND, which were just concatenated to COMMAND. This is still supported but strongly discouraged." + (declare (advertised-calling-convention (name buffer command) "23.1")) ;; We used to use `exec' to replace the shell with the command, ;; but that failed to handle (...) and semicolon, etc. (start-process name buffer shell-file-name shell-command-switch (mapconcat 'identity args " "))) -(set-advertised-calling-convention 'start-process-shell-command - '(name buffer command) "23.1") (defun start-file-process-shell-command (name buffer &rest args) "Start a program in a subprocess. Return the process object for it. Similar to `start-process-shell-command', but calls `start-file-process'." + (declare (advertised-calling-convention (name buffer command) "23.1")) (start-file-process name buffer (if (file-remote-p default-directory) "/bin/sh" shell-file-name) (if (file-remote-p default-directory) "-c" shell-command-switch) (mapconcat 'identity args " "))) -(set-advertised-calling-convention 'start-file-process-shell-command - '(name buffer command) "23.1") (defun call-process-shell-command (command &optional infile buffer display &rest args) @@ -2909,13 +2907,18 @@ t (mix it with ordinary output), or a file name string. Fourth arg DISPLAY non-nil means redisplay buffer as output is inserted. -Remaining arguments are strings passed as additional arguments for COMMAND. Wildcards and redirection are handled as usual in the shell. If BUFFER is 0, `call-process-shell-command' returns immediately with value nil. Otherwise it waits for COMMAND to terminate and returns a numeric exit status or a signal description string. -If you quit, the process is killed with SIGINT, or SIGKILL if you quit again." +If you quit, the process is killed with SIGINT, or SIGKILL if you quit again. + +An old calling convention accepted any number of arguments after DISPLAY, +which were just concatenated to COMMAND. This is still supported but strongly +discouraged." + (declare (advertised-calling-convention + (command &optional infile buffer display) "24.5")) ;; We used to use `exec' to replace the shell with the command, ;; but that failed to handle (...) and semicolon, etc. (call-process shell-file-name @@ -2927,6 +2930,8 @@ &rest args) "Process files synchronously in a separate process. Similar to `call-process-shell-command', but calls `process-file'." + (declare (advertised-calling-convention + (command &optional infile buffer display) "24.5")) (process-file (if (file-remote-p default-directory) "/bin/sh" shell-file-name) infile buffer display ------------=_1409880183-7537-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Sep 2014 22:56:45 +0000 Received: from localhost ([127.0.0.1]:59136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPfxM-0006mC-Ew for submit@debbugs.gnu.org; Thu, 04 Sep 2014 18:56:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52648) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XPfvX-0006iz-WB for submit@debbugs.gnu.org; Thu, 04 Sep 2014 18:54:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPfvI-0002kV-MG for submit@debbugs.gnu.org; Thu, 04 Sep 2014 18:54:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.1 required=5.0 tests=BAYES_50, RCVD_IN_BL_SPAMCOP_NET autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPfvI-0002kR-JC for submit@debbugs.gnu.org; Thu, 04 Sep 2014 18:54:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPfvA-0006Kg-8C for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2014 18:54:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPfv2-0002ih-1a for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2014 18:54:28 -0400 Received: from gateway07.websitewelcome.com ([69.56.170.18]:37936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPfv1-0002iX-SY for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2014 18:54:19 -0400 Received: by gateway07.websitewelcome.com (Postfix, from userid 5007) id 5886A826A430E; Thu, 4 Sep 2014 17:54:17 -0500 (CDT) Received: from leaf.websitewelcome.com (leaf.websitewelcome.com [192.185.82.99]) by gateway07.websitewelcome.com (Postfix) with ESMTP id 52F98826A42F0 for ; Thu, 4 Sep 2014 17:54:17 -0500 (CDT) Received: from [66.30.202.22] (port=50691 helo=[10.0.0.7]) by leaf.websitewelcome.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.82) (envelope-from ) id 1XPfuz-0005eB-0s for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2014 17:54:17 -0500 From: Devon Sean McCullough Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: 24.3; call-process-shell-command doc Message-Id: <65311DC8-1CA5-4E16-B2C7-7E261C36615E@jovi.net> Date: Thu, 4 Sep 2014 18:54:15 -0400 To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) X-Mailer: Apple Mail (2.1878.6) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - leaf.websitewelcome.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jovi.net X-BWhitelist: no X-Source-IP: 66.30.202.22 X-Exim-ID: 1XPfuz-0005eB-0s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([10.0.0.7]) [66.30.202.22]:50691 X-Source-Auth: devon@jovi.net X-Email-Count: 1 X-Source-Cap: am92aW5ldDtkZXZvbjtsZWFmLndlYnNpdGV3ZWxjb21lLmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 04 Sep 2014 18:56:42 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.1 (---) Make the rest args easier to spot in the documentation --- lisp/subr.el.~1~ 2014-09-04 11:46:00.000000000 -0400 +++ lisp/subr.el 2014-09-04 11:48:31.000000000 -0400 @@ -3027,7 +3027,7 @@ t (mix it with ordinary output), or a file name string. Fourth arg DISPLAY non-nil means redisplay buffer as output is inserted. -Remaining arguments are strings passed as additional arguments for = COMMAND. +Remaining ARGS are strings passed as additional arguments for COMMAND. Wildcards and redirection are handled as usual in the shell. If BUFFER is 0, `call-process-shell-command' returns immediately with = value nil. ------------=_1409880183-7537-1--