GNU bug report logs - #18399
24.4.50; nadvice :filter-args -vs- interactive

Previous Next

Full log

Message #14 received at 18399 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Tom Tromey <tom <at> tromey.com>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 18399 <at> debbugs.gnu.org
Subject: Re: bug#18399: 24.4.50; nadvice :filter-args -vs- interactive
Date: Wed, 03 Sep 2014 22:59:14 -0400

Michael> According to the doc (of `add-function'), an filter-args advice
Michael> function has to accept exactly one argument (which is bound to
Michael> the list of given arguments).  So I think what you see is
Michael> expected.
Michael> I have stumbled over that behavior several times myself.
> I looked at the docs again and I agree.  Sorry about the noise.  Perhaps
> a note and/or a small example here would be nice for future users.  If
> we were both fooled by this then perhaps others will be as well.

FWIW, the use of a single formal arg receiving the actual arg-list
in :filter-args is based on performance reasons (we have the list
anyway, so it's more efficient to pass it to `funcall' than to `apply').


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.