GNU bug report logs - #18388
24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Drew Adams <drew.adams <at> oracle.com>
Subject: bug#18388: closed (Re: bug#18388: 24.4.50; REGRESSION:
 incompatible change to `replace-match-maybe-edit' (and no doc))
Date: Wed, 10 Feb 2016 00:48:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#18388: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc)

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 18388 <at> debbugs.gnu.org.

-- 
18388: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18388
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 18388-done <at> debbugs.gnu.org
Subject: Re: bug#18388: 24.4.50;
 REGRESSION: incompatible change to `replace-match-maybe-edit' (and no
 doc)
Date: Wed, 10 Feb 2016 02:47:06 +0200

>> >> You added argument BACKWARD to this function, and you did not add it as
>> >> an &optional parameter.  This breaks all existing code that uses the
>> >> function.  The parameter should be &optional.
>> >>
>> >> What's more, you did not even mention the new arg in the doc string.
>> >
>> > ping
>>
>> I wonder what code and how might use this internal function?
>
> Does it matter?  Could you please make the parameter optional
> (and document it)?

Thanks for your patience.  Now fixed.

[Message part 3 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; REGRESSION: incompatible change to
 `replace-match-maybe-edit' (and no doc)
Date: Tue, 2 Sep 2014 06:28:45 -0700 (PDT)

You added argument BACKWARD to this function, and you did not add it as
an &optional parameter.  This breaks all existing code that uses the
function.  The parameter should be &optional.

What's more, you did not even mention the new arg in the doc string.


In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-08-15 on LEG570
Bzr revision: 117706 rgm <at> gnu.org-20140815043406-p5hbu97cbm7pulcn
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.