Subject: bug#18388: closed (Re: bug#18388: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc))

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 10 Feb 2016 00:48:02 +0000

Your bug report

#18388: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc)

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
18388: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18388
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#18388: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc)
From: Juri Linkov <[email-masked]>
To: Drew Adams <[email-masked]>
Cc: [email-masked]
Date: Wed, 10 Feb 2016 02:47:06 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

>> >> You added argument BACKWARD to this function, and you did not add it as
>> >> an &optional parameter.  This breaks all existing code that uses the
>> >> function.  The parameter should be &optional.
>> >>
>> >> What's more, you did not even mention the new arg in the doc string.
>> >
>> > ping
>>
>> I wonder what code and how might use this internal function?
>
> Does it matter?  Could you please make the parameter optional
> (and document it)?

Thanks for your patience.  Now fixed.

Subject: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc)
From: Drew Adams <[email-masked]>
To: [email-masked]
Date: Tue, 2 Sep 2014 06:28:45 -0700 (PDT)
List-Id: <debbugs-submit.debbugs.gnu.org>

You added argument BACKWARD to this function, and you did not add it as
an &optional parameter.  This breaks all existing code that uses the
function.  The parameter should be &optional.

What's more, you did not even mention the new arg in the doc string.

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-08-15 on LEG570
Bzr revision: 117706 [email-masked]
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'