From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 02 09:29:27 2014 Received: (at submit) by debbugs.gnu.org; 2 Sep 2014 13:29:27 +0000 Received: from localhost ([127.0.0.1]:56441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XOo9G-0007gK-Sx for submit@debbugs.gnu.org; Tue, 02 Sep 2014 09:29:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58564) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XOo9C-0007g0-DC for submit@debbugs.gnu.org; Tue, 02 Sep 2014 09:29:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOo8w-0005HJ-UR for submit@debbugs.gnu.org; Tue, 02 Sep 2014 09:29:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOo8w-0005HC-RE for submit@debbugs.gnu.org; Tue, 02 Sep 2014 09:29:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOo8o-0007Kh-0I for bug-gnu-emacs@gnu.org; Tue, 02 Sep 2014 09:29:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOo8e-0005AT-HT for bug-gnu-emacs@gnu.org; Tue, 02 Sep 2014 09:28:57 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:48974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOo8e-00059H-91 for bug-gnu-emacs@gnu.org; Tue, 02 Sep 2014 09:28:48 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s82DSl1R016249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 2 Sep 2014 13:28:47 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s82DSkf7026195 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 2 Sep 2014 13:28:46 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s82DSjEx007774 for ; Tue, 2 Sep 2014 13:28:45 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 2 Sep 2014 06:28:45 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc) X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) You added argument BACKWARD to this function, and you did not add it as an &optional parameter. This breaks all existing code that uses the function. The parameter should be &optional. What's more, you did not even mention the new arg in the doc string. In GNU Emacs 24.4.50.1 (i686-pc-mingw32) of 2014-08-15 on LEG570 Bzr revision: 117706 rgm@gnu.org-20140815043406-p5hbu97cbm7pulcn Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking 'CFLAGS=3D-O0 -g3' CPPFLAGS=3D-DGLYPH_DEBUG= =3D1' From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 05 12:16:52 2016 Received: (at 18388) by debbugs.gnu.org; 5 Feb 2016 17:16:52 +0000 Received: from localhost ([127.0.0.1]:34616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRk04-0002Lt-G2 for submit@debbugs.gnu.org; Fri, 05 Feb 2016 12:16:52 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:19205) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRk03-0002Le-2q for 18388@debbugs.gnu.org; Fri, 05 Feb 2016 12:16:51 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u15HGiUN032746 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <18388@debbugs.gnu.org>; Fri, 5 Feb 2016 17:16:45 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u15HGiaS003880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for <18388@debbugs.gnu.org>; Fri, 5 Feb 2016 17:16:44 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u15HGipZ010361 for <18388@debbugs.gnu.org>; Fri, 5 Feb 2016 17:16:44 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 5 Feb 2016 09:16:43 -0800 (PST) From: Drew Adams To: 18388@debbugs.gnu.org Subject: RE: bug#18388: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc) References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 18388 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) > You added argument BACKWARD to this function, and you did not add it as > an &optional parameter. This breaks all existing code that uses the > function. The parameter should be &optional. >=20 > What's more, you did not even mention the new arg in the doc string. ping From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 05 20:13:39 2016 Received: (at 18388) by debbugs.gnu.org; 6 Feb 2016 01:13:39 +0000 Received: from localhost ([127.0.0.1]:34951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRrRT-0004z3-Is for submit@debbugs.gnu.org; Fri, 05 Feb 2016 20:13:39 -0500 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:47463 helo=homiemail-a18.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRrRR-0004yn-Gm for 18388@debbugs.gnu.org; Fri, 05 Feb 2016 20:13:37 -0500 Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id 1C9E425006B; Fri, 5 Feb 2016 17:13:37 -0800 (PST) Received: from localhost.linkov.net (62.65.227.106.cable.starman.ee [62.65.227.106]) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPA id 3238A250069; Fri, 5 Feb 2016 17:13:35 -0800 (PST) From: Juri Linkov To: Drew Adams Subject: Re: bug#18388: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc) Organization: LINKOV.NET References: Date: Sat, 06 Feb 2016 02:34:28 +0200 In-Reply-To: (Drew Adams's message of "Fri, 5 Feb 2016 09:16:43 -0800 (PST)") Message-ID: <871t8qps15.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18388 Cc: 18388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> You added argument BACKWARD to this function, and you did not add it as >> an &optional parameter. This breaks all existing code that uses the >> function. The parameter should be &optional. >> >> What's more, you did not even mention the new arg in the doc string. > > ping I wonder what code and how might use this internal function? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 05 20:40:49 2016 Received: (at 18388) by debbugs.gnu.org; 6 Feb 2016 01:40:49 +0000 Received: from localhost ([127.0.0.1]:34956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRrrk-0005fz-S4 for submit@debbugs.gnu.org; Fri, 05 Feb 2016 20:40:49 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:47344) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRrri-0005fk-W2 for 18388@debbugs.gnu.org; Fri, 05 Feb 2016 20:40:47 -0500 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u161ee0o016180 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 6 Feb 2016 01:40:40 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u161edDn022974 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 6 Feb 2016 01:40:40 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u161ed4m008266; Sat, 6 Feb 2016 01:40:39 GMT MIME-Version: 1.0 Message-ID: <0d78b1ce-867e-4f1e-bcba-4dc765cf0749@default> Date: Fri, 5 Feb 2016 17:40:37 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#18388: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc) References: <871t8qps15.fsf@mail.linkov.net> In-Reply-To: <871t8qps15.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 18388 Cc: 18388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) > >> You added argument BACKWARD to this function, and you did not add it a= s > >> an &optional parameter. This breaks all existing code that uses the > >> function. The parameter should be &optional. > >> > >> What's more, you did not even mention the new arg in the doc string. > > > > ping >=20 > I wonder what code and how might use this internal function? Does it matter? Could you please make the parameter optional (and document it)? This code uses it: http://www.emacswiki.org/emacs/download/icicles-cmd2.el See the definition of `icicle-search-replace-match'. Here is that definition, if you don't want to look at it in context: (defun icicle-search-replace-match (replacement fixedcase) "Replace current match with REPLACEMENT, interpreting escapes. If REPLACEMENT is a function then call that function on the match string and use the result as the replacement. Otherwise, REPLACEMENT is a string, and it is treated as it would be treated by `query-replace-regexp'. FIXEDCASE is as for `replace-match'. Non-nil means do not alter case." (if (functionp replacement) (condition-case icicle-search-replace-match0 (replace-match (funcall replacement (match-string 0)) fixedcase i= cicle-search-replace-literally-flag) (error (replace-match (funcall replacement (match-string 0)) fixedc= ase t))) (if (fboundp 'query-replace-compile-replacement) ; Emacs 22+. (let ((compiled (save-match-data (query-replace-compile-replacement replacement (not icicle-search-repl= ace-literally-flag))))) (condition-case icicle-search-replace-match1 (let ((enable-recursive-minibuffers t) ; So we can read in= put from \?. ;; Save and restore these, because we might read input = from \?. (icicle-last-completion-command icicle-last-completion= -command) (icicle-last-input icicle-last-input)) (replace-match-maybe-edit (if (consp compiled) ;; `replace-count' is free here, bound in `icicle-sear= ch'. (funcall (car compiled) (cdr compiled) (setq replace-c= ount (1+ replace-count))) compiled) fixedcase icicle-search-replace-literally-flag nil (match-= data) nil)) ; BACKWARD parameter for Emacs 24.4= + - see bug #18388 ;; @@@@@@ Hopefully this is only a temporary hack, until Emacs = bug #18388 is fixed. (wrong-number-of-arguments (condition-case icicle-search-replace-match3 (replace-match-maybe-edit (if (consp compiled) ;; `replace-count' is free here, bound in `icicle-sea= rch'. (funcall (car compiled) (cdr compiled) (setq replace-= count (1+ replace-count))) compiled) fixedcase icicle-search-replace-literally-flag nil (match= -data)) (buffer-read-only (ding) (icicle-user-error "Buffer is read-= only")) (error (icicle-remove-Completions-window) (icicle-user-error= "No match for `%s'" replacement)))) (buffer-read-only (ding) (icicle-user-error "Buffer is read-onl= y")) (error (icicle-remove-Completions-window) (icicle-user-error "N= o match for `%s'" replacement)))) (condition-case icicle-search-replace-match2 ; Emacs < 22. Try to in= terpret `\'. (replace-match replacement fixedcase icicle-search-replace-litera= lly-flag) (error (replace-match replacement fixedcase t)))))) From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 09 19:47:42 2016 Received: (at 18388-done) by debbugs.gnu.org; 10 Feb 2016 00:47:42 +0000 Received: from localhost ([127.0.0.1]:34042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTIwY-0005aM-1C for submit@debbugs.gnu.org; Tue, 09 Feb 2016 19:47:42 -0500 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:52896 helo=homiemail-a17.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTIwV-0005aD-M3 for 18388-done@debbugs.gnu.org; Tue, 09 Feb 2016 19:47:39 -0500 Received: from homiemail-a17.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a17.g.dreamhost.com (Postfix) with ESMTP id BEF762B206D; Tue, 9 Feb 2016 16:47:36 -0800 (PST) Received: from localhost.linkov.net (85.253.171.40.cable.starman.ee [85.253.171.40]) (Authenticated sender: jurta@jurta.org) by homiemail-a17.g.dreamhost.com (Postfix) with ESMTPA id EB4AE2B206A; Tue, 9 Feb 2016 16:47:35 -0800 (PST) From: Juri Linkov To: Drew Adams Subject: Re: bug#18388: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc) Organization: LINKOV.NET References: <871t8qps15.fsf@mail.linkov.net> <0d78b1ce-867e-4f1e-bcba-4dc765cf0749@default> Date: Wed, 10 Feb 2016 02:47:06 +0200 In-Reply-To: <0d78b1ce-867e-4f1e-bcba-4dc765cf0749@default> (Drew Adams's message of "Fri, 5 Feb 2016 17:40:37 -0800 (PST)") Message-ID: <87y4at8k8l.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18388-done Cc: 18388-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> >> You added argument BACKWARD to this function, and you did not add it as >> >> an &optional parameter. This breaks all existing code that uses the >> >> function. The parameter should be &optional. >> >> >> >> What's more, you did not even mention the new arg in the doc string. >> > >> > ping >> >> I wonder what code and how might use this internal function? > > Does it matter? Could you please make the parameter optional > (and document it)? Thanks for your patience. Now fixed. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 09 21:03:59 2016 Received: (at 18388-done) by debbugs.gnu.org; 10 Feb 2016 02:03:59 +0000 Received: from localhost ([127.0.0.1]:34079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTK8M-0007KT-LO for submit@debbugs.gnu.org; Tue, 09 Feb 2016 21:03:58 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:42529) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTK8L-0007KH-EY for 18388-done@debbugs.gnu.org; Tue, 09 Feb 2016 21:03:57 -0500 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u1A23oqi022591 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Feb 2016 02:03:51 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u1A23ma4000912 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 10 Feb 2016 02:03:49 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u1A23mu3005758; Wed, 10 Feb 2016 02:03:48 GMT MIME-Version: 1.0 Message-ID: <648d1792-4830-42ef-8f09-0880e620c285@default> Date: Tue, 9 Feb 2016 18:03:47 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#18388: 24.4.50; REGRESSION: incompatible change to `replace-match-maybe-edit' (and no doc) References: <871t8qps15.fsf@mail.linkov.net> <0d78b1ce-867e-4f1e-bcba-4dc765cf0749@default> <87y4at8k8l.fsf@mail.linkov.net> In-Reply-To: <87y4at8k8l.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 18388-done Cc: 18388-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) > >> >> You added argument BACKWARD to this function, and you did not add i= t as > >> >> an &optional parameter. This breaks all existing code that uses th= e > >> >> function. The parameter should be &optional. > >> >> > >> >> What's more, you did not even mention the new arg in the doc string= . > >> > > >> > ping > >> > >> I wonder what code and how might use this internal function? > > > > Does it matter? Could you please make the parameter optional > > (and document it)? >=20 > Thanks for your patience. Now fixed. Thank you. From unknown Tue Sep 09 06:10:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 09 Mar 2016 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator