GNU bug report logs - #18373
desktop-create-buffer: may call bury-buffer on a just killed buffer (?)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18373: closed (desktop-create-buffer: may call bury-buffer on
 a just killed buffer (?) )
Date: Wed, 10 Sep 2014 00:49:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 09 Sep 2014 20:48:36 -0400
with message-id <jwvr3zkgv2v.fsf-monnier+emacsbugs <at> gnu.org>
and subject line Re: bug#18373: desktop-create-buffer: may call bury-buffer on a just killed buffer (?)
has caused the debbugs.gnu.org bug report #18373,
regarding desktop-create-buffer: may call bury-buffer on a just killed buffer (?) 
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18373: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18373
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: desktop-create-buffer: may call bury-buffer on a just killed buffer
 (?) 
Date: Sun, 31 Aug 2014 21:31:41 +0000

[Message part 3 (text/plain, inline)]

Package:  emacs
Severity: minor
Tags: patch

	Currently, desktop-create-buffer calls bury-buffer on every
	buffer listed in a saved version of (buffer-list) so to restore
	the order of buffers:

  1375 	;; Restore buffer list order with new buffer at end. Don't change
  1376 	;; the order for old desktop files (old desktop module behavior).
  1377 	(unless (< desktop-file-version 206)
  1378 	  (mapc 'bury-buffer buffer-list)
  1379 	  (when result (bury-buffer result)))

	This, however, fails – should one or more of these buffers be
	killed after the list is saved but before it’s processed, – as
	happens with some (presumably temporary) buffers used by
	url-retrieve, which is in turn used while restoring EWW buffers
	per [1].  (Please note that the patch there is broken, though.)

	The patch MIMEd seems to fix the issue for me, although I’m not
	as of yet certain that no buffer can be killed in between the
	buffer-live-p check and the bury-buffer call.

[1] http://debbugs.gnu.org/18010

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[Message part 4 (text/diff, inline)]

--- a/lisp/desktop.el
+++ b/lisp/desktop.el
@@ -1375,7 +1375,10 @@ after that many seconds of idle time."
 	;; Restore buffer list order with new buffer at end. Don't change
 	;; the order for old desktop files (old desktop module behavior).
 	(unless (< desktop-file-version 206)
-	  (mapc 'bury-buffer buffer-list)
+	  (mapc (lambda (buf)
+		  (and (buffer-live-p buf)
+		       (bury-buffer buf)))
+		buffer-list)
 	  (when result (bury-buffer result)))
 	(when result
 	  (unless (or desktop-first-buffer (< desktop-file-version 206))

[Message part 5 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 18373-done <at> debbugs.gnu.org
Subject: Re: bug#18373: desktop-create-buffer: may call bury-buffer on a just
 killed buffer (?)
Date: Tue, 09 Sep 2014 20:48:36 -0400

Version:24.4

> 	This, however, fails – should one or more of these buffers be
> 	killed after the list is saved but before it’s processed, – as
> 	happens with some (presumably temporary) buffers used by
> 	url-retrieve, which is in turn used while restoring EWW buffers
> 	per [1].  (Please note that the patch there is broken, though.)
> 	The patch MIMEd seems to fix the issue for me, although I’m not
> 	as of yet certain that no buffer can be killed in between the
> 	buffer-live-p check and the bury-buffer call.

Thanks, the patch looks good and safe, so I installed it into `emacs-24'.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.