From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 31 16:05:30 2014 Received: (at submit) by debbugs.gnu.org; 31 Aug 2014 20:05:30 +0000 Received: from localhost ([127.0.0.1]:55144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XOBNR-0006e1-8q for submit@debbugs.gnu.org; Sun, 31 Aug 2014 16:05:29 -0400 Received: from fely.am-1.org ([78.47.74.50]:52788) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XOBNO-0006ds-Ii for submit@debbugs.gnu.org; Sun, 31 Aug 2014 16:05:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=PqBlaZMsbajjgOEMbBqPj9RZ3TScrrsSFkl7akmSoiE=; b=d2TTTt636p10IxxmGfOzmOAitUQQWIuAxGdldKnt6dwIpGCOftdUxw10MWJrthCmABKglk7IpUegLoe4WVmZwGmyI9mQaEls4R46R/6HSAPUZuwH/t2Fr4LZaoliJgioX2lbZuWvWQgdNLHeV6F5IIzCFFYHzA0o5zTnsdd3UtI=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XOBNN-0003FY-TB for submit@debbugs.gnu.org; Sun, 31 Aug 2014 20:05:26 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XOBNG-0001DG-Ty for submit@debbugs.gnu.org; Mon, 01 Sep 2014 03:05:19 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: desktop-read: do not (desktop-clear) when no .emacs.desktop file is found Date: Sun, 31 Aug 2014 20:05:17 +0000 Message-ID: <87tx4stog2.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Tags: patch As currently implemented, desktop-read calls desktop-clear when no .emacs.desktop file is found: 1114 (if (file-exists-p (desktop-full-file-name)) =E2=8B=AF 1192 ;; No desktop file found. 1193 (desktop-clear) 1194 (let ((default-directory desktop-dirname)) 1195 (run-hooks 'desktop-no-desktop-file-hook)) 1196 (message "No desktop file.") While this is likely to be a no-op when desktop-read is called from user=E2=80=99s ~/.emacs, =E2=80=93 this may actually affect user=E2= =80=99s session if desktop-read gets called from within an established session. And even more so a session containing any =E2=80=9Cprocess interaction=E2= =80=9D buffers, =E2=80=93 like those one gets with M-x run-scheme or M-x erc. (Unless desktop-clear-preserve-buffers is suitably customized beforehand, that is. However, as it seems, that may easily spin off the limits of convenience, which may be a bug by itself.) Given that desktop-read does /not/ call desktop-clear in the =E2=80=9C.emacs.desktop is found=E2=80=9D branch, and that in that case, desktop-read /appends/ to the current session (rather than /replacing/ it), I see no good reason to call desktop-clear from desktop-read in the other case, either. Please thus consider the (trivial) patch MIMEd. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/desktop.el +++ b/lisp/desktop.el @@ -1190,7 +1190,6 @@ (desktop-auto-save-enable) t)) ;; No desktop file found. - (desktop-clear) (let ((default-directory desktop-dirname)) (run-hooks 'desktop-no-desktop-file-hook)) (message "No desktop file.") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 23 10:29:49 2015 Received: (at 18371-done) by debbugs.gnu.org; 23 Jan 2015 15:29:49 +0000 Received: from localhost ([127.0.0.1]:54445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEgBB-0003g0-ET for submit@debbugs.gnu.org; Fri, 23 Jan 2015 10:29:49 -0500 Received: from fely.am-1.org ([78.47.74.50]:50674) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YEgB9-0003fs-1N for 18371-done@debbugs.gnu.org; Fri, 23 Jan 2015 10:29:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=xdBQ2wjIlFps07EmwIznmUyRiAHOnbvGA6Tof5AhYaw=; b=XZQFI8/ILZbnTjCQ5qh3Xy8tNM1Cx8PuuVco8HQt8/XWPxL+dcAd7SqZoIWaX5qsksrBZwbw2NX8xkJhfVBvPr2A19i6YjWrMr94ZKh4tEDRt+coFm/DRC0W7gw1+CG6etsRobV4uKtZ++UXs36xwfUEAWhFyrvav/EQceZlCJ0=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YEgB7-0002dr-VN for 18371-done@debbugs.gnu.org; Fri, 23 Jan 2015 15:29:46 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YEgB0-0002oo-NY for 18371-done@debbugs.gnu.org; Fri, 23 Jan 2015 22:29:38 +0700 From: Ivan Shmakov To: 18371-done@debbugs.gnu.org Subject: Re: bug#18371: desktop-read: do not (desktop-clear) when no .emacs.desktop file is found References: <87tx4stog2.fsf@violet.siamics.net> Mail-Followup-To: 18371@debbugs.gnu.org Date: Fri, 23 Jan 2015 15:29:38 +0000 In-Reply-To: <87tx4stog2.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sun, 31 Aug 2014 20:05:17 +0000") Message-ID: <878ugto6ql.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 18371-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Version: 25.1 >>>>> Ivan Shmakov writes: [=E2=80=A6] > Given that desktop-read does /not/ call desktop-clear in the > =E2=80=9C.emacs.desktop is found=E2=80=9D branch, and that in that case,= desktop-read > /appends/ to the current session (rather than /replacing/ it), I see > no good reason to call desktop-clear from desktop-read in the other > case, either. > Please thus consider the (trivial) patch MIMEd. Pushed; closing. commit e391d88705efd3897996ed81e1f37b936dc3aa21 CommitDate: 2015-01-17 19:35:22 +0000 Do not clear the session when trying to read a non-existent desktop fil= e. * lisp/desktop.el (desktop-read): Do not call desktop-clear when no desktop file is found. Fixes: debbugs:18371 --=20 FSF associate member #7257 np. Liar =E2=80=94 Motorhead =E2=80=A6 3= 013 B6A0 230E 334A From unknown Thu Sep 11 23:18:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 21 Feb 2015 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator