GNU bug report logs - #18360
Modularize recent qsort_r additions

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Fri, 29 Aug 2014 20:59:01 UTC

Severity: wishlist

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 18360 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 18360 <at> debbugs.gnu.org
Subject: Re: bug#18360: Modularize recent qsort_r additions
Date: Sat, 30 Aug 2014 10:29:44 +0300
> Date: Fri, 29 Aug 2014 13:58:01 -0700
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> 
> The recent changes to have Emacs use qsort_r look good except for the 
> forest of #ifdefs in Emacs proper.  Attached is a proposed patch to 
> migrate that stuff into Gnulib.  As usual most of this patch is 
> automatically generated; fns.c contains the crucial hand-generated 
> stuff.  I have not tested this on Microsoft Windows and so am posting it 
> here first to give Eli a heads-up.

Why is it a good idea to use qsort_r?  It's evidently not portable
enough, and its benefits for Emacs at this time are nil, AFAICT.

I say let's wait until we really need a reentrant sort function, and
introduce it then.  qsort is good enough for us for now.




This bug report was last modified 10 years and 353 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.