From unknown Sun Sep 14 17:32:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18354: 24.4.50; vector sorting on darwin broken Resent-From: Jordon Biondo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Aug 2014 15:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18354 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18354@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140932655121157 (code B ref -1); Fri, 29 Aug 2014 15:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Aug 2014 15:35:51 +0000 Received: from localhost ([127.0.0.1]:53655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNODO-0005VA-9r for submit@debbugs.gnu.org; Fri, 29 Aug 2014 11:35:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60164) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNODL-0005Uw-IP for submit@debbugs.gnu.org; Fri, 29 Aug 2014 11:35:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNOCi-0000pt-Qo for submit@debbugs.gnu.org; Fri, 29 Aug 2014 11:35:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNOCi-0000Zb-NZ for submit@debbugs.gnu.org; Fri, 29 Aug 2014 11:35:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNO2n-0007Rj-6Q for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 11:25:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNO2c-0005Wg-Ia for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 11:24:53 -0400 Received: from mail-ie0-x22f.google.com ([2607:f8b0:4001:c03::22f]:64294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNO2c-0005WW-8x for bug-gnu-emacs@gnu.org; Fri, 29 Aug 2014 11:24:42 -0400 Received: by mail-ie0-f175.google.com with SMTP id y20so2846286ier.6 for ; Fri, 29 Aug 2014 08:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:content-transfer-encoding:subject:message-id:date :to:mime-version; bh=gDsAIUYlM03clCQ7OLa4B7KXORhBCkvXw1UaqOFKIhU=; b=lOkTERvsrSVobiOBHBrDijMkJ3O2A1XPTpG0beDPrICN6wNOHtF/lZJNsbbEg6bPQj Jokh0koNk52mp5um5MYSpah5dYcCaGR2SgtutDRRrzan7HcausSYxvS8ktHAEOTij0Tu 9cLO6wr7HraI1qY2kW1Wf3zjlyd6F/qjBALLnsG4geBdAvManhx8+qd3fSWU9FywDk+x 9ryyYJbDu1fmUQe8hL8bndnL+qGjOwdOP59BbcdMFxSFm+2JoG7MxoWjJkeib7RHxXGV vb/wLGurNoqPOuoA3MoVKvlN9E0gKQ4EWcQq3GaFELr7eDeNbEIFvAZ3iBgi69ju/eU0 Cefg== X-Received: by 10.51.17.2 with SMTP id ga2mr5063234igd.2.1409325881360; Fri, 29 Aug 2014 08:24:41 -0700 (PDT) Received: from [10.1.10.27] (173-10-37-102-Michigan.hfc.comcastbusiness.net. [173.10.37.102]) by mx.google.com with ESMTPSA id p5sm1080603iga.5.2014.08.29.08.24.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 29 Aug 2014 08:24:40 -0700 (PDT) From: Jordon Biondo Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: Date: Fri, 29 Aug 2014 11:24:39 -0400 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) X-Mailer: Apple Mail (2.1878.2) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Sorting vectors on a DARWIN system now segfaults due to a difference in the order in which arguments are passed. I believe this is also the case on bsd and others. (sort [1 4 2] '<) ;; =3D> seg fault I have included my fix for my DARWIN system. I cannot test on bsd and other. So I think it needs to be hashed out more for full portability, but this works for my single use case. Thank You. *** fns.c 2014-08-29 11:02:30.000000000 -0400 --- newfns.c 2014-08-29 11:02:25.000000000 -0400 *************** static Lisp_Object sort_vector_predicate *** 1885,1891 **** =20 static int #ifdef HAVE_QSORT_R ! sort_vector_compare (const void *p, const void *q, void *arg) #else sort_vector_compare (const void *p, const void *q) #endif /* HAVE_QSORT_R */ =20 --- 1885,1895 ---- =20 static int #ifdef HAVE_QSORT_R ! #ifdef DARWIN_OS ! sort_vector_compare (void *arg, const void *p, const void *q) ! #else ! sort_vector_compare (const void *p, const void *q, const void *arg) ! #endif #else sort_vector_compare (const void *p, const void *q) #endif /* HAVE_QSORT_R */ =20 *************** sort_vector (Lisp_Object vector, Lisp_Ob *** 1928,1934 **** --- 1932,1942 ---- =20 /* Setup predicate and sort. */ #ifdef HAVE_QSORT_R + #ifdef DARWIN_OS + qsort_r (v, len, word_size, (void *) &predicate, = sort_vector_compare); + #else qsort_r (v, len, word_size, sort_vector_compare, (void *) = &predicate); + #endif #else =20 sort_vector_predicate =3D predicate; qsort (v, len, word_size, sort_vector_compare); In GNU Emacs 24.4.50.28 (x86_64-apple-darwin13.2.0, NS appkit-1265.20 = Version 10.9.3 (Build 13D65)) of 2014-08-29 on kerbin Configured using: `configure --with-ns' Configured features: IMAGEMAGICK ACL LIBXML2 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent input: ESC [ > 0 ; 9 5 ; 0 c ESC x r e p o r TAB RET Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: /Users/jordon/src/emacs/lisp/leim/quail/tibetan hides = /Users/jordon/src/emacs/lisp/language/tibetan /Users/jordon/src/emacs/lisp/leim/quail/thai hides = /Users/jordon/src/emacs/lisp/language/thai /Users/jordon/src/emacs/lisp/leim/quail/slovak hides = /Users/jordon/src/emacs/lisp/language/slovak /Users/jordon/src/emacs/lisp/leim/quail/lao hides = /Users/jordon/src/emacs/lisp/language/lao /Users/jordon/src/emacs/lisp/leim/quail/japanese hides = /Users/jordon/src/emacs/lisp/language/japanese /Users/jordon/src/emacs/lisp/leim/quail/indian hides = /Users/jordon/src/emacs/lisp/language/indian /Users/jordon/src/emacs/lisp/leim/quail/hebrew hides = /Users/jordon/src/emacs/lisp/language/hebrew /Users/jordon/src/emacs/lisp/leim/quail/greek hides = /Users/jordon/src/emacs/lisp/language/greek /Users/jordon/src/emacs/lisp/leim/quail/georgian hides = /Users/jordon/src/emacs/lisp/language/georgian /Users/jordon/src/emacs/lisp/leim/quail/ethiopic hides = /Users/jordon/src/emacs/lisp/language/ethiopic /Users/jordon/src/emacs/lisp/leim/quail/czech hides = /Users/jordon/src/emacs/lisp/language/czech /Users/jordon/src/emacs/lisp/leim/quail/cyrillic hides = /Users/jordon/src/emacs/lisp/language/cyrillic Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils xterm time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) Memory information: ((conses 16 82723 5894) (symbols 48 17976 0) (miscs 40 33 99) (strings 32 11516 4325) (string-bytes 1 293393) (vectors 16 7607) (vector-slots 8 343947 26707) (floats 8 64 289) (intervals 56 154 0) (buffers 976 11)) From unknown Sun Sep 14 17:32:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18354: 24.4.50; vector sorting on darwin broken Resent-From: Dmitry Antipov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Aug 2014 16:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18354 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jordon Biondo Cc: 18354@debbugs.gnu.org Received: via spool by 18354-submit@debbugs.gnu.org id=B18354.140932950625893 (code B ref 18354); Fri, 29 Aug 2014 16:26:02 +0000 Received: (at 18354) by debbugs.gnu.org; 29 Aug 2014 16:25:06 +0000 Received: from localhost ([127.0.0.1]:53687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNOz3-0006jW-3M for submit@debbugs.gnu.org; Fri, 29 Aug 2014 12:25:05 -0400 Received: from forward10l.mail.yandex.net ([84.201.143.143]:35159) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNOyz-0006ix-Bv for 18354@debbugs.gnu.org; Fri, 29 Aug 2014 12:25:03 -0400 Received: from smtp4o.mail.yandex.net (smtp4o.mail.yandex.net [37.140.190.29]) by forward10l.mail.yandex.net (Yandex) with ESMTP id CCEBDBA112D; Fri, 29 Aug 2014 20:24:54 +0400 (MSK) Received: from smtp4o.mail.yandex.net (localhost [127.0.0.1]) by smtp4o.mail.yandex.net (Yandex) with ESMTP id 549AD2322A4B; Fri, 29 Aug 2014 20:24:54 +0400 (MSK) Received: from unknown (unknown [37.139.80.10]) by smtp4o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id C9maNGp1kS-Or3S6kf7; Fri, 29 Aug 2014 20:24:53 +0400 (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (Client certificate not present) X-Yandex-Uniq: 99cb9f41-b3e8-4a92-8393-af7bd267bc28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1409329493; bh=+6DnZv6Spx/EH8JzMwxWnvGg88k3uEItnuO8oz6JYKY=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=n2ho6PMD7Y0moX7ANYSyzDj4N5sn50tC0LYt2cAXt72sNE3Jtqyf8LjUVF5RZZznm QZQES/DdmEGkQ4PEIhEH/CTwsvBz47EWeDNk+qcZZviTtyDlbwFzNAJvh/hPUgOrdz QteXBMEdrQd+Mhrw5Aax+Srii1QGIDVi9Vz1IBjQ= Authentication-Results: smtp4o.mail.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <5400A955.5070506@yandex.ru> Date: Fri, 29 Aug 2014 20:24:53 +0400 From: Dmitry Antipov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 08/29/2014 07:24 PM, Jordon Biondo wrote: > Sorting vectors on a DARWIN system now segfaults due to a difference in > the order in which arguments are passed. I believe this is also the case > on bsd and others. Hopefully should be fixed in r117769. Verified on FreeBSD 10.0. Someday I'll think about wrapping all of that mess in sysdep.c. Dmitry From unknown Sun Sep 14 17:32:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18354: 24.4.50; vector sorting on darwin broken Resent-From: Jordon Biondo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Aug 2014 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18354 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Antipov Cc: 18354@debbugs.gnu.org Received: via spool by 18354-submit@debbugs.gnu.org id=B18354.140933085728184 (code B ref 18354); Fri, 29 Aug 2014 16:48:02 +0000 Received: (at 18354) by debbugs.gnu.org; 29 Aug 2014 16:47:37 +0000 Received: from localhost ([127.0.0.1]:53700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNPKr-0007KV-1V for submit@debbugs.gnu.org; Fri, 29 Aug 2014 12:47:37 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:60884) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNPKo-0007KD-HH for 18354@debbugs.gnu.org; Fri, 29 Aug 2014 12:47:35 -0400 Received: by mail-ie0-f172.google.com with SMTP id rd18so3077166iec.17 for <18354@debbugs.gnu.org>; Fri, 29 Aug 2014 09:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=XFRs9NgSXvQuGjmY99ujpkwkXs2KBMRlnnrry5+6rqI=; b=dVgZyK8h+0s78nc1l+RKJxdiG5g4X5UfKo2LLQCKw2zyEun0B4tbNhcwxxpI7CEG+H 4cOykv4+B9DYjP2hCYQ9II4iDsb8LH6WZjI7waoy8sastqDyUMmaZYJPCMR5Q4/J8sTh AAkAGq5k01Gs3MROqc5hfinfNrrJAEohgKx7Y04aQlRjPy3Ad6bIOs7iKCadD3RBo6mh QPxnz+0YGFAdPFsBcfuIwx9+bsPKpH21sk58NmGBtYlchpBb2Z+0pINGfVEQgm4VWTWP ry/zrU1zFk0eZFPjDWmww1JOcDV/mkQAwG/Q+ndYWkvIfe3QL0fFuVHD32235GIp4wOS HJKQ== X-Received: by 10.43.140.4 with SMTP id iy4mr12416063icc.23.1409330848776; Fri, 29 Aug 2014 09:47:28 -0700 (PDT) Received: from [10.1.10.27] (173-10-37-102-Michigan.hfc.comcastbusiness.net. [173.10.37.102]) by mx.google.com with ESMTPSA id ki5sm1404869igb.2.2014.08.29.09.47.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 29 Aug 2014 09:47:28 -0700 (PDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) From: Jordon Biondo In-Reply-To: <5400A955.5070506@yandex.ru> Date: Fri, 29 Aug 2014 12:47:26 -0400 Content-Transfer-Encoding: 7bit Message-Id: References: <5400A955.5070506@yandex.ru> X-Mailer: Apple Mail (2.1878.2) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Aug 29, 2014, at 12:24 PM, Dmitry Antipov wrote: > Hopefully should be fixed in r117769. Verified on FreeBSD 10.0. > > Someday I'll think about wrapping all of that mess in sysdep.c. Great, thank you, tests are passing on darwin system. Jordon From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 29 15:16:25 2014 Received: (at control) by debbugs.gnu.org; 29 Aug 2014 19:16:25 +0000 Received: from localhost ([127.0.0.1]:53773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNRer-0003pI-4S for submit@debbugs.gnu.org; Fri, 29 Aug 2014 15:16:25 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:60696 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNRep-0003pA-8c for control@debbugs.gnu.org; Fri, 29 Aug 2014 15:16:23 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XNReo-0004AL-FJ for control@debbugs.gnu.org; Fri, 29 Aug 2014 15:16:22 -0400 Date: Fri, 29 Aug 2014 15:16:22 -0400 Message-Id: Subject: control message for bug 18354 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) close 18354