From unknown Thu Jun 19 14:04:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18349 <18349@debbugs.gnu.org> To: bug#18349 <18349@debbugs.gnu.org> Subject: Status: 24.3.92; define-minor-mode: generated doc of hook: mode vs. modefun Reply-To: bug#18349 <18349@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:04:08 +0000 retitle 18349 24.3.92; define-minor-mode: generated doc of hook: mode vs. m= odefun reassign 18349 emacs submitter 18349 michael_heerdegen@web.de severity 18349 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 28 18:27:19 2014 Received: (at submit) by debbugs.gnu.org; 28 Aug 2014 22:27:19 +0000 Received: from localhost ([127.0.0.1]:52890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XN8A2-0002bk-Fz for submit@debbugs.gnu.org; Thu, 28 Aug 2014 18:27:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40950) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XN8A0-0002bW-3V for submit@debbugs.gnu.org; Thu, 28 Aug 2014 18:27:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XN89n-00026g-Mj for submit@debbugs.gnu.org; Thu, 28 Aug 2014 18:27:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN89n-00026c-KR for submit@debbugs.gnu.org; Thu, 28 Aug 2014 18:27:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN89h-0007jk-CK for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2014 18:27:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XN89Z-00023C-Mz for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2014 18:26:57 -0400 Received: from mout.web.de ([212.227.15.3]:58633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XN89Z-00022g-E7 for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2014 18:26:49 -0400 Received: from drachen.dragon ([90.187.5.104]) by smtp.web.de (mrweb003) with ESMTPSA (Nemesis) id 0MORtt-1XHMzg1ddF-005q6l for ; Fri, 29 Aug 2014 00:26:46 +0200 From: Michael Heerdegen To: bug-gnu-emacs@gnu.org Subject: 24.3.92; define-minor-mode: generated doc of hook: mode vs. modefun Date: Fri, 29 Aug 2014 00:26:41 +0200 Message-ID: <874mww45em.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:KbbdMuGtDfk+TlVDFpIA1uvAFbQAA7tHG6Cu4HFcEX3oH0HJXnL l7g+X1rViEthx39LR7tiWU0GoL0mYmreb229q+AiBH0M34V6W/e/cAEBbOcmnI/7ZwUylSx 3kht59Ucc264fKsqW8ZxG5/afFGfPQDcGvHSg6XIaYu+Rla7YzmwBOEAr5nlOXB0W8MxsEo yfDToAj9E0bfK/lJocp7w== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: michael_heerdegen@web.de List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/plain Hello, in emacs -Q, eval (define-minor-mode my-minor-mode "Doc" :variable foo ...) Then, C-h v my-minor-mode-hook: [...] Documentation: Hook run after entering or leaving `foo'. [...] ^^^^^ This makes no sense, the doc of the hook should include the name of the mode function, not that of the variable. That happens e.g. for `read-only-mode-hook'. Is this the right thing? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=easy-mmode.patch *** /tmp/ediff9150_DV 2014-08-29 00:18:07.582868434 +0200 --- /home/micha/software/emacs/lisp/emacs-lisp/easy-mmode.el 2014-08-29 00:17:46.634718136 +0200 *************** *** 300,306 **** ,(format "Hook run after entering or leaving `%s'. No problems result if this variable is not bound. `add-hook' automatically binds it. (This is true for all hook variables.)" ! mode)) ;; Define the minor-mode keymap. ,(unless (symbolp keymap) ;nil is also a symbol. --- 300,306 ---- ,(format "Hook run after entering or leaving `%s'. No problems result if this variable is not bound. `add-hook' automatically binds it. (This is true for all hook variables.)" ! modefun)) ;; Define the minor-mode keymap. ,(unless (symbolp keymap) ;nil is also a symbol. --=-=-= Content-Type: text/plain Thanks, Michael. In GNU Emacs 24.3.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2) of 2014-08-11 on drachen Windowing system distributor `The X.Org Foundation', version 11.0.11600000 System Description: Debian GNU/Linux testing (jessie) Important settings: value of $LC_ALL: de_DE.utf8 value of $LC_COLLATE: C value of $LC_TIME: C value of $LANG: de_DE.utf8 locale-coding-system: utf-8-unix --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 28 22:01:35 2014 Received: (at 18349) by debbugs.gnu.org; 29 Aug 2014 02:01:35 +0000 Received: from localhost ([127.0.0.1]:52977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNBVO-0007lx-10 for submit@debbugs.gnu.org; Thu, 28 Aug 2014 22:01:34 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:49362) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNBVL-0007ln-50 for 18349@debbugs.gnu.org; Thu, 28 Aug 2014 22:01:31 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s7T21TfG026842; Thu, 28 Aug 2014 22:01:29 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 4ED95AE88E; Thu, 28 Aug 2014 22:01:29 -0400 (EDT) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#18349: 24.3.92; define-minor-mode: generated doc of hook: mode vs. modefun Message-ID: References: <874mww45em.fsf@web.de> Date: Thu, 28 Aug 2014 22:01:29 -0400 In-Reply-To: <874mww45em.fsf@web.de> (Michael Heerdegen's message of "Fri, 29 Aug 2014 00:26:41 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5047=0 X-NAI-Spam-Version: 2.3.0.9378 : core <5047> : inlines <1220> : streams <1276340> : uri <1807843> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 18349 Cc: 18349@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > Is this the right thing? Yes, it is. Thanks for catching it, feel free to install, Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 29 16:39:35 2014 Received: (at 18349) by debbugs.gnu.org; 29 Aug 2014 20:39:35 +0000 Received: from localhost ([127.0.0.1]:53810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNSxL-0007Cr-Gr for submit@debbugs.gnu.org; Fri, 29 Aug 2014 16:39:35 -0400 Received: from mout.web.de ([212.227.17.12]:49328) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNSxI-0007Cc-19 for 18349@debbugs.gnu.org; Fri, 29 Aug 2014 16:39:33 -0400 Received: from drachen.dragon ([90.186.226.21]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0MUWBb-1XoaZl01xL-00RIJG; Fri, 29 Aug 2014 22:39:22 +0200 From: Michael Heerdegen To: Stefan Monnier Subject: Re: bug#18349: 24.3.92; define-minor-mode: generated doc of hook: mode vs. modefun References: <874mww45em.fsf@web.de> Date: Fri, 29 Aug 2014 22:39:01 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 28 Aug 2014 22:01:29 -0400") Message-ID: <87iolbf2u2.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:MpJu9QawIH/TguXLvVe88aDWBHSAxlPT6GBImkU4iEOj+psnH83 CvWmgO9ZPvLe4uGZoIYcmLUyBDnDcVg7HWv5Ab32UQffnU3N2I4kG265UasVsq1XQyvLYKp 2Wrq5foBUAyIimk8sC92r96S4+MsVY4o9e8etqGnEaORf2TBdvy9jfP7PfUQWwFgwYyVu7B USQ/d/SUye1s/gfdao0Hg== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18349 Cc: 18349@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: > Yes, it is. Thanks for catching it, feel free to install, Installed in trunk in revision 117777. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 29 17:38:00 2014 Received: (at control) by debbugs.gnu.org; 29 Aug 2014 21:38:00 +0000 Received: from localhost ([127.0.0.1]:53840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNTrr-0000AJ-I0 for submit@debbugs.gnu.org; Fri, 29 Aug 2014 17:37:59 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:35592 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNTro-0000A9-Be for control@debbugs.gnu.org; Fri, 29 Aug 2014 17:37:57 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XNTrn-0007CS-IZ for control@debbugs.gnu.org; Fri, 29 Aug 2014 17:37:55 -0400 Date: Fri, 29 Aug 2014 17:37:55 -0400 Message-Id: Subject: control message for bug 18349 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) close 18349 24.5 From unknown Thu Jun 19 14:04:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Sep 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 04 12:35:32 2014 Received: (at control) by debbugs.gnu.org; 4 Oct 2014 16:35:32 +0000 Received: from localhost ([127.0.0.1]:33183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XaSIt-0002m9-8U for submit@debbugs.gnu.org; Sat, 04 Oct 2014 12:35:31 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:60039) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XaSIr-0002lz-Gi for control@debbugs.gnu.org; Sat, 04 Oct 2014 12:35:29 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XaSIq-0005r2-MO; Sat, 04 Oct 2014 12:35:28 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21552.8656.554316.921175@gnu.org> Date: Sat, 4 Oct 2014 12:35:28 -0400 From: Glenn Morris To: GNU bug tracker automated control server Subject: Update Emacs archived fixed bugs for 24.5 version number change X-Debbugs-No-Ack: yes X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) unarchive 18304 fixed 18304 25.1 notfixed 18304 24.5 unarchive 12008 fixed 12008 25.1 notfixed 12008 24.5 unarchive 17110 fixed 17110 25.1 notfixed 17110 24.5 unarchive 17218 fixed 17218 25.1 notfixed 17218 24.5 unarchive 18222 fixed 18222 25.1 notfixed 18222 24.5 unarchive 18023 fixed 18023 25.1 notfixed 18023 24.5 unarchive 17225 fixed 17225 25.1 notfixed 17225 24.5 unarchive 16626 fixed 16626 25.1 notfixed 16626 24.5 unarchive 18326 fixed 18326 25.1 notfixed 18326 24.5 unarchive 18227 fixed 18227 25.1 notfixed 18227 24.5 unarchive 16328 fixed 16328 25.1 notfixed 16328 24.5 unarchive 17333 fixed 17333 25.1 notfixed 17333 24.5 unarchive 13837 fixed 13837 25.1 notfixed 13837 24.5 unarchive 17641 fixed 17641 25.1 notfixed 17641 24.5 unarchive 18341 fixed 18341 25.1 notfixed 18341 24.5 unarchive 18349 fixed 18349 25.1 notfixed 18349 24.5 unarchive 2151 fixed 2151 25.1 notfixed 2151 24.5 unarchive 5853 fixed 5853 25.1 notfixed 5853 24.5 unarchive 17857 fixed 17857 25.1 notfixed 17857 24.5 unarchive 17858 fixed 17858 25.1 notfixed 17858 24.5 unarchive 17859 fixed 17859 25.1 notfixed 17859 24.5 unarchive 17160 fixed 17160 25.1 notfixed 17160 24.5 unarchive 2263 fixed 2263 25.1 notfixed 2263 24.5 unarchive 18368 fixed 18368 25.1 notfixed 18368 24.5 unarchive 17772 fixed 17772 25.1 notfixed 17772 24.5 unarchive 17276 fixed 17276 25.1 notfixed 17276 24.5 unarchive 15991 fixed 15991 25.1 notfixed 15991 24.5 unarchive 17699 fixed 17699 25.1 notfixed 17699 24.5 From unknown Thu Jun 19 14:04:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Nov 2014 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator