GNU bug report logs - #18341
24.4.50; [patch] control where hook is added minibuffer-with-setup-hook

Previous Next

Full log

Message #14 received at 18341 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 18341 <at> debbugs.gnu.org
Subject: Re: bug#18341: 24.4.50;
 [patch] control where hook is added minibuffer-with-setup-hook
Date: Thu, 28 Aug 2014 22:03:47 -0400

> +    (when (eq (car-safe fun) :append)
> +      (setq append t)

Please make it '(t) so you can use ,@append and get marginally cleaner
macroexpanded code when :append is not used.

> +      (pop fun))

I think this implements (:append . FUN) rather than (:append FUN).
Other than that, feel free to install into trunk.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.