GNU bug report logs - #18331
24.4.50; REGRESSION, no `C-h k' for `C-g'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18331: closed (24.4.50; REGRESSION, no `C-h k' for `C-g')
Date: Thu, 04 Sep 2014 15:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 04 Sep 2014 18:12:38 +0300
with message-id <83r3zre7x5.fsf <at> gnu.org>
and subject line Re: bug#18331: 24.4.50; REGRESSION, no `C-h k' for `C-g'
has caused the debbugs.gnu.org bug report #18331,
regarding 24.4.50; REGRESSION, no `C-h k' for `C-g'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18331: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18331
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; REGRESSION, no `C-h k' for `C-g'
Date: Mon, 25 Aug 2014 14:36:28 -0700 (PDT)

This REGRESSION was introduced after 24.3 and on or before 2013-05-15 (I
don't have an older 24.4 build than that, to test).

emacs -Q

C-h k C-g  ; Acts normally: shows help for `C-g'.

Evaluate this:

(custom-set-variables '(global-font-lock-mode t nil (font-lock)))

C-h k C-g  ; No help. Instead, a `quit' is performed.



In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm <at> gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: monnier <at> iro.umontreal.ca, Drew Adams <drew.adams <at> oracle.com>
Cc: theonewiththeevillook <at> yahoo.fr, 18331-done <at> debbugs.gnu.org
Subject: Re: bug#18331: 24.4.50; REGRESSION, no `C-h k' for `C-g'
Date: Thu, 04 Sep 2014 18:12:38 +0300

> Date: Wed, 27 Aug 2014 18:30:15 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: theonewiththeevillook <at> yahoo.fr, 18331 <at> debbugs.gnu.org
> 
> I can fix this problem with the simple patch below.  Does anyone see
> any problems with it?
> 
> --- src/data.c~	2014-08-03 08:43:52 +0300
> +++ src/data.c	2014-08-27 18:28:13 +0300
> @@ -1311,10 +1311,10 @@ set_internal (Lisp_Object symbol, Lisp_O
>  
>  	    /* Find the new binding.  */
>  	    XSETSYMBOL (symbol, sym); /* May have changed via aliasing.  */
> -	    tem1 = Fassq (symbol,
> -			  (blv->frame_local
> -			   ? XFRAME (where)->param_alist
> -			   : BVAR (XBUFFER (where), local_var_alist)));
> +	    tem1 = assq_no_quit (symbol,
> +				 (blv->frame_local
> +				  ? XFRAME (where)->param_alist
> +				  : BVAR (XBUFFER (where), local_var_alist)));
>  	    set_blv_where (blv, where);
>  	    blv->found = 1;

No comments, so I installed this on the emacs-24 branch (r117479) and
I'm marking this done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.