From unknown Fri Jun 20 18:18:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18300 <18300@debbugs.gnu.org> To: bug#18300 <18300@debbugs.gnu.org> Subject: Status: erc-format-target-and/or-network: do not rename server buffers unconditionally Reply-To: bug#18300 <18300@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:18:21 +0000 retitle 18300 erc-format-target-and/or-network: do not rename server buffer= s unconditionally=20 reassign 18300 emacs submitter 18300 Ivan Shmakov severity 18300 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 20 10:50:03 2014 Received: (at submit) by debbugs.gnu.org; 20 Aug 2014 14:50:03 +0000 Received: from localhost ([127.0.0.1]:48282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XK7D8-00078E-Je for submit@debbugs.gnu.org; Wed, 20 Aug 2014 10:50:03 -0400 Received: from fely.am-1.org ([78.47.74.50]:51310) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XK7D5-00077l-0U for submit@debbugs.gnu.org; Wed, 20 Aug 2014 10:50:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=JR2ujAjgz6whNl6dI7oZC9APi0Wq6L5vVrTa90AULQE=; b=lOPdQwSl2lPBji232FZDq+AWQ+QapoQ+8+YkBSsFuGPPPCt3BrnTbJEdebBIHYf6otyKbe6XFR7Pl3lgJuNDzOxPhXMjOEEVf9P9hNb4MKMDaFt36U1yOtKs3x07Qn3rzDgHGLVK0ALKfBrgKZyflIEljrA0JjC/bsMNOho6J3c=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XK7D3-0008Dh-1D for submit@debbugs.gnu.org; Wed, 20 Aug 2014 14:49:57 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XK7Cv-00010m-SN for submit@debbugs.gnu.org; Wed, 20 Aug 2014 21:49:49 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: erc-format-target-and/or-network: do not rename server buffers unconditionally Date: Wed, 20 Aug 2014 14:49:49 +0000 Message-ID: <87a96zz04y.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: wishlist X-Debbugs-Cc: Kelvin White Some two weeks ago, erc-format-target-and/or-network was patched to unconditionally rename server buffers according to the name of the associated IRC network (see below.) I find this new behavior mildly confusing, and would rather prefer an option to turn it off; or the change be reverted altogether. An option may allow for a function value, to be used as in the following cond clause: ((and network-name (if (functionp erc-XXX-new-option) (funcall erc-XXX-new-option) erc-XXX-new-option) (not (get-buffer (or (funcall erc-XXX-new-option) network-name)))) (rename-buffer (or (funcall erc-XXX-new-option) network-name)) network-name) Naturally, the result of (funcall erc-XXX-new-option) should be preserved rather than recomputed thrice. (FWIW, I=E2=80=99ve simply commented out this part of the code to get the old behavior.) TIA. PS. JFTR, these few new ERC patches have added a few trailing blanks to the code for no good reason. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/plain Content-Disposition: inline commit 342b156cbe06c099a982d1e2fd9a01b074dff222 Author: Kelvin White AuthorDate: Thu Aug 7 12:44:19 2014 -0400 * lisp/erc/erc.el: rename server buffers and fix variable names @@ -6233,7 +6233,10 @@ shortened server name instead." (cond ((erc-default-target) (concat (erc-string-no-properties (erc-default-target)) "@" network-name)) - (network-name network-name) + ((and network-name + (not (string-equal network-name (buffer-name)))) + (rename-buffer network-name) + network-name) (t (buffer-name (current-buffer)))))) (defun erc-format-away-status () --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 20 11:13:44 2014 Received: (at 18300) by debbugs.gnu.org; 20 Aug 2014 15:13:44 +0000 Received: from localhost ([127.0.0.1]:48300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XK7a3-0007iY-MT for submit@debbugs.gnu.org; Wed, 20 Aug 2014 11:13:44 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:38102 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XK7a0-0007iP-RC for 18300@debbugs.gnu.org; Wed, 20 Aug 2014 11:13:41 -0400 Received: from [2600:3c02::f03c:91ff:fe73:3fa6] (port=48981 helo=localhost.gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1XK7Zz-0001gF-I8; Wed, 20 Aug 2014 11:13:39 -0400 Date: Wed, 20 Aug 2014 11:13:20 -0400 Message-ID: <87a96z9otr.wl%kwhite@gnu.org> From: Kelvin White To: 18300@debbugs.gnu.org Subject: Re: bug#18300: erc-format-target-and/or-network: do not rename server buffers unconditionally User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 18300 Cc: Ivan Shmakov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) > I find this new behavior mildly confusing, and would rather > prefer an option to turn it off; or the change be reverted > altogether. TBH I had the same thoughts in hindsight regarding it being optional, or but I am not sure I understand how the server buffer name being named to match the network name would be confusing, or unwanted behavior. Thanks for the feedback, I will add the neccesary code. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 15:44:22 2015 Received: (at 18300) by debbugs.gnu.org; 27 Dec 2015 20:44:22 +0000 Received: from localhost ([127.0.0.1]:44904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDIAw-0008E3-ET for submit@debbugs.gnu.org; Sun, 27 Dec 2015 15:44:22 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:47810) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDIAu-0008Dv-LB for 18300@debbugs.gnu.org; Sun, 27 Dec 2015 15:44:20 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDIAX-0003bo-As; Sun, 27 Dec 2015 21:43:57 +0100 From: Lars Ingebrigtsen To: Kelvin White Subject: Re: bug#18300: erc-format-target-and/or-network: do not rename server buffers unconditionally References: <87a96zz04y.fsf@violet.siamics.net> <87a96z9otr.wl%kwhite@gnu.org> Date: Sun, 27 Dec 2015 21:43:56 +0100 In-Reply-To: <87a96z9otr.wl%kwhite@gnu.org> (Kelvin White's message of "Wed, 20 Aug 2014 11:13:20 -0400") Message-ID: <87a8ovbp0z.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aDIAX-0003bo-As X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451853837.73281@6Ty3bZn4eIOtPRe8LmF41g X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18300 Cc: 18300@debbugs.gnu.org, Ivan Shmakov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Kelvin White writes: >> I find this new behavior mildly confusing, and would rather >> prefer an option to turn it off; or the change be reverted >> altogether. > > TBH I had the same thoughts in hindsight regarding it being optional, > or but I am not sure I understand how the server buffer name being > named to match the network name would be confusing, or unwanted > behavior. Thanks for the feedback, I will add the neccesary code. Was this code added? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 23:25:37 2015 Received: (at 18300) by debbugs.gnu.org; 28 Dec 2015 04:25:37 +0000 Received: from localhost ([127.0.0.1]:45243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDPNF-0000QA-Py for submit@debbugs.gnu.org; Sun, 27 Dec 2015 23:25:37 -0500 Received: from mail-ig0-f172.google.com ([209.85.213.172]:33107) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDPNA-0000Pt-1E for 18300@debbugs.gnu.org; Sun, 27 Dec 2015 23:25:31 -0500 Received: by mail-ig0-f172.google.com with SMTP id mv3so112660704igc.0 for <18300@debbugs.gnu.org>; Sun, 27 Dec 2015 20:25:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=o3q/zEyK1vMgcFMPmG8b6gq4IwgHYeGIhKAlO++WVik=; b=fBjHtye+0Vg4Om5Pp+MOEoOszhUJ7s39AwkImuLaZo6ok1BiVn/kMxdYzO3oderDlB g/YTk7SrEr1ehlBscjRbtPmYXXrwy1i+lff6yvONf/0lWFOgU4NU9+wT13caMqWGKKSs xShPw6FVSkNXR1RNmHDiVabBN/1WFNNZqCOjQvIAw3PsWImjILPAoOHVZJOouI50HD8D Wbau44rVy7S4DvZ62dgzlqrpKrM+tgzwQlSQj+dhwLbIHF1nuKdW4g6HiLg5WwOvnbOw kHZQFk+KCE2g/5imHFhPP8wqaviKFjsFUNPYrPcUjgHSI9PcBvf09VQDEa+JcyP8DmxY SNYw== MIME-Version: 1.0 X-Received: by 10.50.20.36 with SMTP id k4mr51566049ige.87.1451276722512; Sun, 27 Dec 2015 20:25:22 -0800 (PST) Received: by 10.65.14.132 with HTTP; Sun, 27 Dec 2015 20:25:22 -0800 (PST) Received: by 10.65.14.132 with HTTP; Sun, 27 Dec 2015 20:25:22 -0800 (PST) In-Reply-To: <87a8ovbp0z.fsf@gnus.org> References: <87a96zz04y.fsf@violet.siamics.net> <87a96z9otr.wl%kwhite@gnu.org> <87a8ovbp0z.fsf@gnus.org> Date: Sun, 27 Dec 2015 23:25:22 -0500 X-Google-Sender-Auth: C8GektR4kvE30EJ6sWW8pzLxTi8 Message-ID: Subject: Re: bug#18300: erc-format-target-and/or-network: do not rename server buffers unconditionally From: Kelvin White To: Lars Magne Ingebrigtsen Content-Type: multipart/alternative; boundary=047d7bd76d94842f1e0527edb140 X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 18300 Cc: 18300@debbugs.gnu.org, Ivan Shmakov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --047d7bd76d94842f1e0527edb140 Content-Type: text/plain; charset=UTF-8 On Dec 27, 2015 3:44 PM, "Lars Ingebrigtsen" wrote: > > Kelvin White writes: > > >> I find this new behavior mildly confusing, and would rather > >> prefer an option to turn it off; or the change be reverted > >> altogether. > > > > TBH I had the same thoughts in hindsight regarding it being optional, > > or but I am not sure I understand how the server buffer name being > > named to match the network name would be confusing, or unwanted > > behavior. Thanks for the feedback, I will add the neccesary code. > > Was this code added Yes. --047d7bd76d94842f1e0527edb140 Content-Type: text/html; charset=UTF-8

On Dec 27, 2015 3:44 PM, "Lars Ingebrigtsen" <larsi@gnus.org> wrote:
>
> Kelvin White <kwhite@gnu.org> writes:
>
> >> I find this new behavior mildly confusing, and would rather
> >> prefer an option to turn it off; or the change be reverted
> >> altogether.
> >
> > TBH I had the same thoughts in hindsight regarding it being optional,
> > or but I am not sure I understand how the server buffer name being
> > named to match the network name would be confusing, or unwanted
> > behavior. Thanks for the feedback, I will add the neccesary code.
>
> Was this code added

Yes.

--047d7bd76d94842f1e0527edb140-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 28 11:46:44 2015 Received: (at control) by debbugs.gnu.org; 28 Dec 2015 16:46:44 +0000 Received: from localhost ([127.0.0.1]:46607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDawV-000308-WC for submit@debbugs.gnu.org; Mon, 28 Dec 2015 11:46:44 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:50334) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDawU-000300-KS for control@debbugs.gnu.org; Mon, 28 Dec 2015 11:46:42 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDaw8-0002Rk-Qe for control@debbugs.gnu.org; Mon, 28 Dec 2015 17:46:20 +0100 Date: Mon, 28 Dec 2015 17:46:20 +0100 Message-Id: <871ta6wmg3.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #18300 X-MailScanner-ID: 1aDaw8-0002Rk-Qe X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451925982.31915@lirHoIJQ7I7bz+Ob6ugM7A X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) close 18300 From unknown Fri Jun 20 18:18:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 26 Jan 2016 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator