From unknown Sat Jun 21 05:14:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18268: 24.3.92; Make imenu sort submenus also (fix included) Resent-From: carlosjosepita@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Aug 2014 23:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18268 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18268@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140805833012542 (code B ref -1); Thu, 14 Aug 2014 23:19:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Aug 2014 23:18:50 +0000 Received: from localhost ([127.0.0.1]:43694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XI4ID-0003GB-Ka for submit@debbugs.gnu.org; Thu, 14 Aug 2014 19:18:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58163) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XI4I9-0003Fo-8k for submit@debbugs.gnu.org; Thu, 14 Aug 2014 19:18:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XI4Hx-0001NX-Vl for submit@debbugs.gnu.org; Thu, 14 Aug 2014 19:18:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=AC_HTML_NONSENSE_TAGS, BAYES_50, FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XI4Hx-0001NN-SV for submit@debbugs.gnu.org; Thu, 14 Aug 2014 19:18:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XI4Hr-0002YX-QF for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2014 19:18:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XI4Hl-0001MF-OU for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2014 19:18:27 -0400 Received: from mail-yk0-x22e.google.com ([2607:f8b0:4002:c07::22e]:45578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XI4Hl-0001MB-IO for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2014 19:18:21 -0400 Received: by mail-yk0-f174.google.com with SMTP id q9so1565289ykb.19 for ; Thu, 14 Aug 2014 16:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=GZe4KZbncnlaVg+E5088CKFZ5//nOzOTLfmWqwFczEw=; b=C6UQTisUbElRidNUiebC8kHahZ3B1xv29RGfWkSGb/U+x/DSfHcWUItxtFEQFN0YF3 qg8Mu66vcYFyl5n1XCNDlTjEsQDc2Rq9SlXhLUaOiRccSILGPLMHRq6iy/OuTp0nPUh4 i6MCELYghHuKUOV95FNGBcR+axLt2v5qC7UF8/qaQBnQIpdWpipGfwxFRyMaEeb5u/5t DKvdk3amCOPd3kHgllqk1uaAd9Yq2L9hifj4MyhcPHI+5luwANOIaml5DKvOe478sK5v YWHBBSD1XRwtCE2LeryhhA6j4k1v5sxlTAgcSjUU3G8OkXy+qmm60DDH1zcZsRHdUOZH HYzQ== X-Received: by 10.236.148.209 with SMTP id v57mr21500334yhj.140.1408058300981; Thu, 14 Aug 2014 16:18:20 -0700 (PDT) Received: from memeplex ([190.18.155.203]) by mx.google.com with ESMTPSA id x48sm13679185yha.5.2014.08.14.16.18.17 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Aug 2014 16:18:19 -0700 (PDT) From: carlosjosepita@gmail.com Date: Thu, 14 Aug 2014 20:18:33 -0300 Message-ID: <87vbpu7j92.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) When the current major mode provides submenus (say, python-mode, with methods nested inside classes, classes being top-level), imenu always shows them at the top of the menu and unsorted. Only sibling leaves of the menu tree are sorted. To fix this, just sort the output of imenu--split submenus when a custom imenu-sort-function was required by the user: (defun imenu--split-submenus (alist) "Split up each long alist that are nested within ALIST into nested alists. Return a split and sorted copy of ALIST. The returned alist DOES NOT share structure with ALIST." (let ((menulist (mapcar (lambda (elt) (if (imenu--subalist-p elt) (imenu--split-menu (cdr elt) (car elt)) elt)) alist))) (if imenu-sort-function (sort menulist imenu-sort-function) menulist))) Regards -- Carlos In GNU Emacs 24.3.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2) of 2014-08-07 on memeplex Windowing system distributor `The X.Org Foundation', version 11.0.11600000 Configured using: `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong --param=ssp-buffer-size=4' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro' Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: shell-dirtrack-mode: t show-paren-mode: t winner-mode: t yas-global-mode: t yas-minor-mode: t ido-everywhere: t global-auto-complete-mode: t auto-complete-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t global-prettify-symbols-mode: t prettify-symbols-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-SPC C-w C-x C-s C-x d C-e ( r e q u i r e SPC ' i m e n u - a n y w h e e r r e ) C-x C-e C-e C-x C-e d x y e s C-x C-s C-x b s c ( r e q u i r e SPC ' f i x e s ) C-x C-e C-g C-x C-s M-x r e p o r t Recent messages: End of buffer [3 times] imenu-anywhere imenu--sort-by-name Deleting...done (No changes need to be saved) progn: Required feature `fixes' was not provided Quit Saving file /home/carlos/.emacs... Wrote /home/carlos/.emacs Making completion list... Load-path shadows: ~/.emacs.d/lisp/python hides /usr/share/emacs/24.3.92/lisp/progmodes/python ~/.emacs.d/lisp/rmail hides /usr/share/emacs/24.3.92/lisp/mail/rmail Features: (shadow sort mail-extr emacsbug message idna rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils debug mule-util tramp-cache tramp tramp-compat tramp-loaddefs trampver shell image-file org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view image-mode dired org-bibtex bibtex org-bbdb org-w3m org-capture org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities noutline outline easy-mmode org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs org-loaddefs format-spec cal-menu calendar cal-loaddefs edebug misearch multi-isearch jka-compr eieio-opt speedbar sb-image ezimage dframe network-stream auth-source eieio byte-opt bytecomp byte-compile cconv eieio-core gnus-util mm-util mail-prsvr password-cache starttls tls warnings vc-git jedi python-environment epc ctable concurrent deferred python skeleton derived pcase rx json imenu-anywhere cl-macs imenu thingatpt find-func flymake compile comint ansi-color paren winner ring windmove advice help-fns yasnippet help-mode cl gv ido auto-complete-config auto-complete popup edmacro kmacro cl-loaddefs cl-lib info easymenu package wombat-theme time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) Memory information: ((conses 16 361814 22370) (symbols 48 36390 0) (miscs 40 1153 1328) (strings 32 103033 9931) (string-bytes 1 2189271) (vectors 16 35814) (vector-slots 8 1446654 27798) (floats 8 665 911) (intervals 56 9261 0) (buffers 960 26) (heap 1024 67756 2517)) From unknown Sat Jun 21 05:14:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18268: References: <87vbpu7j92.fsf@gmail.com> In-Reply-To: <87vbpu7j92.fsf@gmail.com> Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Aug 2014 23:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18268 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18268@debbugs.gnu.org Received: via spool by 18268-submit@debbugs.gnu.org id=B18268.140806064617035 (code B ref 18268); Thu, 14 Aug 2014 23:58:01 +0000 Received: (at 18268) by debbugs.gnu.org; 14 Aug 2014 23:57:26 +0000 Received: from localhost ([127.0.0.1]:43707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XI4tZ-0004Qh-JU for submit@debbugs.gnu.org; Thu, 14 Aug 2014 19:57:25 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:34542) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XI4tX-0004QP-2k for 18268@debbugs.gnu.org; Thu, 14 Aug 2014 19:57:23 -0400 Received: by mail-wi0-f177.google.com with SMTP id ho1so193636wib.10 for <18268@debbugs.gnu.org>; Thu, 14 Aug 2014 16:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=v9L+NVjC+cgjCIH99nwQyRbRNw/iAwm5Lk/D+UDbMKw=; b=aJGDYqIsVQJ4ng1fs0VSh3KfwThlOcajE45LzhNV2KKIo+zv0sMLi5wdiehJzw6a2Y Ctuo2FO/ZXIr7EH2klkTONTQ3ZYV3+9V7zAmMM29J/qmyYM1VtsWerdmoYUaRE3Sz8Qy RF/gGSczL+D2posBFFURSAPiv5kCjiTU/e856r8xm5XLDs2oPhrcsUce5ZZx7i2GYLvV zKuk5Az6fsDsrC8QBzw14hp7IluHqMdMPdNjrjupedP/6cBmqDSwVeaIB6oT/XSuZiDr HGG5pgb6Lm+7bvkWvDCXq6oahpTFL30V6f4UfrLC4qG1TExmay83UQydEZv7uahxXpBL D8WA== X-Received: by 10.194.2.12 with SMTP id 12mr16190345wjq.54.1408060636985; Thu, 14 Aug 2014 16:57:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.217.68.197 with HTTP; Thu, 14 Aug 2014 16:56:56 -0700 (PDT) From: Carlos Pita Date: Thu, 14 Aug 2014 20:56:56 -0300 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Besides that, I see no point in the keep-at-top behaviour of imenu--split-menu, which pushes every submenu to the top of its parent menu. The user is looking for a name in a list sorted according to some required criterion. Splitting this list in two sorted lists in virtue of a totally different criterion will only bring confusion. It's ok to make this the default behaviour, in case the user isn't interested in any particular ordering (that is, imenu-sort-function is nil). But if a particular ordering is required, then it should be honoured. Or, at least, an option should be provided to turn off keep-at-top. [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (carlosjosepita[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.212.177 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Besides that, I see no point in the keep-at-top behaviour of imenu--split-menu, which pushes every submenu to the top of its parent menu. The user is looking for a name in a list sorted according to some required criterion. Splitting this list in two sorted lists in virtue of a totally different criterion will only bring confusion. It's ok to make this the default behaviour, in case the user isn't interested in any particular ordering (that is, imenu-sort-function is nil). But if a particular ordering is required, then it should be honoured. Or, at least, an option should be provided to turn off keep-at-top. [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.212.177 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (carlosjosepita[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Besides that, I see no point in the keep-at-top behaviour of imenu--split-menu, which pushes every submenu to the top of its parent menu. The user is looking for a name in a list sorted according to some required criterion. Splitting this list in two sorted lists in virtue of a totally different criterion will only bring confusion. It's ok to make this the default behaviour, in case the user isn't interested in any particular ordering (that is, imenu-sort-function is nil). But if a particular ordering is required, then it should be honoured. Or, at least, an option should be provided to turn off keep-at-top. If you agree I will gladly provide a patch. Regards -- Carlos From unknown Sat Jun 21 05:14:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18268: Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Aug 2014 15:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18268 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18268@debbugs.gnu.org Received: via spool by 18268-submit@debbugs.gnu.org id=B18268.140811594628561 (code B ref 18268); Fri, 15 Aug 2014 15:20:02 +0000 Received: (at 18268) by debbugs.gnu.org; 15 Aug 2014 15:19:06 +0000 Received: from localhost ([127.0.0.1]:44006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XIJHV-0007Qa-Py for submit@debbugs.gnu.org; Fri, 15 Aug 2014 11:19:06 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:55286) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XIJHS-0007Pt-UV for 18268@debbugs.gnu.org; Fri, 15 Aug 2014 11:19:04 -0400 Received: by mail-la0-f41.google.com with SMTP id s18so2445637lam.14 for <18268@debbugs.gnu.org>; Fri, 15 Aug 2014 08:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=SUAysZo1Z9eQUY0i1m/08xdNXb/TPblLuGT2Rt+PIoI=; b=KDL61PFdKuocAhPNvpw51U/bclAZ8orxLVvGOzYUurgEKxq0UlWQ0u3o1cjWWK0Hz9 0qATqFKzwsqIBV2meGe+ibZp0SrXJgSrtsM+B8sah+3jOpVv53MfQf607hLSrpFqAK50 itqAosjHXwbP7MIxl8WXWPwoiJBHQDbxPtpiLUS3ZGPazcPKtS2H4e0/L6Fl2AbSyQSX BnYvL9igeZZW6QEe3t9e4WB7ZysjZ3Cg5Ripz7p6TzGgmk+mZ+fqNXmv72LzoE/t5tBk ViMVP67eJpmRPgD8+Kys94WZxoY0D/6BLvrYSn/X/9EAjA7S9jjWVwSHqMvZn3qBXXLj UdJA== X-Received: by 10.112.181.74 with SMTP id du10mr11942538lbc.40.1408115936639; Fri, 15 Aug 2014 08:18:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.72.163 with HTTP; Fri, 15 Aug 2014 08:18:36 -0700 (PDT) In-Reply-To: References: From: Carlos Pita Date: Fri, 15 Aug 2014 12:18:36 -0300 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) The following is a simpler and more correct patch that also lets the user (final user or major mode developer) control whether the submenus are sorted or kept on top. The guiding idea is that there is two major ways to offer an imenu, according to the mode: 1) Some modes show a hierarchy of language objects. For example: python-mode will show class/method, function/nested function, etc. relationships; org-mode will show section/subsection/subsubsection/... hierarchies. In these cases keeping the submenus on top is not adequate since it creates an artificial split of the list. 2) Some modes show top level submenus with fixed categories (Functions, Classes, Variables, etc). These modes will presumably want to keep the submenus on top and sorted in the order they were given. 3) Other modes would not fit either (1) or (2). Then, there is always the possibility of turning off sorting and provide the menu structure as is. Regards -- Carlos 156a157,161 > (defcustom imenu-sort-submenus nil > "Non-nil means Imenu should sort submenus also (using imenu-sort-function)." > :type 'boolean > :group 'imenu) > 541c546,547 < (when (imenu--subalist-p item) --- > (when (and (not imenu-sort-submenus) > (imenu--subalist-p item)) On Thu, Aug 14, 2014 at 8:56 PM, Carlos Pita wrote: > Besides that, I see no point in the keep-at-top behaviour of > imenu--split-menu, which pushes every submenu to the top of its parent > menu. The user is looking for a name in a list sorted according to > some required criterion. Splitting this list in two sorted lists in > virtue of a totally different criterion will only bring confusion. > It's ok to make this the default behaviour, in case the user isn't > interested in any particular ordering (that is, imenu-sort-function is > nil). But if a particular ordering is required, then it should be > honoured. Or, at least, an option should be provided to turn off > keep-at-top. > > If you agree I will gladly provide a patch. > > Regards > -- > Carlos From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 25 13:57:25 2014 Received: (at control) by debbugs.gnu.org; 25 Nov 2014 18:57:25 +0000 Received: from localhost ([127.0.0.1]:45245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtLIj-0004G8-6o for submit@debbugs.gnu.org; Tue, 25 Nov 2014 13:57:25 -0500 Received: from mail-lb0-f170.google.com ([209.85.217.170]:48262) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XtLIg-0004G0-SL for control@debbugs.gnu.org; Tue, 25 Nov 2014 13:57:23 -0500 Received: by mail-lb0-f170.google.com with SMTP id w7so1156564lbi.1 for ; Tue, 25 Nov 2014 10:57:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=DwwoMmoLr2WLQ03IWmoBCHR0cklGdhsG1J0tq7QPwdU=; b=A1x0YW5yfz2B+O6EsoSLnCgRdrCKekXmQbvmq/zoQUFwIMgw6pmpmfaCMbfZ+9q998 MQo8JagdHivMfrxBBJWCFIowlE16iMikql4iolBf0Er/aDXXNLVg676KwVST9LggsPma 5x4rn3DO2715Wn/Ng2vPK3x49h3I7QCiqxHUEvVCq401onikpzHCa5pQRIHQ+RNbhALj /P+bJ99tHP5JVzPbKsoinlYiGl1MOKSdz0NxdPxL6cXOAyuAbeNwEdg6AUmb/5xWxkl8 hI65RhSiwqIrVhUEPpRLYAatR+/OiijrbhCRm4wbhCsR/qNpwacY5kEf1BFZpXk/7n/E ySGw== X-Received: by 10.152.88.44 with SMTP id bd12mr14402288lab.88.1416941841571; Tue, 25 Nov 2014 10:57:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.252.101 with HTTP; Tue, 25 Nov 2014 10:57:01 -0800 (PST) From: Carlos Pita Date: Tue, 25 Nov 2014 15:57:01 -0300 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 18268 patch [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (carlosjosepita[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.217.170 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 18268 patch [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.217.170 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (carlosjosepita[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid tags 18268 patch From unknown Sat Jun 21 05:14:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18268: Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Feb 2016 12:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18268 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Carlos Pita Cc: 18268@debbugs.gnu.org Received: via spool by 18268-submit@debbugs.gnu.org id=B18268.145623013331743 (code B ref 18268); Tue, 23 Feb 2016 12:23:01 +0000 Received: (at 18268) by debbugs.gnu.org; 23 Feb 2016 12:22:13 +0000 Received: from localhost ([127.0.0.1]:39423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYBym-0008Fv-P0 for submit@debbugs.gnu.org; Tue, 23 Feb 2016 07:22:12 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:35707) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYByk-0008Fm-Ix for 18268@debbugs.gnu.org; Tue, 23 Feb 2016 07:22:10 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYByN-0006Za-QO; Tue, 23 Feb 2016 13:21:48 +0100 From: Lars Ingebrigtsen References: Date: Tue, 23 Feb 2016 23:21:43 +1100 In-Reply-To: (Carlos Pita's message of "Fri, 15 Aug 2014 12:18:36 -0300") Message-ID: <87fuwjobvs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYByN-0006Za-QO X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456834908.9286@c72HQtbPRUzd5imn9H0Qow X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Carlos Pita writes: > The following is a simpler and more correct patch that also lets the > user (final user or major mode developer) control whether the submenus > are sorted or kept on top. The guiding idea is that there is two major > ways to offer an imenu, according to the mode: > > 1) Some modes show a hierarchy of language objects. For example: > python-mode will show class/method, function/nested function, etc. > relationships; org-mode will show section/subsection/subsubsection/... > hierarchies. In these cases keeping the submenus on top is not > adequate since it creates an artificial split of the list. > > 2) Some modes show top level submenus with fixed categories > (Functions, Classes, Variables, etc). These modes will presumably want > to keep the submenus on top and sorted in the order they were given. > > 3) Other modes would not fit either (1) or (2). Then, there is always > the possibility of turning off sorting and provide the menu structure > as is. > > Regards > -- > Carlos > > 156a157,161 >> (defcustom imenu-sort-submenus nil >> "Non-nil means Imenu should sort submenus also (using imenu-sort-function)." >> :type 'boolean >> :group 'imenu) Could you resubmit this as a context patch instead of a "raw" patch? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Jun 21 05:14:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18268: Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18268 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Carlos Pita Cc: 18268@debbugs.gnu.org Received: via spool by 18268-submit@debbugs.gnu.org id=B18268.156149914811468 (code B ref 18268); Tue, 25 Jun 2019 21:46:02 +0000 Received: (at 18268) by debbugs.gnu.org; 25 Jun 2019 21:45:48 +0000 Received: from localhost ([127.0.0.1]:33747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hftG7-0002y9-5U for submit@debbugs.gnu.org; Tue, 25 Jun 2019 17:45:48 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hftG4-0002vK-OP for 18268@debbugs.gnu.org; Tue, 25 Jun 2019 17:45:45 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hftFz-0004jy-BL; Tue, 25 Jun 2019 23:45:43 +0200 From: Lars Ingebrigtsen References: <87fuwjobvs.fsf@gnus.org> Date: Tue, 25 Jun 2019 23:45:39 +0200 In-Reply-To: <87fuwjobvs.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 23 Feb 2016 23:21:43 +1100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Could you resubmit this as a context patch instead of a "raw" patch? That was three years ago, so I'm closing this bug report. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Could you resubmit this as a context patch instead of a "raw" patch? That was three years ago, so I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 17:45:54 2019 Received: (at control) by debbugs.gnu.org; 25 Jun 2019 21:45:54 +0000 Received: from localhost ([127.0.0.1]:33750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hftGE-00034D-89 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 17:45:54 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hftGC-00032B-BG for control@debbugs.gnu.org; Tue, 25 Jun 2019 17:45:52 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hftG9-0004k8-Fb for control@debbugs.gnu.org; Tue, 25 Jun 2019 23:45:51 +0200 Date: Tue, 25 Jun 2019 23:45:49 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #18268 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 18268 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 18268 quit