From unknown Fri Jun 20 07:21:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18250 <18250@debbugs.gnu.org> To: bug#18250 <18250@debbugs.gnu.org> Subject: Status: 24.3; ERC display commands in current buffer Reply-To: bug#18250 <18250@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:21:45 +0000 retitle 18250 24.3; ERC display commands in current buffer reassign 18250 emacs submitter 18250 Kelvin White severity 18250 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 12 09:03:57 2014 Received: (at submit) by debbugs.gnu.org; 12 Aug 2014 13:03:57 +0000 Received: from localhost ([127.0.0.1]:40200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XHBk5-0006eh-Ii for submit@debbugs.gnu.org; Tue, 12 Aug 2014 09:03:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59147) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XHBk3-0006eU-DS for submit@debbugs.gnu.org; Tue, 12 Aug 2014 09:03:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHBju-0003R4-28 for submit@debbugs.gnu.org; Tue, 12 Aug 2014 09:03:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHBjt-0003Qz-V8 for submit@debbugs.gnu.org; Tue, 12 Aug 2014 09:03:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHBjs-0003fn-Lc for bug-gnu-emacs@gnu.org; Tue, 12 Aug 2014 09:03:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHBjr-0003Qa-CQ for bug-gnu-emacs@gnu.org; Tue, 12 Aug 2014 09:03:44 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHBjr-0003QW-8g for bug-gnu-emacs@gnu.org; Tue, 12 Aug 2014 09:03:43 -0400 Received: from [2600:3c02::f03c:91ff:fe73:3fa6] (port=45029 helo=localhost.gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1XHBjr-000317-0I for bug-gnu-emacs@gnu.org; Tue, 12 Aug 2014 09:03:43 -0400 Date: Tue, 12 Aug 2014 09:03:41 -0400 Message-ID: <87y4uthnbm.wl%kwhite@gnu.org> From: Kelvin White To: bug-gnu-emacs@gnu.org Subject: 24.3; ERC display commands in current buffer User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Currently ERC will insert irc commands into the current buffer. I find this annoying for a couple of reasons and wanted some feedback on this behavior before going further. IMO it unneccesarily clutters up the buffer and in some cases contains sensitive information you may not want others to see, and may potentially even be logged. For example, if this was an /oper command or a command to identify to nickserv it would contain a password, if logging was enabled then it would be written in the logs. So, I came up with a simple patch... === modified file 'lisp/erc/erc.el' --- lisp/erc/erc.el 2014-08-07 16:44:19 +0000 +++ lisp/erc/erc.el 2014-08-12 12:48:29 +0000 @@ -5377,8 +5377,9 @@ (or (and erc-flood-protect (erc-split-line line)) (list line)))) (split-string str "\n")) - ;; Insert the prompt along with the command. - (erc-display-command str) + ;; Don't insert commands in buffer + (unless (string-match "^/" str) + (erc-display-command str)) (erc-process-input-line (concat str "\n") t nil)) t))))) ...but by doing this I realized that the function `erc-display-command' exists solely to display commands in the current buffer. Completely removing the call to `erc-display-command' in `erc-send-input' may be a better option. Anyone have any thoughts or suggestions? From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 07:58:47 2015 Received: (at 18250-done) by debbugs.gnu.org; 14 May 2015 11:58:47 +0000 Received: from localhost ([127.0.0.1]:44507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ysrmo-0000Kz-Iy for submit@debbugs.gnu.org; Thu, 14 May 2015 07:58:47 -0400 Received: from mail-qc0-f180.google.com ([209.85.216.180]:36316) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ysrmm-0000Kl-K9 for 18250-done@debbugs.gnu.org; Thu, 14 May 2015 07:58:44 -0400 Received: by qcbgy10 with SMTP id gy10so37696415qcb.3 for <18250-done@debbugs.gnu.org>; Thu, 14 May 2015 04:58:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-type; bh=J3W5rtxKYBaOf2rlJFxNhoYb4plHLl9HDwyzAQAfVdQ=; b=No+e+s8iPnslCYf0r/ry2idCxXNXC/+8LYktpue2ZwfDhxRaRUpF4HxDz8ZX/v52KX TOPuULtl3+99np98z5SjQfJ9TWB80ovxWh6gp/129EkMbK9faVBcQdgsXfsuhtxhNXR0 9X3SPgRatfwz34f8YL3ek7mZqpicxi7j2bgvJymaq9OMv/3v9LQGpc1riPKNpla60CY8 S+Zir/3+zbtYkaDxrJ9QduGwWRNVlYkvwE7JK542acFFrM7iG/WP4iONHOlUkLETpnxU vW/SbDPP+p4Glqmy99i1sRRSBGAvQXwtNhNH/mDO9JHYOVRXCeHjVbpOLUSTZK+kPRWo lqDg== X-Received: by 10.140.151.75 with SMTP id 72mr4940872qhx.89.1431604718874; Thu, 14 May 2015 04:58:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kelvin White Date: Thu, 14 May 2015 11:58:38 +0000 Message-ID: Subject: bug #18250 To: 18250-done@debbugs.gnu.org Content-Type: multipart/alternative; boundary=001a11355544ba35f0051609720f X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 18250-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --001a11355544ba35f0051609720f Content-Type: text/plain; charset=UTF-8 closed. --001a11355544ba35f0051609720f Content-Type: text/html; charset=UTF-8
closed.
--001a11355544ba35f0051609720f-- From unknown Fri Jun 20 07:21:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 12 Jun 2015 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator