GNU bug report logs - #18250
24.3; ERC display commands in current buffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18250 in the body.
You can then email your comments to 18250 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kelvin White <kwhite <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; ERC display commands in current buffer
Date: Tue, 12 Aug 2014 09:03:41 -0400

Currently ERC will insert irc commands into the current buffer. I find
this annoying for a couple of reasons and wanted some feedback on this
behavior before going further. IMO it unneccesarily clutters up the
buffer and in some cases contains sensitive information you may not
want others to see, and may potentially even be logged. For example,
if this was an /oper command or a command to identify to nickserv it
would contain a password, if logging was enabled then it would be
written in the logs. So, I came up with a simple patch...

=== modified file 'lisp/erc/erc.el'
--- lisp/erc/erc.el     2014-08-07 16:44:19 +0000
+++ lisp/erc/erc.el     2014-08-12 12:48:29 +0000
@@ -5377,8 +5377,9 @@
                 (or (and erc-flood-protect (erc-split-line line))
                     (list line))))
              (split-string str "\n"))
-          ;; Insert the prompt along with the command.
-          (erc-display-command str)
+          ;; Don't insert commands in buffer
+            (unless (string-match "^/" str)
+                (erc-display-command str))
           (erc-process-input-line (concat str "\n") t nil))
         t)))))

...but by doing this I realized that the function
`erc-display-command' exists solely to display commands in the current
buffer. Completely removing the call to `erc-display-command' in `erc-send-input'
may be a better option. Anyone have any thoughts or suggestions?

Message #10 received at 18250-done <at> debbugs.gnu.org (full text, mbox):

From: Kelvin White <kwhite <at> gnu.org>
To: 18250-done <at> debbugs.gnu.org
Subject: bug #18250
Date: Thu, 14 May 2015 11:58:38 +0000

[Message part 1 (text/plain, inline)]

closed.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.