GNU bug report logs - #18245
[master branch] Useless imported module cause strange problem

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18245 in the body.
You can then email your comments to 18245 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nala Ginrut <nalaginrut <at> gmail.com>
To: bug-guile <at> gnu.org
Subject: [master branch] Useless imported module cause strange problem
Date: Mon, 11 Aug 2014 17:14:48 +0800

[Message part 1 (text/plain, inline)]

Note this bug is under Master branch, it's fine in stable-2.0.


I've imported srfi-1, but after some modifications, the program happens
not to use any srfi-1 symbols, then there's the problem that one of the
rule in syntax-rules can't be found and threw error.
It works when I removed useless srfi-1 from imported list.


I think srfi-1 here is not related, and maybe the same with
syntax-rules. But I can reproduce it with these two prerequisites.


I've attached two simplified files(modules) for reproducing.
(The code may look not so nice, but it's unrelated, some code looks ugly
because of the simplification from my project)

[mmr.scm (text/x-scheme, attachment)]

[mmr2.scm (text/x-scheme, attachment)]

Message #8 received at 18245 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Nala Ginrut <nalaginrut <at> gmail.com>
Cc: 18245 <at> debbugs.gnu.org, request <at> debbugs.gnu.org
Subject: Re: bug#18245: [master branch] Useless imported module cause strange
 problem
Date: Mon, 11 Aug 2014 11:30:32 -0400

tags 18245 notabug
close 18245
thanks

Nala Ginrut <nalaginrut <at> gmail.com> writes:
> I've imported srfi-1, but after some modifications, the program happens
> not to use any srfi-1 symbols, then there's the problem that one of the
> rule in syntax-rules can't be found and threw error.
> It works when I removed useless srfi-1 from imported list.

The problem is that srfi-1 exports a 'drop' procedure, and 'drop' is
also used as a syntax-rules literal in your macros.  Literals are
matched as follows: if the literal identifier has the same name and the
same binding where the macro is defined and where it is used, then
there's a match.  If the identifier is not bound in either place, then
there's also a match.

However, in this case 'drop' is not defined where the 'sql-alter' macro
is defined, but it _is_ defined to a procedure in srfi-1 in your example
module where it is used.  Therefore, the macro does not consider the
'drop' to be a match for the literal it's looking for.

This is similar to the issue that if you define 'else' to be something
in a module (or import it from somewhere), then 'else' will no longer
have its special meaning in a 'cond' form.  Ditto for '=>'.

There is some question about whether these rules for matches literals
are the best ones, and the issue has been debated during the R7RS
standardization process, but nonetheless the standards are clear on this
matter.

I recommend choosing literals that are not likely to be bound in modules
that use your sql macros.

I'm closing this.

     Regards,
       Mark

Message #15 received at 18245 <at> debbugs.gnu.org (full text, mbox):

From: Nala Ginrut <nalaginrut <at> gmail.com>
To: Mark H Weaver <mhw <at> netris.org>
Cc: 18245 <at> debbugs.gnu.org, request <at> debbugs.gnu.org
Subject: Re: bug#18245: [master branch] Useless imported module cause strange
 problem
Date: Tue, 12 Aug 2014 09:46:47 +0800

[Message part 1 (text/plain, inline)]

2014年8月11日 下午11:31于 "Mark H Weaver" <mhw <at> netris.org>写道：
>
> tags 18245 notabug
> close 18245
> thanks
>

> The problem is that srfi-1 exports a 'drop' procedure, and 'drop' is
> also used as a syntax-rules literal in your macros.  Literals are
> matched as follows: if the literal identifier has the same name and the
> same binding where the macro is defined and where it is used, then
> there's a match.  If the identifier is not bound in either place, then
> there's also a match.
>

Thanks for explaining!
The issue can't be reproduced in stable-2.0, so I suspected it's a
potential bug.

>
> I recommend choosing literals that are not likely to be bound in modules
> that use your sql macros.
>

Or import srfi-1 with a proper prefix :-)

Thanks!

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.