From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 12:47:29 2014 Received: (at submit) by debbugs.gnu.org; 10 Aug 2014 16:47:29 +0000 Received: from localhost ([127.0.0.1]:37889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGWHI-0007h5-IW for submit@debbugs.gnu.org; Sun, 10 Aug 2014 12:47:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59824) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGWHF-0007gr-1i for submit@debbugs.gnu.org; Sun, 10 Aug 2014 12:47:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGWH8-00029x-9O for submit@debbugs.gnu.org; Sun, 10 Aug 2014 12:47:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGWH8-00029t-5w for submit@debbugs.gnu.org; Sun, 10 Aug 2014 12:47:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGWH6-0000On-C9 for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 12:47:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGWH5-000295-A0 for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 12:47:16 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGWH5-000291-6l for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 12:47:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57457) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1XGWH4-0008Oy-Tz for bug-emacs@gnu.org; Sun, 10 Aug 2014 12:47:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGWH3-00028n-KO for bug-emacs@gnu.org; Sun, 10 Aug 2014 12:47:14 -0400 Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:44387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGWH3-00028b-7F for bug-emacs@gnu.org; Sun, 10 Aug 2014 12:47:13 -0400 Received: by mail-la0-f52.google.com with SMTP id b17so4896148lan.39 for ; Sun, 10 Aug 2014 09:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:date:message-id:subject:from:to:content-type; bh=4ZWbwTOwk4RpcgWYdE6l2t+sDWI/N5YcV/2FkZub7Rk=; b=kLiE3w7NWX+xiN+a1imhNhmwJ5N+H1h1ohPdp9ho1vmMGKNVhXBJ58wTgDMAToOwrF tdtntoMXkV3VX3MrDUUrH6SRhn0OHqDRg+jA5wdf2SQgDuyUB/icpIyAiZaqaNBs0/xe etJ3P6aKCRhMEMglTXZm/+rzti4+Oj+3JAGqo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=4ZWbwTOwk4RpcgWYdE6l2t+sDWI/N5YcV/2FkZub7Rk=; b=j4vJXaEiWlOLhx+TxLKBX7cY+9AcCkQg+wxdlq7r33jyAv0/oyHeggFSSHHcoJVdWX DJwj/CSukmqRdEihQvaJ5+1ayRVYY4SUriIJxH//LFygKbxe3G7aGBLEh5RYL2II16Nr l7PGnbJMw5GzIb5PUb0c37dF3B//11502Vxa5Yz84XJ4ej20K2qk8TgaPYTR/ZoEGnZC +4qzEc/YVPqS07158FtZIwoI/15s6ngBqlpSOhoc0yict1BQEht6NPdvZ6N/I/qAExJL qXdfZ+yt+XtqqqxDXiD0Pp7Jm8DCDHcEZPMLeZoYEtYeiChZvwoPeVK4fvttLI4zbvYl uuLw== X-Gm-Message-State: ALoCoQn8Ap+MXk3GyVbmlRi7pLhzPtcqmFMdgkfzxc1WmyGDAEvwqhzzRcQzn0y56uxO8o+6LTky MIME-Version: 1.0 X-Received: by 10.152.164.229 with SMTP id yt5mr2941072lab.19.1407689231708; Sun, 10 Aug 2014 09:47:11 -0700 (PDT) Received: by 10.152.246.10 with HTTP; Sun, 10 Aug 2014 09:47:11 -0700 (PDT) Date: Sun, 10 Aug 2014 17:47:11 +0100 Message-ID: Subject: Fix for DOS build when using more accurate config[.h].in From: Reuben Thomas To: bug-emacs Content-Type: multipart/alternative; boundary=001a1133a8d89c4f6705004930e0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --001a1133a8d89c4f6705004930e0 Content-Type: text/plain; charset=UTF-8 DJGPP does actually have getrlimit. The special config[.h].in for MSDOS lies and says it hasn't. However, this is a white lie, because getrlimit on DJGPP doesn't support RLIMIT_AS/RLIMIT_DATA, which is what we want, so we still want the workaround code. The following patch simply reverses the order of a couple of tests in vm-limit.c so that being on MSDOS overrides HAVE_GETRLIMIT. Is it OK to install? === modified file 'src/vm-limit.c' --- src/vm-limit.c 2014-07-11 10:09:51 +0000 +++ src/vm-limit.c 2014-08-10 16:44:24 +0000 @@ -71,7 +71,27 @@ /* Number of bytes of writable memory we can expect to be able to get. */ static size_t lim_data; -#ifdef HAVE_GETRLIMIT +#ifdef MSDOS + +void +get_lim_data (void) +{ + unsigned long totalram, freeram, totalswap, freeswap; + + dos_memory_info (&totalram, &freeram, &totalswap, &freeswap); + lim_data = freeram; + /* Don't believe they will give us more that 0.5 GB. */ + if (lim_data > 512U * 1024U * 1024U) + lim_data = 512U * 1024U * 1024U; +} + +unsigned long +ret_lim_data (void) +{ + get_lim_data (); + return lim_data; +} +#elif defined HAVE_GETRLIMIT # ifndef RLIMIT_AS # define RLIMIT_AS RLIMIT_DATA @@ -101,26 +121,6 @@ lim_data = reserved_heap_size; } -#elif defined MSDOS - -void -get_lim_data (void) -{ - unsigned long totalram, freeram, totalswap, freeswap; - - dos_memory_info (&totalram, &freeram, &totalswap, &freeswap); - lim_data = freeram; - /* Don't believe they will give us more that 0.5 GB. */ - if (lim_data > 512U * 1024U * 1024U) - lim_data = 512U * 1024U * 1024U; -} - -unsigned long -ret_lim_data (void) -{ - get_lim_data (); - return lim_data; -} #else # error "get_lim_data not implemented on this machine" #endif -- http://rrt.sc3d.org --001a1133a8d89c4f6705004930e0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
DJGPP does actually have getrlimit. The special confi= g[.h].in for MSDOS lies and says it hasn't. However, this is a white li= e, because getrlimit on DJGPP doesn't support RLIMIT_AS/RLIMIT_DATA, wh= ich is what we want, so we still want the workaround code. The following pa= tch simply reverses the order of a couple of tests in vm-limit.c so that be= ing on MSDOS overrides HAVE_GETRLIMIT.

Is it OK to install?

=3D=3D=3D mod= ified file 'src/vm-limit.c'
--- src/vm-limit.c=C2=A0=C2=A0=C2=A0= 2014-07-11 10:09:51 +0000
+++ src/vm-limit.c=C2=A0=C2=A0=C2=A0 2014-08-= 10 16:44:24 +0000
@@ -71,7 +71,27 @@
=C2=A0/* Number of bytes of writable memory we can expect to be able to get= .=C2=A0 */
=C2=A0static size_t lim_data;
=C2=A0

-#ifdef HAVE_G= ETRLIMIT
+#ifdef MSDOS
+
+void
+get_lim_data (void)
+{
+= =C2=A0 unsigned long totalram, freeram, totalswap, freeswap;
+
+=C2=A0 dos_memory_info (&totalram, &freeram, &totalswap, = &freeswap);
+=C2=A0 lim_data =3D freeram;
+=C2=A0 /* Don't be= lieve they will give us more that 0.5 GB.=C2=A0=C2=A0 */
+=C2=A0 if (lim= _data > 512U * 1024U * 1024U)
+=C2=A0=C2=A0=C2=A0 lim_data =3D 512U * 1024U * 1024U;
+}
+
+unsig= ned long
+ret_lim_data (void)
+{
+=C2=A0 get_lim_data ();
+=C2= =A0 return lim_data;
+}
+#elif defined HAVE_GETRLIMIT
=C2=A0
= =C2=A0# ifndef RLIMIT_AS
=C2=A0#=C2=A0 define RLIMIT_AS RLIMIT_DATA
@@ -101,26 +121,6 @@
=C2=A0=C2=A0 lim_data =3D reserved_heap_size;
= =C2=A0}
=C2=A0
-#elif defined MSDOS
-
-void
-get_lim_data (v= oid)
-{
-=C2=A0 unsigned long totalram, freeram, totalswap, freeswap;=
-
-=C2=A0 dos_memory_info (&totalram, &freeram, &totalsw= ap, &freeswap);
-=C2=A0 lim_data =3D freeram;
-=C2=A0 /* Don't believe they will giv= e us more that 0.5 GB.=C2=A0=C2=A0 */
-=C2=A0 if (lim_data > 512U * 1= 024U * 1024U)
-=C2=A0=C2=A0=C2=A0 lim_data =3D 512U * 1024U * 1024U;
= -}
-
-unsigned long
-ret_lim_data (void)
-{
-=C2=A0 get_lim_data ();
-=C2=A0 return lim_data;
-}
=C2=A0#= else
=C2=A0# error "get_lim_data not implemented on this machine&qu= ot;
=C2=A0#endif

--
http://rr= t.sc3d.org
--001a1133a8d89c4f6705004930e0-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 12:52:12 2014 Received: (at 18238) by debbugs.gnu.org; 10 Aug 2014 16:52:12 +0000 Received: from localhost ([127.0.0.1]:37906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGWLr-0007pz-PM for submit@debbugs.gnu.org; Sun, 10 Aug 2014 12:52:12 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:35190) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGWLp-0007pq-1T for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 12:52:10 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3hWRDR3plKz3hjNP; Sun, 10 Aug 2014 18:52:06 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3hWRDQ4LNYz7S6S8; Sun, 10 Aug 2014 18:52:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id h3nVOpk2hNEw; Sun, 10 Aug 2014 18:52:05 +0200 (CEST) X-Auth-Info: MT8mwwTdRniiVqh76YODkvsez0lTILc+E5p4gjskkDg= Received: from igel.home (ppp-188-174-153-147.dynamic.mnet-online.de [188.174.153.147]) by mail.mnet-online.de (Postfix) with ESMTPA; Sun, 10 Aug 2014 18:52:05 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 85FE92C19D1; Sun, 10 Aug 2014 18:52:05 +0200 (CEST) From: Andreas Schwab To: Reuben Thomas Subject: Re: bug#18238: Fix for DOS build when using more accurate config[.h].in References: X-Yow: I feel like a wet parking meter on Darvon! Date: Sun, 10 Aug 2014 18:52:05 +0200 In-Reply-To: (Reuben Thomas's message of "Sun, 10 Aug 2014 17:47:11 +0100") Message-ID: <87vbq02sp6.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18238 Cc: 18238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Reuben Thomas writes: > + /* Don't believe they will give us more that 0.5 GB. */ s/that/than/ Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 12:53:32 2014 Received: (at 18238) by debbugs.gnu.org; 10 Aug 2014 16:53:32 +0000 Received: from localhost ([127.0.0.1]:37911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGWN9-0007sH-Gx for submit@debbugs.gnu.org; Sun, 10 Aug 2014 12:53:31 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:43088) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGWN6-0007s2-5v for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 12:53:28 -0400 Received: by mail-lb0-f180.google.com with SMTP id v6so5218490lbi.11 for <18238@debbugs.gnu.org>; Sun, 10 Aug 2014 09:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=0ibN7kQ5bS16Ijs4QpFseP3R2oQCDejkI1CO9xe/k0s=; b=TmHYprOJ+qUCnNuUH43p9ZP5CSqR3DGL7pvFt4LST3hVeUU4avg0MkkPNy0tuUnJet 25Tn+IlAlap0hKxz5XOb0itj7wJ6CL7oCJfbBRIILL1jOn2eWwpPWLc1lJueC2pQwhFr JkdRuc6+ZDmFTV08DLCRm2NQlLm7zTYZtCvIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=0ibN7kQ5bS16Ijs4QpFseP3R2oQCDejkI1CO9xe/k0s=; b=KYUvkB3RH7MJNG/UiG7Ia+6SGy4Mm5az4Yp+2YSKWmEX/wdwGWyNs/PfF+wOenBGlr TN6BDhYQqVEcvmdxT/vStRXdT8v7uo65G1jbjWifjv8zjzgIcjCor7jZbi/JzBb5/y4B yEm030pmLc24hFYW/AS5oAM19Hmh5Fqkvth4FSdg9e8R/G/dHwihU3WyGFx5RaYC46zQ lwQWjpfc8ab7z901KimOV9P/K23qCB6vDI7KSQtnfneNV5yk4YSKnQuzwguMaX5YU2Fw gyjaWOVM2bKY1WbW2Q4OuGd1HqQGn7GLL8Ee3t68gDSYrlo99iVMvOb2vMkeewTP4YXw RKxA== X-Gm-Message-State: ALoCoQmO8EYkeeUbl6/DkmU3U2romv9rzM+TpIKdt0Q5FoJ53PhrA3Q6VNTzvoaoXkgAcN3PGeFC MIME-Version: 1.0 X-Received: by 10.112.166.2 with SMTP id zc2mr2863228lbb.98.1407689601732; Sun, 10 Aug 2014 09:53:21 -0700 (PDT) Received: by 10.152.246.10 with HTTP; Sun, 10 Aug 2014 09:53:21 -0700 (PDT) In-Reply-To: <87vbq02sp6.fsf@igel.home> References: <87vbq02sp6.fsf@igel.home> Date: Sun, 10 Aug 2014 17:53:21 +0100 Message-ID: Subject: Re: bug#18238: Fix for DOS build when using more accurate config[.h].in From: Reuben Thomas To: Andreas Schwab Content-Type: multipart/alternative; boundary=001a11c383bcaa6923050049469a X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18238 Cc: 18238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c383bcaa6923050049469a Content-Type: text/plain; charset=UTF-8 On 10 August 2014 17:52, Andreas Schwab wrote: > Reuben Thomas writes: > > > + /* Don't believe they will give us more that 0.5 GB. */ > > s/that/than/ > Thanks, I guess I can fix such a trivial typo in the same commit, rather than in a separate one? -- http://rrt.sc3d.org --001a11c383bcaa6923050049469a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 1= 0 August 2014 17:52, Andreas Schwab <schwab@linux-m68k.org> wrote:
Reuben Thomas <rrt@sc3d.org> writes:

> + =C2=A0/* Don't believe they will give us more that 0.5 GB. =C2= =A0 */

s/that/than/

Thanks, I guess I can fix = such a trivial typo in the same commit, rather than in a separate one?

--
http://rrt.sc3d.org
--001a11c383bcaa6923050049469a-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 13:59:21 2014 Received: (at 18238) by debbugs.gnu.org; 10 Aug 2014 17:59:21 +0000 Received: from localhost ([127.0.0.1]:37928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXOr-00010K-5f for submit@debbugs.gnu.org; Sun, 10 Aug 2014 13:59:21 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:25232) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXOo-000102-Pn for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 13:59:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPAqyKr/2dsb2JhbABZgwaDSsAzCoEXF3SCJgEBBFYjEAsOJhIUGA0kiAzSGReOegeEOASrA4NMIQ X-IPAS-Result: ArYGAIDvNVPAqyKr/2dsb2JhbABZgwaDSsAzCoEXF3SCJgEBBFYjEAsOJhIUGA0kiAzSGReOegeEOASrA4NMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="84349448" Received: from 192-171-34-171.cpe.pppoe.ca (HELO pastel.home) ([192.171.34.171]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 10 Aug 2014 13:59:12 -0400 Received: by pastel.home (Postfix, from userid 20848) id 4667E605FD; Sun, 10 Aug 2014 13:59:12 -0400 (EDT) From: Stefan Monnier To: Reuben Thomas Subject: Re: bug#18238: Fix for DOS build when using more accurate config[.h].in Message-ID: References: Date: Sun, 10 Aug 2014 13:59:12 -0400 In-Reply-To: (Reuben Thomas's message of "Sun, 10 Aug 2014 17:47:11 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18238 Cc: 18238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > -#ifdef HAVE_GETRLIMIT > +#ifdef MSDOS Please add a comment here with your explanation about how DJGPP does have getrlimit but it's not good enough. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 14:05:35 2014 Received: (at 18238) by debbugs.gnu.org; 10 Aug 2014 18:05:35 +0000 Received: from localhost ([127.0.0.1]:37946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXUs-0001C7-Or for submit@debbugs.gnu.org; Sun, 10 Aug 2014 14:05:35 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:57082) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXUp-0001Bo-0d for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 14:05:31 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NA300200R1DY200@a-mtaout21.012.net.il> for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 21:05:24 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NA3002LDRL0VD80@a-mtaout21.012.net.il>; Sun, 10 Aug 2014 21:05:24 +0300 (IDT) Date: Sun, 10 Aug 2014 21:05:17 +0300 From: Eli Zaretskii Subject: Re: bug#18238: Fix for DOS build when using more accurate config[.h].in In-reply-to: X-012-Sender: halo1@inter.net.il To: Reuben Thomas Message-id: <83lhqwjk4i.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 18238 Cc: 18238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 10 Aug 2014 17:47:11 +0100 > From: Reuben Thomas > > DJGPP does actually have getrlimit. The special config[.h].in for MSDOS > lies and says it hasn't. However, this is a white lie, because getrlimit on > DJGPP doesn't support RLIMIT_AS/RLIMIT_DATA, which is what we want, so we > still want the workaround code. The following patch simply reverses the > order of a couple of tests in vm-limit.c so that being on MSDOS overrides > HAVE_GETRLIMIT. > > Is it OK to install? I don't see why the suggested code is better than the existing one. HAVE_GETRLIMIT means more than its name says, as you point out, so DJGPP is correct in not defining one. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 14:20:58 2014 Received: (at 18238) by debbugs.gnu.org; 10 Aug 2014 18:20:58 +0000 Received: from localhost ([127.0.0.1]:37955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXjl-0001ZC-Fg for submit@debbugs.gnu.org; Sun, 10 Aug 2014 14:20:57 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:46723) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXji-0001Yy-GJ for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 14:20:55 -0400 Received: by mail-la0-f52.google.com with SMTP id b17so4884252lan.25 for <18238@debbugs.gnu.org>; Sun, 10 Aug 2014 11:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=NNIwK9o9n0Bk3ljrojLvkvrEezNdGPDYzv6r6kBXU/o=; b=wiMrwLa3vXE8tdAZEYgkv2j+M75eTWtd2HtIMFNeenUlhahHfTD7KLMyPPf0UOrdJX JewHViGvLlviV+dbzcSCD+CrfHiEBh6NLsBcrVw1mylYDETL1k0DcK34tsSzTeEAiSzH cBb2mV/pHgJqyjkbdrLoTshPpJX1c9UvGAGxY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=NNIwK9o9n0Bk3ljrojLvkvrEezNdGPDYzv6r6kBXU/o=; b=Kh0tKXNqsJ0xRsU9yvnDHjbux9mdauKDCmFaZGN2uXgWhB3QG6oyusDSqNlJ9/wD1i AQxMKAx7c1A+/qrndZYslsf1c1xRz6uh5XBad5CxCXKLGr+FpsYsOajmK/9gXuquMhrL 5/eyHefr+b3nwGMEba0iqqiyTjfmAnbbjwM7GLDGOC6+Il37ZljU9I/v7hApPaQEb5cu IB9rRenUrzuRvgWMzUM09te2mZFbW+QH+aw0Th8qYvwP+CPLX5Hs6n/LakXtZ7i9A2aJ qYt7g3J3ac0h4xu11iF2/VWza1GUYbcOmWUB6chUSBhIfUneyk7kA/9qOasPMcC9CUi+ hIqg== X-Gm-Message-State: ALoCoQnUd7yzHGzydFKsDLvnZ190YrY3m6DdvsSunbq70VqrVKGDJU2EKUYLEdg9BZ6e9u9HXvW1 MIME-Version: 1.0 X-Received: by 10.152.234.71 with SMTP id uc7mr33978533lac.22.1407694848440; Sun, 10 Aug 2014 11:20:48 -0700 (PDT) Received: by 10.152.246.10 with HTTP; Sun, 10 Aug 2014 11:20:48 -0700 (PDT) In-Reply-To: <83lhqwjk4i.fsf@gnu.org> References: <83lhqwjk4i.fsf@gnu.org> Date: Sun, 10 Aug 2014 19:20:48 +0100 Message-ID: Subject: Re: bug#18238: Fix for DOS build when using more accurate config[.h].in From: Reuben Thomas To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a113422aa64d31b05004a7fbd X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18238 Cc: 18238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113422aa64d31b05004a7fbd Content-Type: text/plain; charset=UTF-8 On 10 August 2014 19:05, Eli Zaretskii wrote: > > Date: Sun, 10 Aug 2014 17:47:11 +0100 > > From: Reuben Thomas > > > > DJGPP does actually have getrlimit. The special config[.h].in for MSDOS > > lies and says it hasn't. However, this is a white lie, because getrlimit > on > > DJGPP doesn't support RLIMIT_AS/RLIMIT_DATA, which is what we want, so we > > still want the workaround code. The following patch simply reverses the > > order of a couple of tests in vm-limit.c so that being on MSDOS overrides > > HAVE_GETRLIMIT. > > > > Is it OK to install? > > I don't see why the suggested code is better than the existing one. > HAVE_GETRLIMIT means more than its name says, as you point out, so > DJGPP is correct in not defining one. > I think I was unclear, sorry: DJGPP does define getrlimit. It is only the MSDOS config.in that says it is not defined. If you run ./configure, then it detects getrlimit, and defines HAVE_GETRLIMIT. -- http://rrt.sc3d.org --001a113422aa64d31b05004a7fbd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 1= 0 August 2014 19:05, Eli Zaretskii <eliz@gnu.org> wrote:
> Date: Sun, 10 Aug 2014 17:47:11 +0100
> From: Reuben Thomas <rrt@sc3d.org>
>
> DJGPP does actually have getrlimit. The special config[.h].in for MSDO= S
> lies and says it hasn't. However, this is a white lie, because get= rlimit on
> DJGPP doesn't support RLIMIT_AS/RLIMIT_DATA, which is what we want= , so we
> still want the workaround code. The following patch simply reverses th= e
> order of a couple of tests in vm-limit.c so that being on MSDOS overri= des
> HAVE_GETRLIMIT.
>
> Is it OK to install?

I don't see why the suggested code is better than the existing one.
HAVE_GETRLIMIT means more than its name says, as you point out, so
DJGPP is correct in not defining one.

I think I was uncle= ar, sorry: DJGPP does define getrlimit. It is only the MSDOS config.in that says it is not defined. If you run ./conf= igure, then it detects getrlimit, and defines HAVE_GETRLIMIT.

--
http://rrt.sc3d.org
--001a113422aa64d31b05004a7fbd-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 14:28:50 2014 Received: (at 18238) by debbugs.gnu.org; 10 Aug 2014 18:28:50 +0000 Received: from localhost ([127.0.0.1]:37963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXrO-0001lJ-6f for submit@debbugs.gnu.org; Sun, 10 Aug 2014 14:28:50 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:39302) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXrL-0001l3-P7 for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 14:28:48 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NA300I00SFFEQ00@mtaout28.012.net.il> for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 21:28:06 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NA300J4PSMU5900@mtaout28.012.net.il>; Sun, 10 Aug 2014 21:28:06 +0300 (IDT) Date: Sun, 10 Aug 2014 21:28:34 +0300 From: Eli Zaretskii Subject: Re: bug#18238: Fix for DOS build when using more accurate config[.h].in In-reply-to: X-012-Sender: halo1@inter.net.il To: Reuben Thomas Message-id: <83ha1kjj1p.fsf@gnu.org> References: <83lhqwjk4i.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 18238 Cc: 18238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 10 Aug 2014 19:20:48 +0100 > From: Reuben Thomas > Cc: 18238@debbugs.gnu.org > > > I don't see why the suggested code is better than the existing one. > > HAVE_GETRLIMIT means more than its name says, as you point out, so > > DJGPP is correct in not defining one. > > > > I think I was unclear, sorry: DJGPP does define getrlimit. It is only the > MSDOS config.in that says it is not defined. If you run ./configure, then > it detects getrlimit, and defines HAVE_GETRLIMIT. Then it's a bug in the configure test for getrlimit: it should not only test for the existence of the function, but also for RLIMIT_AS and RLIMIT_DATA it actually needs. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 15:36:15 2014 Received: (at 18238) by debbugs.gnu.org; 10 Aug 2014 19:36:15 +0000 Received: from localhost ([127.0.0.1]:38009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGYud-0004fl-2y for submit@debbugs.gnu.org; Sun, 10 Aug 2014 15:36:15 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:59419) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGYua-0004fW-3q for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 15:36:13 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NA300G00UXY4A00@mtaout24.012.net.il> for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 22:31:49 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NA300GJ6VL0NK10@mtaout24.012.net.il>; Sun, 10 Aug 2014 22:31:49 +0300 (IDT) Date: Sun, 10 Aug 2014 22:35:58 +0300 From: Eli Zaretskii Subject: Re: bug#18238: Fix for DOS build when using more accurate config[.h].in In-reply-to: <83ha1kjj1p.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: rrt@sc3d.org Message-id: <838umwjfxd.fsf@gnu.org> References: <83lhqwjk4i.fsf@gnu.org> <83ha1kjj1p.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 18238 Cc: 18238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 10 Aug 2014 21:28:34 +0300 > From: Eli Zaretskii > Cc: 18238@debbugs.gnu.org > > > Date: Sun, 10 Aug 2014 19:20:48 +0100 > > From: Reuben Thomas > > Cc: 18238@debbugs.gnu.org > > > > > I don't see why the suggested code is better than the existing one. > > > HAVE_GETRLIMIT means more than its name says, as you point out, so > > > DJGPP is correct in not defining one. > > > > > > > I think I was unclear, sorry: DJGPP does define getrlimit. It is only the > > MSDOS config.in that says it is not defined. If you run ./configure, then > > it detects getrlimit, and defines HAVE_GETRLIMIT. > > Then it's a bug in the configure test for getrlimit: it should not > only test for the existence of the function, but also for RLIMIT_AS > and RLIMIT_DATA it actually needs. Alternatively, you could leave the configure test alone, and instead test for RLIMIT_* constants in the conditional, like this: #if defined HAVE_GETRLIMIT && defined RLIMIT_DATA && defined RLIMIT_AS ... etc. This is what emacs.c does with HAVE_SETRLIMIT. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 22 15:02:28 2021 Received: (at 18238) by debbugs.gnu.org; 22 Oct 2021 19:02:28 +0000 Received: from localhost ([127.0.0.1]:33779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdzoB-0004Jg-Vj for submit@debbugs.gnu.org; Fri, 22 Oct 2021 15:02:28 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:35348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdzo8-0004JO-6B for 18238@debbugs.gnu.org; Fri, 22 Oct 2021 15:02:26 -0400 Received: by mail-pj1-f50.google.com with SMTP id n11-20020a17090a2bcb00b001a1e7a0a6a6so2729399pje.0 for <18238@debbugs.gnu.org>; Fri, 22 Oct 2021 12:02:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=GW9oTZvpDorPg8uaTmJubsRP+omxLeZrwp1/6sqQxLY=; b=1EW2bx/M2TpHSfEIZuuSGQY/gBzCxI+rrq4suCwKovUVM648BSM09ylGs++1v3uhdq hOfKjcECgS2p2B0ruDkuRsqOEYEaTM1QxfuN0h73NbOQZXe/pxeVzoiw0wb4As//Urkd +iyeIHN6F2PQuRM2eXWUjcMrN7UOjxg+enFTY2YKTOoWi9I1I2XC+Keq+TDra4vgZC9M zIbbu1PO2OI8tU+9M5f+xCt2dLsxbrNWcIhp8HU62/b3PGzZctlZxMb/tsv+WUQY4bsD ZPVT0lmYff47cel71wUhEmPVClQ2BuPjLS/RrKqSq1dtUUHwKs7pVzy+Ov77VdPYmUlk RkoA== X-Gm-Message-State: AOAM533VS2yHzpydOyVPQXSuDj4y/Ytduk0vJaLeOjiWkf9zHUbaW11N mawG/4zFIEFv9MTyFo4N7KNbR/qs33XgYt4WE+w= X-Google-Smtp-Source: ABdhPJx8ibfsqN31PCzRcST+vXXWELDmm7rBCm3YJyj/fpjYDpDJ9xstJkpDWmv3qoT2KE+N9RkDnBeOV7zcW3d/0rk= X-Received: by 2002:a17:90b:17d2:: with SMTP id me18mr16583185pjb.132.1634929338183; Fri, 22 Oct 2021 12:02:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 22 Oct 2021 15:02:17 -0400 From: Stefan Kangas In-Reply-To: (Reuben Thomas's message of "Sun, 10 Aug 2014 17:47:11 +0100") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Fri, 22 Oct 2021 15:02:17 -0400 Message-ID: Subject: Re: bug#18238: Fix for DOS build when using more accurate config[.h].in To: Reuben Thomas Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 18238 Cc: 18238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Reuben Thomas writes: > DJGPP does actually have getrlimit. The special config[.h].in for MSDOS lies and says it hasn't. However, this is a white lie, because > getrlimit on DJGPP doesn't support RLIMIT_AS/RLIMIT_DATA, which is what we want, so we still want the workaround code. The following > patch simply reverses the order of a couple of tests in vm-limit.c so that being on MSDOS overrides HAVE_GETRLIMIT. > > Is it OK to install? (That was in 2014.) It seems like this patch was never installed. Is it still relevant? > === modified file 'src/vm-limit.c' > --- src/vm-limit.c 2014-07-11 10:09:51 +0000 > +++ src/vm-limit.c 2014-08-10 16:44:24 +0000 > @@ -71,7 +71,27 @@ > /* Number of bytes of writable memory we can expect to be able to get. */ > static size_t lim_data; > > > -#ifdef HAVE_GETRLIMIT > +#ifdef MSDOS > + > +void > +get_lim_data (void) > +{ > + unsigned long totalram, freeram, totalswap, freeswap; > + > + dos_memory_info (&totalram, &freeram, &totalswap, &freeswap); > + lim_data = freeram; > + /* Don't believe they will give us more that 0.5 GB. */ > + if (lim_data > 512U * 1024U * 1024U) > + lim_data = 512U * 1024U * 1024U; > +} > + > +unsigned long > +ret_lim_data (void) > +{ > + get_lim_data (); > + return lim_data; > +} > +#elif defined HAVE_GETRLIMIT > > # ifndef RLIMIT_AS > # define RLIMIT_AS RLIMIT_DATA > @@ -101,26 +121,6 @@ > lim_data = reserved_heap_size; > } > > -#elif defined MSDOS > - > -void > -get_lim_data (void) > -{ > - unsigned long totalram, freeram, totalswap, freeswap; > - > - dos_memory_info (&totalram, &freeram, &totalswap, &freeswap); > - lim_data = freeram; > - /* Don't believe they will give us more that 0.5 GB. */ > - if (lim_data > 512U * 1024U * 1024U) > - lim_data = 512U * 1024U * 1024U; > -} > - > -unsigned long > -ret_lim_data (void) > -{ > - get_lim_data (); > - return lim_data; > -} > #else > # error "get_lim_data not implemented on this machine" > #endif From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 22 17:14:24 2021 Received: (at 18238) by debbugs.gnu.org; 22 Oct 2021 21:14:24 +0000 Received: from localhost ([127.0.0.1]:33869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me1rs-0007Ye-1O for submit@debbugs.gnu.org; Fri, 22 Oct 2021 17:14:24 -0400 Received: from mail-pl1-f178.google.com ([209.85.214.178]:34331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me1rn-0007YO-CF for 18238@debbugs.gnu.org; Fri, 22 Oct 2021 17:14:23 -0400 Received: by mail-pl1-f178.google.com with SMTP id g5so3634892plg.1 for <18238@debbugs.gnu.org>; Fri, 22 Oct 2021 14:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Agw54wkRYC5XLVCvwj/VpX0aTFcMuaxCeA8QGgyz4Ts=; b=W3Qb31S4aZokJeEumK8wo4hjWacPdAGH+T8m9whr0nC5xODQmdjXmDYMzRrgql87/1 Dma7CD3b39QFtp6Y4UQDPPx8Cs55RoGNxgqM51mPShz0SzzGkWoinLOrzdpvRlE11Ji3 /nrZbxZwshfJr67D35iLdM1ihl2LTwI6mxa2I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Agw54wkRYC5XLVCvwj/VpX0aTFcMuaxCeA8QGgyz4Ts=; b=WWNpa5tLSo3pr9CatG21WQUoZ8SpqyRivIeVh6JKKfHLXeN+BvWxDY/AKTY6GBYoGN dt7GVcs9AIFVyyfeqmYOkJ1JH1JG2XIc92SDrGffHywOP7VqaLh4Dl5xjSj8Uh3udp45 04xIflzfCLpPMHAI7Oi1MxVLJUTdWjMCJQGSyzYyAzBVMrENb8vCB2VFzYPM/NK9IqrX lcony12/4dSrU2EPEnXwDgsgwtX6CzMnF9wWrEJkIbweMl4AElkjZh3gCpEx/XQ4LLbE oUng7X2Vd+xLmaTeD20hnKHD6RN2l8wlG6EYEaRpKJ4kOxdkeffhwxud3jIql6LBWJK2 Pjyg== X-Gm-Message-State: AOAM530BIWlX3PFoxKWdFiuczlqzmGyb7/g0g7o0mlIQo9CivDiDXS4j C72hD5mjcT4oSgsVMwqz24/7E7LLXJlJhzrsrFpDYlTkXac= X-Google-Smtp-Source: ABdhPJxqm+zAuHX1ue/d7K+O1TP53MrG7QfKQo8BjeVHPXAGHC8F57XOrXXxdCMNySx6cPRfIElYnLb+4tRpAGVAy9g= X-Received: by 2002:a17:902:d718:b0:13d:e2ec:1741 with SMTP id w24-20020a170902d71800b0013de2ec1741mr2356077ply.38.1634937253567; Fri, 22 Oct 2021 14:14:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Reuben Thomas Date: Fri, 22 Oct 2021 22:14:02 +0100 Message-ID: Subject: Re: bug#18238: Fix for DOS build when using more accurate config[.h].in To: Stefan Kangas Content-Type: multipart/alternative; boundary="0000000000003ab25105cef77efc" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 18238 Cc: 18238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003ab25105cef77efc Content-Type: text/plain; charset="UTF-8" On Fri, 22 Oct 2021 at 20:02, Stefan Kangas wrote: > > It seems like this patch was never installed. Is it still relevant? > (This is Eli's call.) -- https://rrt.sc3d.org --0000000000003ab25105cef77efc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, 22 Oct 2021 at 20:02, Stefan Kangas <stefan@marxist.se> wrote:

It seems like this patch was never in= stalled.=C2=A0 Is it still relevant?

(This is Eli's call.)

--
--0000000000003ab25105cef77efc-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 23 02:19:20 2021 Received: (at 18238) by debbugs.gnu.org; 23 Oct 2021 06:19:20 +0000 Received: from localhost ([127.0.0.1]:34210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meANE-0006y7-AH for submit@debbugs.gnu.org; Sat, 23 Oct 2021 02:19:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meAN9-0006xj-86; Sat, 23 Oct 2021 02:19:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52272) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1meAN3-0006TT-FH; Sat, 23 Oct 2021 02:19:09 -0400 Received: from [87.69.77.57] (port=1555 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meAN3-0002B9-2P; Sat, 23 Oct 2021 02:19:09 -0400 Date: Sat, 23 Oct 2021 09:18:54 +0300 Message-Id: <831r4c6z75.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Fri, 22 Oct 2021 15:02:17 -0400) Subject: Re: bug#18238: Fix for DOS build when using more accurate config[.h].in References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 18238 Cc: 18238@debbugs.gnu.org, rrt@sc3d.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 18238 wontfix close 18238 thanks > From: Stefan Kangas > Date: Fri, 22 Oct 2021 15:02:17 -0400 > Cc: 18238@debbugs.gnu.org > > Reuben Thomas writes: > > > DJGPP does actually have getrlimit. The special config[.h].in for MSDOS lies and says it hasn't. However, this is a white lie, because > > getrlimit on DJGPP doesn't support RLIMIT_AS/RLIMIT_DATA, which is what we want, so we still want the workaround code. The following > > patch simply reverses the order of a couple of tests in vm-limit.c so that being on MSDOS overrides HAVE_GETRLIMIT. > > > > Is it OK to install? > > (That was in 2014.) > > It seems like this patch was never installed. Is it still relevant? It's as relevant as it was back then, but I see no reason to make a change with no actual functionality changes, just so the world knows that DJGPP does have (a limited version of) getrlimit. So I'm closing this bug (after fixing the typo pointed by Andreas). Thanks. From unknown Mon Jun 23 07:51:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 Nov 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator