From unknown Fri Aug 15 03:57:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18237 <18237@debbugs.gnu.org> To: bug#18237 <18237@debbugs.gnu.org> Subject: Status: Small fix for MSDOS Reply-To: bug#18237 <18237@debbugs.gnu.org> Date: Fri, 15 Aug 2025 10:57:20 +0000 retitle 18237 Small fix for MSDOS reassign 18237 emacs submitter 18237 Reuben Thomas severity 18237 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 12:40:47 2014 Received: (at submit) by debbugs.gnu.org; 10 Aug 2014 16:40:47 +0000 Received: from localhost ([127.0.0.1]:37882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGWAn-0007WX-Nn for submit@debbugs.gnu.org; Sun, 10 Aug 2014 12:40:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58848) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGWAf-0007WC-CN for submit@debbugs.gnu.org; Sun, 10 Aug 2014 12:40:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGWAY-0000CH-IW for submit@debbugs.gnu.org; Sun, 10 Aug 2014 12:40:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGWAY-0000CD-FQ for submit@debbugs.gnu.org; Sun, 10 Aug 2014 12:40:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGWAW-000741-RC for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 12:40:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGWAV-0000Bp-33 for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 12:40:28 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGWAU-0000Bl-Us for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 12:40:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56485) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1XGWAU-0007LY-Jf for bug-emacs@gnu.org; Sun, 10 Aug 2014 12:40:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGWAT-0000BZ-J4 for bug-emacs@gnu.org; Sun, 10 Aug 2014 12:40:26 -0400 Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]:46490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGWAT-0000BQ-Aj for bug-emacs@gnu.org; Sun, 10 Aug 2014 12:40:25 -0400 Received: by mail-lb0-f176.google.com with SMTP id u10so5102473lbd.21 for ; Sun, 10 Aug 2014 09:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:date:message-id:subject:from:to:content-type; bh=qQB+bqy53ELzLFPbJVNh4jLAuHNzbrRiZlwlNEF2rjM=; b=L9p+uVeTSQE1Pojq1s/ciLqzpHfGfn9LOa7ATMdfg88ejjuWLWPuwyK/NYwWiRHoH0 di0Tr5jBc6FOQ//IWtMJYBL4p7ut/06FIReAMnK3BAbhTgy+tKLaFBqsIl9LJceW95+m vGufaPIvKtFSc6fRKzE3IZjRUw9hhmvbp38nk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=qQB+bqy53ELzLFPbJVNh4jLAuHNzbrRiZlwlNEF2rjM=; b=ZedGrZNeenv7GL0gpgPDBuixGFalG3IXdtx43TwlfqCnAfP4VYfr+oAstgPYSAuXmN 7tN9xQMzQeES4VzUQvHrFJRZ4yMqkD+X1yRIjEl/WC+BqbUS1f5IHoZ9Yse4FrH80PXn cOytxtoKoOO81cQbo3xB2TXNaOymY2mqB5RbCnHtCxP0b3E/olM4io6clkqrL/qKq5Sr WUU8LDEIZPOhNm6/XTZnXJE7etO2D2ugGiQsw/4d1Z0NrAc/GofFQuOSNqjoWyC/84X2 9Mw4lSR/LDL0yYWtTFobVOUdkXmRCGEDzpDTpI5z2Vs4DiiST6tuj0VAoFG6fgmzVXF8 +fpw== X-Gm-Message-State: ALoCoQlhDP0nZ9ounqmPyvJgs8BxANOlcWb5C7u2C5loQ86WMIZD/BIzy7dA5l19Dxz7ECpdkbn1 MIME-Version: 1.0 X-Received: by 10.152.87.229 with SMTP id bb5mr3240334lab.75.1407688824249; Sun, 10 Aug 2014 09:40:24 -0700 (PDT) Received: by 10.152.246.10 with HTTP; Sun, 10 Aug 2014 09:40:24 -0700 (PDT) Date: Sun, 10 Aug 2014 17:40:24 +0100 Message-ID: Subject: Small fix for MSDOS From: Reuben Thomas To: bug-emacs Content-Type: multipart/alternative; boundary=001a11c34e0652f95a0500491862 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --001a11c34e0652f95a0500491862 Content-Type: text/plain; charset=UTF-8 The following patch helps in the case when a sockets library is installed; in my case, ls080b.zip from the DJGPP site: === modified file 'src/msdos.c' --- src/msdos.c 2014-08-09 16:12:33 +0000 +++ src/msdos.c 2014-08-09 21:51:56 +0000 @@ -4016,7 +4017,7 @@ #endif -#ifndef HAVE_SELECT +#ifndef HAVE_SYS_SELECT_H #include "sysselect.h" /* This yields the rest of the current time slice to the task manager. The reasoning is that having select doesn't imply having the sys/select.h functionality that the following code emulates. Does that look OK to install? -- http://rrt.sc3d.org --001a11c34e0652f95a0500491862 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
The following patch helps in the case when a soc= kets library is installed; in my case, ls080b.zip from the DJGPP site:
<= br>=3D=3D=3D modified file 'src/msdos.c'
--- src/msdos.c=C2=A0= =C2=A0=C2=A0 2014-08-09 16:12:33 +0000
+++ src/msdos.c=C2=A0=C2=A0=C2=A0 2014-08-09 21:51:56 +0000
@@ -4016,7 += 4017,7 @@
=C2=A0#endif
=C2=A0
=C2=A0=0C
-#ifndef HAVE_SELECT+#ifndef HAVE_SYS_SELECT_H
=C2=A0#include "sysselect.h"
= =C2=A0
=C2=A0/* This yields the rest of the current time slice to the ta= sk manager.


The reasoning is that having select doesn't imply having = the sys/select.h functionality that the following code emulates.

Does that look OK to install?
--001a11c34e0652f95a0500491862-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 14:03:14 2014 Received: (at 18237) by debbugs.gnu.org; 10 Aug 2014 18:03:14 +0000 Received: from localhost ([127.0.0.1]:37932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXSb-00017c-Qw for submit@debbugs.gnu.org; Sun, 10 Aug 2014 14:03:14 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:34161) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXSY-00017M-R8 for 18237@debbugs.gnu.org; Sun, 10 Aug 2014 14:03:12 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NA300100QKGNG00@mtaout25.012.net.il> for 18237@debbugs.gnu.org; Sun, 10 Aug 2014 20:58:07 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NA300PS0R8V7X30@mtaout25.012.net.il>; Sun, 10 Aug 2014 20:58:07 +0300 (IDT) Date: Sun, 10 Aug 2014 21:02:56 +0300 From: Eli Zaretskii Subject: Re: bug#18237: Small fix for MSDOS In-reply-to: X-012-Sender: halo1@inter.net.il To: Reuben Thomas Message-id: <83mwbcjk8f.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 18237 Cc: 18237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 10 Aug 2014 17:40:24 +0100 > From: Reuben Thomas > > The following patch helps in the case when a sockets library is installed; > in my case, ls080b.zip from the DJGPP site: > > === modified file 'src/msdos.c' > --- src/msdos.c 2014-08-09 16:12:33 +0000 > +++ src/msdos.c 2014-08-09 21:51:56 +0000 > @@ -4016,7 +4017,7 @@ > #endif > > > -#ifndef HAVE_SELECT > +#ifndef HAVE_SYS_SELECT_H > #include "sysselect.h" > > /* This yields the rest of the current time slice to the task manager. > > > The reasoning is that having select doesn't imply having the sys/select.h > functionality that the following code emulates. > > Does that look OK to install? You didn't tell enough details, so I don't understand why the change is needed, and why it is OK not to test HAVE_SELECT at all here. (I don't have ls080b.zip installed.) Please tell what problems did you see with the original code, and let's take it from there. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 14:19:35 2014 Received: (at 18237) by debbugs.gnu.org; 10 Aug 2014 18:19:35 +0000 Received: from localhost ([127.0.0.1]:37951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXiQ-0001X2-8o for submit@debbugs.gnu.org; Sun, 10 Aug 2014 14:19:35 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:61444) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXiM-0001Wm-V7 for 18237@debbugs.gnu.org; Sun, 10 Aug 2014 14:19:32 -0400 Received: by mail-la0-f49.google.com with SMTP id hz20so5892503lab.8 for <18237@debbugs.gnu.org>; Sun, 10 Aug 2014 11:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+ObAp3HMlAI4fORBQyXC02g0XSZGWGU85jQ0MSmSjlU=; b=kAV1TjEOqRma16EFb5DcxDK1gab8bX6N0z0xshFjxE8D5ZFCjEAUdh1f/3E2S1gYKJ 9iLbVBVwmUagCznSq2Mc5Fbn/7we05kgSFcH+rI77Qa22skrnj/vWi7Z1aqXEiiN36SA ThTpN1WBorEm1s2KtyVmmAyamZU2TPwIGS+b0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=+ObAp3HMlAI4fORBQyXC02g0XSZGWGU85jQ0MSmSjlU=; b=OsMNjSnVlaEnRtyv68JAgbAi9pXIFuCoAvP+l2bnEK0b4WwGxP44CjgHvp/sTQJJDQ 2Ovs/yaPL5CTBoIwpPM0IkFUsl/wJ05b9epk5AV3ioKqof7OoxNkByjqhKo9c2hWc3+k FtOgKfuKpRIZCH7/9UyG8YuzajDctATykPH0uLC1Eb3ZAeIOC0x68ilzGJALV3flLoCT 9vlUqp8I1ycbD9NCJ+NICBS2iiNMUxHrFS/k9TwxtgQAH+avXyh4KgDzTY4cCAKK+xKC fK/NcZbZZRrWHI8ka6gkMNXv7iGOad7+B8gIecLVvobTvELRyZIgfFsBFeKmgdJbobz6 8uJA== X-Gm-Message-State: ALoCoQnw1lS6SNOHYTjKB0ZoxUKPy71V9woJC7LGew840htcO7LBKyk3JqBn693RGwwTA7MDJDs1 MIME-Version: 1.0 X-Received: by 10.152.236.43 with SMTP id ur11mr3743399lac.74.1407694764269; Sun, 10 Aug 2014 11:19:24 -0700 (PDT) Received: by 10.152.246.10 with HTTP; Sun, 10 Aug 2014 11:19:24 -0700 (PDT) In-Reply-To: <83mwbcjk8f.fsf@gnu.org> References: <83mwbcjk8f.fsf@gnu.org> Date: Sun, 10 Aug 2014 19:19:24 +0100 Message-ID: Subject: Re: bug#18237: Small fix for MSDOS From: Reuben Thomas To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a11345e0e60834705004a7a9c X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18237 Cc: 18237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11345e0e60834705004a7a9c Content-Type: text/plain; charset=UTF-8 On 10 August 2014 19:02, Eli Zaretskii wrote: > > Date: Sun, 10 Aug 2014 17:40:24 +0100 > > From: Reuben Thomas > > > > The following patch helps in the case when a sockets library is > installed; > > in my case, ls080b.zip from the DJGPP site: > > > > === modified file 'src/msdos.c' > > --- src/msdos.c 2014-08-09 16:12:33 +0000 > > +++ src/msdos.c 2014-08-09 21:51:56 +0000 > > @@ -4016,7 +4017,7 @@ > > #endif > > > > > > -#ifndef HAVE_SELECT > > +#ifndef HAVE_SYS_SELECT_H > > #include "sysselect.h" > > > > /* This yields the rest of the current time slice to the task manager. > > > > > > The reasoning is that having select doesn't imply having the sys/select.h > > functionality that the following code emulates. > > > > Does that look OK to install? > > You didn't tell enough details, so I don't understand why the change > is needed, and why it is OK not to test HAVE_SELECT at all here. (I > don't have ls080b.zip installed.) Please tell what problems did you > see with the original code, and let's take it from there. > libsocket is a sockets implementation: http://rich.phekda.org/richdawe/lsck/lsck_dl.htm When it is installed, configure correctly detects that select is available, and sets HAVE_SELECT. However, libsocket has no sys/select.h, nor does it implement sys_select. Hence, at present, when I build using ./configure && make for DOS with libsocket installed, HAVE_SELECT is defined to 1, so the MS-DOS implementation of sys_select in msdos.c is not compiled. Later, the linker is unable to find sys_select, and the build fails. I think you're also saying that I should test both HAVE_SELECT && HAVE_SYS_SELECT_H therefore? You're probably right, I (incorrectly?) assumed that if HAVE_SYS_SELECT_H is true, then HAVE_SELECT would be too. -- http://rrt.sc3d.org --001a11345e0e60834705004a7a9c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 1= 0 August 2014 19:02, Eli Zaretskii <eliz@gnu.org> wrote:
> Date: Sun, 10 Aug 2014 17:40:24 +0100
> From: Reuben Thomas <rrt@sc3d.org>
>
> The following patch helps in the case when a sockets library is instal= led;
> in my case, ls080b.zip from the DJGPP site:
>
> =3D=3D=3D modified file 'src/msdos.c'
> --- src/msdos.c =C2=A0 =C2=A02014-08-09 16:12:33 +0000
> +++ src/msdos.c =C2=A0 =C2=A02014-08-09 21:51:56 +0000
> @@ -4016,7 +4017,7 @@
> =C2=A0#endif
>
>
> -#ifndef HAVE_SELECT
> +#ifndef HAVE_SYS_SELECT_H
> =C2=A0#include "sysselect.h"
>
> =C2=A0/* This yields the rest of the current time slice to the task ma= nager.
>
>
> The reasoning is that having select doesn't imply having the sys/s= elect.h
> functionality that the following code emulates.
>
> Does that look OK to install?

You didn't tell enough details, so I don't understand why the chang= e
is needed, and why it is OK not to test HAVE_SELECT at all here. =C2=A0(I don't have ls080b.zip installed.) =C2=A0Please tell what problems did y= ou
see with the original code, and let's take it from there.

When it is installed, configure correctly detects that selec= t is available, and sets HAVE_SELECT. However, libsocket has no sys/select.= h, nor does it implement sys_select.

Hence, at present, w= hen I build using ./configure && make for DOS with libsocket instal= led, HAVE_SELECT is defined to 1, so the MS-DOS implementation of sys_selec= t in msdos.c is not compiled. Later, the linker is unable to find sys_selec= t, and the build fails.

I think you're also sa= ying that I should test both HAVE_SELECT && HAVE_SYS_SELECT_H there= fore? You're probably right, I (incorrectly?) assumed that if HAVE_SYS_= SELECT_H is true, then HAVE_SELECT would be too.

--
http://rrt.sc3d.org
--001a11345e0e60834705004a7a9c-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 14:27:05 2014 Received: (at 18237) by debbugs.gnu.org; 10 Aug 2014 18:27:05 +0000 Received: from localhost ([127.0.0.1]:37959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXpg-0001in-L4 for submit@debbugs.gnu.org; Sun, 10 Aug 2014 14:27:04 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:52103) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXpe-0001iH-Ag for 18237@debbugs.gnu.org; Sun, 10 Aug 2014 14:27:03 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NA300F00SJ86S00@a-mtaout22.012.net.il> for 18237@debbugs.gnu.org; Sun, 10 Aug 2014 21:26:55 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NA300F4ISKU6V00@a-mtaout22.012.net.il>; Sun, 10 Aug 2014 21:26:55 +0300 (IDT) Date: Sun, 10 Aug 2014 21:26:47 +0300 From: Eli Zaretskii Subject: Re: bug#18237: Small fix for MSDOS In-reply-to: X-012-Sender: halo1@inter.net.il To: Reuben Thomas Message-id: <83iom0jj4o.fsf@gnu.org> References: <83mwbcjk8f.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 18237 Cc: 18237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 10 Aug 2014 19:19:24 +0100 > From: Reuben Thomas > Cc: 18237@debbugs.gnu.org > > When it is installed, configure correctly detects that select is available, > and sets HAVE_SELECT. However, libsocket has no sys/select.h, nor does it > implement sys_select. > > Hence, at present, when I build using ./configure && make for DOS with > libsocket installed, HAVE_SELECT is defined to 1, so the MS-DOS > implementation of sys_select in msdos.c is not compiled. Later, the linker > is unable to find sys_select, and the build fails. So it's a consequence of trying to configure using the Posix configure script. I'd prefer that all the changes for such a build be committed at once together, not bit by bit, and only if you eventually succeed to produce a working binary using this method. > I think you're also saying that I should test both HAVE_SELECT && > HAVE_SYS_SELECT_H therefore? Yes, at the very least. But let's delay this until you have gone all the way to building Emacs using this method. We won't know all of the implications until you do. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 14:42:25 2014 Received: (at 18237-done) by debbugs.gnu.org; 10 Aug 2014 18:42:25 +0000 Received: from localhost ([127.0.0.1]:37967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGY4W-00027j-HL for submit@debbugs.gnu.org; Sun, 10 Aug 2014 14:42:25 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:43207) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGY4S-00027U-JS for 18237-done@debbugs.gnu.org; Sun, 10 Aug 2014 14:42:21 -0400 Received: by mail-la0-f43.google.com with SMTP id hr17so6011332lab.2 for <18237-done@debbugs.gnu.org>; Sun, 10 Aug 2014 11:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=rvyT2uftqMEqQyQPYFFevBxK5uwWpzmqWE9AjU/8J/w=; b=qU8qdmuJkH7nCofNuH5obbLZbCy/lpAlfh1NiTTWEEW59tRGWx/c5mCqm5tu0SXCIK o9qdexGXJ4+6CFyT8MIGuAuT1KYsjj8jHjdmn7cTdaNv6X5J+cfxaDAKxmS2129y/nUa SJ0W8VM+vp2wOGPmntXqyCd6MDzAYUmVGbguY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=rvyT2uftqMEqQyQPYFFevBxK5uwWpzmqWE9AjU/8J/w=; b=iWEbhnpthP2AmF5nPVMGOeq29RiCK01sMhMI9OfGIbGJIgaK0q+LR3kkGqa1o86mK3 AbbNcBz98dlxBUHxUGWn46hE+if69ea1DoR/FgROBKIE4mtoeTRAL052wR3KTjz6Uq/5 aGtGuW1HGNN7ggbi3vbafVlieOyg4v/Hqsv+aKxc/TjnpCiKBODxOTywL/5Wf4R74V0n AY/TeXUDDBerpunZwNMIEsuwYuLh3GkuwHyB8pmjA1ZKB3wRim25Dh0aB1/co7sDQO1S wl+3x/bqSz6bZeUDbrvKmonuSQHxP8vegfyaNs0shKXGCJPGQ/HKEbRPTESdrZN9sZhS 220w== X-Gm-Message-State: ALoCoQkUyUnOwYOrY5rdCCM02/FBozuAxsrqPliA+SO8FEBI42qyZT/IQWOzi2O1CbRmG0cEbprI MIME-Version: 1.0 X-Received: by 10.152.43.65 with SMTP id u1mr34090931lal.5.1407696134315; Sun, 10 Aug 2014 11:42:14 -0700 (PDT) Received: by 10.152.246.10 with HTTP; Sun, 10 Aug 2014 11:42:14 -0700 (PDT) In-Reply-To: <83iom0jj4o.fsf@gnu.org> References: <83mwbcjk8f.fsf@gnu.org> <83iom0jj4o.fsf@gnu.org> Date: Sun, 10 Aug 2014 19:42:14 +0100 Message-ID: Subject: Re: bug#18237: Small fix for MSDOS From: Reuben Thomas To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a11c240cc09bdb305004acc81 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18237-done Cc: 18237-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c240cc09bdb305004acc81 Content-Type: text/plain; charset=UTF-8 On 10 August 2014 19:26, Eli Zaretskii wrote: > > I'd prefer that all the changes for such a build be committed at once > together, not bit by bit, and only if you eventually succeed to > produce a working binary using this method. > Sorry, I was trying to separate my patch into parts with different implications (e.g. no effect on the current DOS build system; some effect on that system but not more generally; more general changes); but instead I'll concentrate on producing a single patch that, as you say, results in a working binary. > > I think you're also saying that I should test both HAVE_SELECT && > > HAVE_SYS_SELECT_H therefore? > > Yes, at the very least. Noted. > But let's delay this until you have gone all > the way to building Emacs using this method. We won't know all of the > implications until you do. > Sure, OK. I am closing this bug; since you diagnosed my other patch submission as a more general bug in configuration, I'll look into a fix for it at that level. -- http://rrt.sc3d.org --001a11c240cc09bdb305004acc81 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 1= 0 August 2014 19:26, Eli Zaretskii <eliz@gnu.org> wrote:

I'd prefer that all the changes for such a build be committed at once together, not bit by bit, and only if you eventually succeed to
produce a working binary using this method.

S= orry, I was trying to separate my patch into parts with different=20 implications (e.g. no effect on the current DOS build system; some=20 effect on that system but not more generally; more general changes); but instead I'll concentrate on producing a single patch that, as you say,= =20 results in a working binary.
=C2=A0
> I think you're also saying that I should test both HAVE_SELECT &am= p;&
> HAVE_SYS_SELECT_H therefore?

Yes, at the very least.

Noted.
=C2=A0
=C2= =A0But let's delay this until you have gone all
the way to building Emacs using this method. =C2=A0We won't know all of= the
implications until you do.

Sure, OK.

I = am closing this bug; since you diagnosed my other patch submission as a mor= e general bug in configuration, I'll look into a fix for it at that lev= el.

--
http://rrt.sc3d.org
--001a11c240cc09bdb305004acc81-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 10 15:05:34 2014 Received: (at 18237) by debbugs.gnu.org; 10 Aug 2014 19:05:34 +0000 Received: from localhost ([127.0.0.1]:37982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGYQv-0002gd-45 for submit@debbugs.gnu.org; Sun, 10 Aug 2014 15:05:34 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:55066) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGYQr-0002gK-IE for 18237@debbugs.gnu.org; Sun, 10 Aug 2014 15:05:30 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NA300B00U397C00@a-mtaout20.012.net.il> for 18237@debbugs.gnu.org; Sun, 10 Aug 2014 22:05:23 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NA300AAMUCYYA50@a-mtaout20.012.net.il>; Sun, 10 Aug 2014 22:05:23 +0300 (IDT) Date: Sun, 10 Aug 2014 22:05:15 +0300 From: Eli Zaretskii Subject: Re: bug#18237: Small fix for MSDOS In-reply-to: X-012-Sender: halo1@inter.net.il To: Reuben Thomas Message-id: <83d2c8jhck.fsf@gnu.org> References: <83mwbcjk8f.fsf@gnu.org> <83iom0jj4o.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 18237 Cc: 18237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 10 Aug 2014 19:42:14 +0100 > From: Reuben Thomas > Cc: 18237-done@debbugs.gnu.org > > > I'd prefer that all the changes for such a build be committed at once > > together, not bit by bit, and only if you eventually succeed to > > produce a working binary using this method. > > Sorry, I was trying to separate my patch into parts with different > implications (e.g. no effect on the current DOS build system; some effect > on that system but not more generally; more general changes); but instead > I'll concentrate on producing a single patch that, as you say, results in a > working binary. Yes, I'd prefer that. This makes it easier to consider all of its implications at once. (You can, of course, make separate small commits on your feature branch, as you work on this; then they will all be merged onto the trunk as a single merge-commit.) > I am closing this bug; since you diagnosed my other patch submission as a > more general bug in configuration, I'll look into a fix for it at that > level. Thanks. From unknown Fri Aug 15 03:57:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 08 Sep 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator