GNU bug report logs - #18189
customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> jurta.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18189: closed (customized value of 'vc-annotate-background-mode'
 is applied only after restarting Emacs)
Date: Sun, 10 Aug 2014 00:02:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 10 Aug 2014 02:57:43 +0300
with message-id <877g2huscw.fsf <at> mail.jurta.org>
and subject line Re: bug#18189: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs
has caused the debbugs.gnu.org bug report #18189,
regarding customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18189: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18189
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: customized value of 'vc-annotate-background-mode' is applied only
 after restarting Emacs
Date: Mon, 4 Aug 2014 15:18:06 +0200

[Message part 3 (text/plain, inline)]

To reproduce:

- customize the variable and toggle its value;
- observe that annotation buffers still look the same, even if you generate
them anew;
- new variable value is only honored if you restart Emacs.

Ideally the value should be apply on-the-fly. But at least it should be
applied if I hit 'C-x v g' after customizing the variable.

Paul

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 18189-done <at> debbugs.gnu.org,
 Paul Pogonyshev <pogonyshev <at> gmail.com>
Subject: Re: bug#18189: customized value of 'vc-annotate-background-mode' is
 applied only after restarting Emacs
Date: Sun, 10 Aug 2014 02:57:43 +0300

>> `vc-annotate-background-mode' is defined before `vc-annotate-color-map'
>> in the source file vc-annotate.el, so there is a cyclic dependency
>> in these variables.  When I tried to provide it directly in the `defcustom'
>
> Usually that's a sign you need an :initialize as well as a :set, and/or
> a :set-after.

I don't see how :initialize and :set-after could be used
to update the value of the dependent variable, and can't find
a suitable example in the source code, so I just added a check
for (boundp 'vc-annotate-color-map).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.