From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 04 09:18:25 2014 Received: (at submit) by debbugs.gnu.org; 4 Aug 2014 13:18:25 +0000 Received: from localhost ([127.0.0.1]:56877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XEI9g-0002VY-AX for submit@debbugs.gnu.org; Mon, 04 Aug 2014 09:18:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35895) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XEI9d-0002VK-Rz for submit@debbugs.gnu.org; Mon, 04 Aug 2014 09:18:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEI9X-0003zq-L2 for submit@debbugs.gnu.org; Mon, 04 Aug 2014 09:18:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEI9X-0003zh-Ij for submit@debbugs.gnu.org; Mon, 04 Aug 2014 09:18:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEI9W-0005oH-FJ for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2014 09:18:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEI9S-0003xv-Mu for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2014 09:18:14 -0400 Received: from mail-ob0-x233.google.com ([2607:f8b0:4003:c01::233]:36761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEI9S-0003xd-Gn for bug-gnu-emacs@gnu.org; Mon, 04 Aug 2014 09:18:10 -0400 Received: by mail-ob0-f179.google.com with SMTP id wn1so4418877obc.38 for ; Mon, 04 Aug 2014 06:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=eTh7jUyv/WqiYcV2j/Lgqt0fV9DTiKveig7a5mAWvWQ=; b=gKYpxZe8JvWSJrmLAZnhdvFvNfIwyulHvc8eQqmcU+Wo7eeDVBAvSp2Ndrk5tNj2ay IY35Vzy/oFAlQXNtvONdkw5JEj09/ReeszRR4LqpcjH0hcBg7d6APE/WDa9fVNnGVbpj ef/BrEhkuezlHHj6CZHHEZSmtLbJFF7MGQu7k2AZJgjNpHVDleqhSbTYg/2Kk7BX+p+4 QX1BRcpSiTgksFqvJI+A/wvMnhqUc8//vGOeLzrg35QaM9H0Y8+s0PmkRLwyQgB2joV7 LoAIeehgy5co0JtT89Uz/jH0I5sqrvZ125zXfSSeWTIRD62xgwqT6AsSyAMgVwkjAHwc ltSg== MIME-Version: 1.0 X-Received: by 10.182.94.204 with SMTP id de12mr32631658obb.66.1407158286460; Mon, 04 Aug 2014 06:18:06 -0700 (PDT) Received: by 10.182.91.163 with HTTP; Mon, 4 Aug 2014 06:18:06 -0700 (PDT) Date: Mon, 4 Aug 2014 15:18:06 +0200 Message-ID: Subject: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs From: Paul Pogonyshev To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=e89a8f83964fceb55504ffcd91a7 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --e89a8f83964fceb55504ffcd91a7 Content-Type: text/plain; charset=UTF-8 To reproduce: - customize the variable and toggle its value; - observe that annotation buffers still look the same, even if you generate them anew; - new variable value is only honored if you restart Emacs. Ideally the value should be apply on-the-fly. But at least it should be applied if I hit 'C-x v g' after customizing the variable. Paul --e89a8f83964fceb55504ffcd91a7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
To reproduce:

- cust= omize the variable and toggle its value;
- observe that annotation= buffers still look the same, even if you generate them anew;
- ne= w variable value is only honored if you restart Emacs.

Ideally the value should be apply on-the-fly. But at least it sho= uld be applied if I hit 'C-x v g' after customizing the variable.
Paul
--e89a8f83964fceb55504ffcd91a7-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 04 20:43:03 2014 Received: (at 18189) by debbugs.gnu.org; 5 Aug 2014 00:43:03 +0000 Received: from localhost ([127.0.0.1]:58024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XESqE-00047k-MB for submit@debbugs.gnu.org; Mon, 04 Aug 2014 20:43:03 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:56421 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XESqA-00047H-FR for 18189@debbugs.gnu.org; Mon, 04 Aug 2014 20:42:59 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 09A6D3130E5294; Mon, 4 Aug 2014 17:42:56 -0700 (PDT) From: Juri Linkov To: Paul Pogonyshev Subject: Re: bug#18189: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs Organization: JURTA References: Date: Tue, 05 Aug 2014 03:11:05 +0300 In-Reply-To: (Paul Pogonyshev's message of "Mon, 4 Aug 2014 15:18:06 +0200") Message-ID: <87d2cfrcny.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > To reproduce: > > - customize the variable and toggle its value; > - observe that annotation buffers still look the same, even if you generate > them anew; > - new variable value is only honored if you restart Emacs. > > Ideally the value should be apply on-the-fly. But at least it should be > applied if I hit 'C-x v g' after customizing the variable. [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 18189 Cc: 18189@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > To reproduce: > > - customize the variable and toggle its value; > - observe that annotation buffers still look the same, even if you generate > them anew; > - new variable value is only honored if you restart Emacs. > > Ideally the value should be apply on-the-fly. But at least it should be > applied if I hit 'C-x v g' after customizing the variable. [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] > To reproduce: > > - customize the variable and toggle its value; > - observe that annotation buffers still look the same, even if you generate > them anew; > - new variable value is only honored if you restart Emacs. > > Ideally the value should be apply on-the-fly. But at least it should be > applied if I hit 'C-x v g' after customizing the variable. I believe this should be implemented by this patch: === modified file 'lisp/vc/vc-annotate.el' --- lisp/vc/vc-annotate.el 2014-07-08 08:49:18 +0000 +++ lisp/vc/vc-annotate.el 2014-08-05 00:07:51 +0000 @@ -139,6 +139,12 @@ (defcustom vc-annotate-color-map :type 'alist :group 'vc) +(put 'vc-annotate-background-mode 'custom-set + (lambda (symbol value) + (set-default symbol value) + (ignore-errors + (custom-reevaluate-setting 'vc-annotate-color-map)))) + (defcustom vc-annotate-very-old-color (if vc-annotate-background-mode "#CCCCFF" "#3F3FFF") "Color for lines older than the current color range in \\[vc-annotate]." :type 'string From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 06 13:33:26 2014 Received: (at 18189) by debbugs.gnu.org; 6 Aug 2014 17:33:26 +0000 Received: from localhost ([127.0.0.1]:60621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XF55Z-0006cI-Lh for submit@debbugs.gnu.org; Wed, 06 Aug 2014 13:33:26 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:37563) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XF55W-0006c8-AF for 18189@debbugs.gnu.org; Wed, 06 Aug 2014 13:33:23 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 04E4884F3C; Wed, 6 Aug 2014 13:33:22 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 7B94A1E5B74; Wed, 6 Aug 2014 13:32:59 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 46E56B40CD; Wed, 6 Aug 2014 13:32:59 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#18189: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs Message-ID: References: <87d2cfrcny.fsf@mail.jurta.org> Date: Wed, 06 Aug 2014 13:32:59 -0400 In-Reply-To: <87d2cfrcny.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 05 Aug 2014 03:11:05 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 18189 Cc: Paul Pogonyshev , 18189@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > +(put 'vc-annotate-background-mode 'custom-set > + (lambda (symbol value) > + (set-default symbol value) > + (ignore-errors > + (custom-reevaluate-setting 'vc-annotate-color-map)))) Why not provide it directly in the `defcustom'? Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 08 20:50:08 2014 Received: (at 18189) by debbugs.gnu.org; 9 Aug 2014 00:50:08 +0000 Received: from localhost ([127.0.0.1]:35910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFurG-0004Rj-QF for submit@debbugs.gnu.org; Fri, 08 Aug 2014 20:50:07 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:35196 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFurA-0004Qz-2v for 18189@debbugs.gnu.org; Fri, 08 Aug 2014 20:50:01 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id E8C023728FFFCF; Fri, 8 Aug 2014 17:49:57 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#18189: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs Organization: JURTA References: <87d2cfrcny.fsf@mail.jurta.org> Date: Sat, 09 Aug 2014 02:31:50 +0300 In-Reply-To: (Stefan Monnier's message of "Wed, 06 Aug 2014 13:32:59 -0400") Message-ID: <87d2cajxyp.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> +(put 'vc-annotate-background-mode 'custom-set >> + (lambda (symbol value) >> + (set-default symbol value) >> + (ignore-errors >> + (custom-reevaluate-setting 'vc-annotate-color-map)))) > > Why not provide it directly in the `defcustom'? [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 18189 Cc: Paul Pogonyshev , 18189@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> +(put 'vc-annotate-background-mode 'custom-set >> + (lambda (symbol value) >> + (set-default symbol value) >> + (ignore-errors >> + (custom-reevaluate-setting 'vc-annotate-color-map)))) > > Why not provide it directly in the `defcustom'? [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> +(put 'vc-annotate-background-mode 'custom-set >> + (lambda (symbol value) >> + (set-default symbol value) >> + (ignore-errors >> + (custom-reevaluate-setting 'vc-annotate-color-map)))) > > Why not provide it directly in the `defcustom'? `vc-annotate-background-mode' is defined before `vc-annotate-color-map' in the source file vc-annotate.el, so there is a cyclic dependency in these variables. When I tried to provide it directly in the `defcustom' :set (lambda (symbol value) (set-default symbol value) (ignore-errors (custom-reevaluate-setting 'vc-annotate-color-map))) then loading the file failed with the error: Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) #[257 "\211\300_\301\302\303\"\304\305E\306\307\310\311\312E&\207" [nil v= ector format "Span %.1f days" vc-annotate-display-select nil :style toggle = :selected eql vc-annotate-display-mode] 11 "\n\n(fn ELEMENT)"](2) mapcar(#[257 "\211\300_\301\302\303\"\304\305E\306\307\310\311\312E&\207"= [nil vector format "Span %.1f days" vc-annotate-display-select nil :style = toggle :selected eql vc-annotate-display-mode] 11 "\n\n(fn ELEMENT)"] (2 0.= 5 0.1 0.01)) byte-code("\304\305\306\307\310\311\312!\313\314\315\316\317\320!\321\"\3= 22\323%\n\"\262\324\325\326\327\325\330\331\332\333\334\335\325\336\337\340= \320\341\342\343\344\345\346\347BBE\350BBBB\"\351BBBBBBBBBBBBBBB\"BB$\207" = [vc-annotate-mode-map vc-annotate-color-map vc-annotate-menu-elements vc-an= notate-backend easy-menu-do-define vc-annotate-mode-menu "VC Annotate Displ= ay Menu" "VC-Annotate" ["By Color Map Range" (unless (null vc-annotate-disp= lay-mode) (setq vc-annotate-display-mode nil) (vc-annotate-display-select))= :style toggle :selected (null vc-annotate-display-mode)] append vc-annotat= e-oldest-in-map mapcar make-byte-code 257 "\211\300_\301\302\303\"\304\305E= \306\307\310\311\312E&\207" vconcat vector [vector format "Span %.1f days" = vc-annotate-display-select nil :style toggle :selected eql vc-annotate-disp= lay-mode] 11 "\n\n(fn ELEMENT)" ["Span ..." (vc-annotate-display-select nil= (float (string-to-number (read-string "Span how many days? "))))] "--" ["S= pan to Oldest" (unless (eq vc-annotate-display-mode (quote scale)) (vc-anno= tate-display-select nil (quote scale))) :help "Use an autoscaled color map = from the oldest annotation to the current time" :style toggle :selected (eq= vc-annotate-display-mode (quote scale))] ["Span Oldest->Newest" (unless (e= q vc-annotate-display-mode (quote fullscale)) (vc-annotate-display-select n= il (quote fullscale))) :help "Use an autoscaled color map from the oldest t= o the newest annotation" :style toggle :selected (eq vc-annotate-display-mo= de (quote fullscale))] ["Toggle annotation visibility" vc-annotate-toggle-a= nnotation-visibility :help "Toggle whether the annotation is visible or not= "] ["Annotate previous revision" vc-annotate-prev-revision :help "Visit the= annotation of the revision previous to this one"] ["Annotate next revision= " vc-annotate-next-revision :help "Visit the annotation of the revision aft= er this one"] ["Annotate revision at line" vc-annotate-revision-at-line :he= lp "Visit the annotation of the revision identified in the current line"] [= "Annotate revision previous to line" vc-annotate-revision-previous-to-line = :help "Visit the annotation of the revision before the revision at line"] [= "Annotate latest revision" vc-annotate-working-revision :help "Visit the an= notation of the working revision of this file"] ["Show log of revision at l= ine" vc-annotate-show-log-revision-at-line :help "Visit the log of the revi= sion at line"] ["Show diff of revision at line" vc-annotate-show-diff-revis= ion-at-line :help "Visit the diff of the revision at line from its previous= revision"] apply "Show changeset diff of revision at line" vc-annotate-sho= w-changeset-diff-revision-at-line :enable eq (quote repository) vc-call-bac= kend ((quote revision-granularity)) (:help "Visit the diff of the revision = at line from its previous revision") (["Visit revision at line" vc-annotate= -find-revision-at-line :help "Visit the revision identified in the current = line"])] 32) autoload-do-load((autoload "vc-annotate" 1541696 t nil) vc-annotate) command-execute(vc-annotate) From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 08 21:49:26 2014 Received: (at 18189) by debbugs.gnu.org; 9 Aug 2014 01:49:26 +0000 Received: from localhost ([127.0.0.1]:35922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFvmf-0005rW-F2 for submit@debbugs.gnu.org; Fri, 08 Aug 2014 21:49:25 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:44955) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFvmc-0005rH-9c for 18189@debbugs.gnu.org; Fri, 08 Aug 2014 21:49:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVPAqyKr/2dsb2JhbABZgwaDSsA9gRcXdIImAQEEViMQCzQHCxQYDSSIDNIZF456B4Q4BKsDgXGBWyE X-IPAS-Result: ArUGAIDvNVPAqyKr/2dsb2JhbABZgwaDSsA9gRcXdIImAQEEViMQCzQHCxQYDSSIDNIZF456B4Q4BKsDgXGBWyE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="82525657" Received: from 192-171-34-171.cpe.pppoe.ca (HELO pastel.home) ([192.171.34.171]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Aug 2014 21:49:15 -0400 Received: by pastel.home (Postfix, from userid 20848) id 38BE0606A0; Fri, 8 Aug 2014 21:49:15 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#18189: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs Message-ID: References: <87d2cfrcny.fsf@mail.jurta.org> <87d2cajxyp.fsf@mail.jurta.org> Date: Fri, 08 Aug 2014 21:49:15 -0400 In-Reply-To: <87d2cajxyp.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 09 Aug 2014 02:31:50 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18189 Cc: Paul Pogonyshev , 18189@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > `vc-annotate-background-mode' is defined before `vc-annotate-color-map' > in the source file vc-annotate.el, so there is a cyclic dependency > in these variables. When I tried to provide it directly in the `defcustom' > :set (lambda (symbol value) > (set-default symbol value) > (ignore-errors > (custom-reevaluate-setting 'vc-annotate-color-map))) Maybe we should check (boundp 'vc-annotate-color-map) before calling custom-reevaluate-setting. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 09 16:05:17 2014 Received: (at 18189) by debbugs.gnu.org; 9 Aug 2014 20:05:17 +0000 Received: from localhost ([127.0.0.1]:36742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGCtA-0002Sd-Nz for submit@debbugs.gnu.org; Sat, 09 Aug 2014 16:05:17 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43247 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGCt8-0002SS-6X for 18189@debbugs.gnu.org; Sat, 09 Aug 2014 16:05:15 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XGCt6-0002qH-4F; Sat, 09 Aug 2014 16:05:12 -0400 From: Glenn Morris To: Juri Linkov Subject: Re: bug#18189: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs References: <87d2cfrcny.fsf@mail.jurta.org> <87d2cajxyp.fsf@mail.jurta.org> X-Spook: Croatian Delta Force Maple top secret Bin Laden X-Ran: S-hn'B^anhV[*D:3oeLtwy*m*;c@mf%t9M18Z_n]&XoV\f6U84FQ^d_F (Juri Linkov's message of "Sat, 09 Aug 2014 02:31:50 +0300") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 18189 Cc: Stefan Monnier , 18189@debbugs.gnu.org, Paul Pogonyshev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Juri Linkov wrote: > `vc-annotate-background-mode' is defined before `vc-annotate-color-map' > in the source file vc-annotate.el, so there is a cyclic dependency > in these variables. When I tried to provide it directly in the `defcustom' Usually that's a sign you need an :initialize as well as a :set, and/or a :set-after. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 09 20:01:56 2014 Received: (at 18189-done) by debbugs.gnu.org; 10 Aug 2014 00:01:56 +0000 Received: from localhost ([127.0.0.1]:36847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGGaC-0003sP-0R for submit@debbugs.gnu.org; Sat, 09 Aug 2014 20:01:56 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:50279 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGGa9-0003sA-VF for 18189-done@debbugs.gnu.org; Sat, 09 Aug 2014 20:01:54 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 278D03132689DB; Sat, 9 Aug 2014 17:01:51 -0700 (PDT) From: Juri Linkov To: Glenn Morris Subject: Re: bug#18189: customized value of 'vc-annotate-background-mode' is applied only after restarting Emacs Organization: JURTA References: <87d2cfrcny.fsf@mail.jurta.org> <87d2cajxyp.fsf@mail.jurta.org> Date: Sun, 10 Aug 2014 02:57:43 +0300 In-Reply-To: (Glenn Morris's message of "Sat, 09 Aug 2014 16:05:11 -0400") Message-ID: <877g2huscw.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> `vc-annotate-background-mode' is defined before `vc-annotate-color-map' >> in the source file vc-annotate.el, so there is a cyclic dependency >> in these variables. When I tried to provide it directly in the `defcustom' > > Usually that's a sign you need an :initialize as well as a :set, and/or > a :set-after. [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 18189-done Cc: Stefan Monnier , 18189-done@debbugs.gnu.org, Paul Pogonyshev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> `vc-annotate-background-mode' is defined before `vc-annotate-color-map' >> in the source file vc-annotate.el, so there is a cyclic dependency >> in these variables. When I tried to provide it directly in the `defcustom' > > Usually that's a sign you need an :initialize as well as a :set, and/or > a :set-after. [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> `vc-annotate-background-mode' is defined before `vc-annotate-color-map' >> in the source file vc-annotate.el, so there is a cyclic dependency >> in these variables. When I tried to provide it directly in the `defcustom' > > Usually that's a sign you need an :initialize as well as a :set, and/or > a :set-after. I don't see how :initialize and :set-after could be used to update the value of the dependent variable, and can't find a suitable example in the source code, so I just added a check for (boundp 'vc-annotate-color-map). From unknown Mon Aug 18 15:40:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 07 Sep 2014 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator