GNU bug report logs - #18163
elisp: highlighting of unexpected indentation should use separate face from highlight of error functions

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Fri, 1 Aug 2014 04:25:02 UTC

Severity: wishlist

Merged with 25030

Found in versions 25.1, 24.4.50

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18163: closed (24.4.50; REGRESSION, font-lock in
 `emacs-lisp-mode': spurious `font-lock-warning-face')
Date: Wed, 06 Aug 2014 17:16:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 06 Aug 2014 13:15:04 -0400
with message-id <jwv38d9mth2.fsf-monnier+emacsbugs <at> gnu.org>
and subject line Re: bug#18163: 24.4.50; REGRESSION, font-lock in `emacs-lisp-mode': spurious `font-lock-warning-face'
has caused the debbugs.gnu.org bug report #18163,
regarding 24.4.50; REGRESSION, font-lock in `emacs-lisp-mode': spurious `font-lock-warning-face'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18163: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18163
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; REGRESSION, font-lock in `emacs-lisp-mode': spurious
 `font-lock-warning-face'
Date: Thu, 31 Jul 2014 21:23:47 -0700 (PDT)
Recipe from emacs -Q: Type this into an Emacs-Lisp mode buffer:

(defun foo ()
  (condition-case nil
      (let ((toto (lambda (cand)
		     (foo)) bar)))
    (quit (tutu))))

The text "bar)))" is highlighted erroneously, with face
`font-lock-warning-face'.  It should not be highlighted at all.

If you add more right-parens, or any other text, at the end of the same
line as the warning-highlighted text, it too has that red face.  It
does not seem to matter what text you add.  You can remove all of the
warning-face text except the `b' (or any other char in place of `b'),
and it is still highlighted.  You can remove the SPC before the `b'
and it remains highlighted.  If you remove the whitespace before
"(foo..." on the same line, the highlighting remains.

If you remove the newline before the "(foo..." line then the
highlighting goes away.

The first build where I see this regression is this one:

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-04-25 on ODIEONE
Repository revision: 117024 monnier <at> iro.umontreal.ca-20140425192226-frpjpmgs0r8ad9wc
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

The last build I have where there is not this regression is this one:

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-04-21 on ODIEONE
Repository revision: 117005 dancol <at> dancol.org-20140421180019-po4wdeg7gqvvlh5d
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

This is the build I'm sending this report from:

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm <at> gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''


[Message part 3 (message/rfc822, inline)]
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 18163-done <at> debbugs.gnu.org
Subject: Re: bug#18163: 24.4.50;
 REGRESSION, font-lock in `emacs-lisp-mode': spurious
 `font-lock-warning-face'
Date: Wed, 06 Aug 2014 13:15:04 -0400
tags 18163 notabug
thanks

> The text "bar)))" is highlighted erroneously, with face
> `font-lock-warning-face'.

It's no error.  There's even a help-text explaining why it's highlighted
this way (if you hover your mouse above the highlighted text).


        Stefan


This bug report was last modified 3 years and 161 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.