GNU bug report logs - #18157
24.4.50; battery-pmset fails to report critical battery state

Previous Next

Package: emacs;

Reported by: Sebastian Wiesner <swiesner <at> lunaryorn.com>

Date: Thu, 31 Jul 2014 13:18:02 UTC

Severity: normal

Tags: fixed

Found in version 24.4.50

Fixed in version 25.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #23 received at 18157 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Marcin Borkowski <mbork <at> mbork.pl>
Cc: 18157 <at> debbugs.gnu.org
Subject: Re: bug#18157: 24.4.50;
 battery-pmset fails to report critical battery state
Date: Sat, 20 Feb 2016 18:35:14 +1100
Marcin Borkowski <mbork <at> mbork.pl> writes:

> Does this patch help?
>
> diff -u --label /usr/local/share/emacs/25.1.50/lisp/battery.el.gz --label \#\<buffer\ battery.el.gz\> /tmp/jka-com1889YvM /tmp/buffer-content-1889yDZ
> --- /usr/local/share/emacs/25.1.50/lisp/battery.el.gz
> +++ #<buffer battery.el.gz>
> @@ -628,12 +628,12 @@
>  	    (cond ((looking-at "; charging")
>  		   (setq battery-status "charging"
>  			 battery-status-symbol "+"))
> -		  ((< (string-to-number load-percentage) battery-load-low)
> -		   (setq battery-status "low"
> -			 battery-status-symbol "-"))
>  		  ((< (string-to-number load-percentage) battery-load-critical)
>  		   (setq battery-status "critical"
>  			 battery-status-symbol "!"))
> +		  ((< (string-to-number load-percentage) battery-load-low)
> +		   (setq battery-status "low"
> +			 battery-status-symbol "-"))
>  		  (t
>  		   (setq battery-status "high"
>  			 battery-status-symbol "")))

Looks logical to me.  I've applied it to emacs-25.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 9 years and 90 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.