From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 29 17:42:29 2014 Received: (at submit) by debbugs.gnu.org; 29 Jul 2014 21:42:29 +0000 Received: from localhost ([127.0.0.1]:42329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XCFAC-0004T9-7G for submit@debbugs.gnu.org; Tue, 29 Jul 2014 17:42:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36718) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XCFA9-0004Sv-1Q for submit@debbugs.gnu.org; Tue, 29 Jul 2014 17:42:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCF9y-0005Gb-HY for submit@debbugs.gnu.org; Tue, 29 Jul 2014 17:42:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCF9y-0005GW-FB for submit@debbugs.gnu.org; Tue, 29 Jul 2014 17:42:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCF9t-0007AA-0T for bug-parted@gnu.org; Tue, 29 Jul 2014 17:42:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCF9n-0005AE-Gc for bug-parted@gnu.org; Tue, 29 Jul 2014 17:42:08 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:61693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCF9n-0005A1-5d for bug-parted@gnu.org; Tue, 29 Jul 2014 17:42:03 -0400 Received: by mail-we0-f172.google.com with SMTP id x48so280663wes.17 for ; Tue, 29 Jul 2014 14:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; bh=NMPWwgnfkk0oKqQPoNptBB0TVScrjC6bz1mJaeNODI8=; b=fmBS1e7RUXPEQeM2kvXUVWs0f8DbQbQZiGQ0YOWGROlGtIZqJIfex6qGcmx3wU0PTx +JlJ1JRDFGFlQ2MixgBcaqegUCY5Jqatej1gq3tTm8W4lhECvUHahFbttmYsPXF6xvVk PJnatVrE2FECuJmnxs/gY/u2eCzbYTBAHF1bhYbbGMO8b0+wkJ8WLJKMLBNZZuTdYbhe kl4OAAG/c5LM8KgXoxbzB2yRguI7aCnIp6kR3PfJnSlgMwwD0VhcTQnl4DbAa4waHjOF W97qmTS833e55huFO2zgpL72GMcchpc9G+laB2ZCWZo0FHazSTIor6ex37Khvn15q6sJ qOFA== X-Received: by 10.180.12.38 with SMTP id v6mr806636wib.31.1406670117976; Tue, 29 Jul 2014 14:41:57 -0700 (PDT) Received: from [192.168.0.40] ([90.203.222.171]) by mx.google.com with ESMTPSA id ft17sm514596wjc.14.2014.07.29.14.41.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 29 Jul 2014 14:41:57 -0700 (PDT) Message-ID: <53D81524.80305@googlemail.com> Date: Tue, 29 Jul 2014 22:41:56 +0100 From: Chris Clayton User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: bug-parted@gnu.org Subject: parted-3.2 build failure Content-Type: multipart/mixed; boundary="------------020703000804020208060301" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) This is a multi-part message in MIME format. --------------020703000804020208060301 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi. I'm getting the following errors trying to build parted-3.2: arch/linux.c: In function 'dm_canonical_path': arch/linux.c:2313:16: warning: implicit declaration of function 'dm_task_create' [-Wimplicit-function-declaration] struct dm_task *task = dm_task_create (DM_DEVICE_INFO); ^ arch/linux.c:2313:48: error: 'DM_DEVICE_INFO' undeclared (first use in this function) struct dm_task *task = dm_task_create (DM_DEVICE_INFO); ^ arch/linux.c:2313:48: note: each undeclared identifier is reported only once for each function it appears in arch/linux.c:2316:9: warning: implicit declaration of function 'dm_task_set_major_minor' [-Wimplicit-function-declaration] if (!dm_task_set_major_minor (task, arch_specific->major, ^ arch/linux.c:2319:9: warning: implicit declaration of function 'dm_task_run' [-Wimplicit-function-declaration] if (!dm_task_run(task)) ^ arch/linux.c:2321:9: warning: implicit declaration of function 'dm_task_get_name' [-Wimplicit-function-declaration] char *dev_name = zasprintf ("/dev/mapper/%s", dm_task_get_name (task)); ^ arch/linux.c:2324:9: warning: implicit declaration of function 'dm_task_destroy' [-Wimplicit-function-declaration] dm_task_destroy (task); ^ arch/linux.c: In function '_disk_sync_part_table': arch/linux.c:2949:33: error: '_dm_add_partition' undeclared (first use in this function) add_partition = _dm_add_partition; ^ arch/linux.c:2950:36: error: '_dm_remove_partition' undeclared (first use in this function) remove_partition = _dm_remove_partition; ^ arch/linux.c:2951:36: error: '_dm_resize_partition' undeclared (first use in this function) resize_partition = _dm_resize_partition; ^ arch/linux.c:2952:50: error: '_dm_get_partition_start_and_length' undeclared (first use in this function) get_partition_start_and_length = _dm_get_partition_start_and_length; ^ I am passing --disable-device-mapper to configure, but the code causing the errors is not guarded by #ifdef ENABLE_DEVICE_MAPPER. The attached patch allows the build to succeed. I think the resultant code is functionally correct, but I'm sure you will check that :-) Regards. Chris --------------020703000804020208060301 Content-Type: text/plain; charset=us-ascii; name="parted-3.2-device-mapper.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="parted-3.2-device-mapper.patch" --- parted-3.2/libparted/arch/linux.c.device-mapper 2014-06-15 20:15:54.000000000 +0100 +++ parted-3.2/libparted/arch/linux.c 2014-07-29 22:27:54.487430030 +0100 @@ -2307,6 +2307,7 @@ zasprintf (const char *format, ...) static char * dm_canonical_path (PedDevice const *dev) { +#ifdef ENABLE_DEVICE_MAPPER LinuxSpecific const *arch_specific = LINUX_SPECIFIC (dev); /* Get map name from devicemapper */ @@ -2324,6 +2325,7 @@ dm_canonical_path (PedDevice const *dev) dm_task_destroy (task); return dev_name; err: +#endif return NULL; } @@ -2944,13 +2946,14 @@ _disk_sync_part_table (PedDisk* disk) unsigned long long *start, unsigned long long *length); - +#ifdef ENABLE_DEVICE_MAPPER if (disk->dev->type == PED_DEVICE_DM) { add_partition = _dm_add_partition; remove_partition = _dm_remove_partition; resize_partition = _dm_resize_partition; get_partition_start_and_length = _dm_get_partition_start_and_length; } else { +#endif add_partition = _blkpg_add_partition; remove_partition = _blkpg_remove_partition; #ifdef BLKPG_RESIZE_PARTITION @@ -2959,7 +2962,9 @@ _disk_sync_part_table (PedDisk* disk) resize_partition = NULL; #endif get_partition_start_and_length = _kernel_get_partition_start_and_length; +#ifdef ENABLE_DEVICE_MAPPER } +#endif /* lpn = largest partition number. * for remove pass, use greater of device or label limit */ --------------020703000804020208060301-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 20:48:04 2016 Received: (at 18147-done) by debbugs.gnu.org; 15 Apr 2016 00:48:04 +0000 Received: from localhost ([127.0.0.1]:35823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqrvY-0006pW-GA for submit@debbugs.gnu.org; Thu, 14 Apr 2016 20:48:04 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:25424 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqrvX-0006p0-98 for 18147-done@debbugs.gnu.org; Thu, 14 Apr 2016 20:48:03 -0400 Received: from [72.239.162.168] ([72.239.162.168:37640] helo=[192.168.1.142]) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 5B/2F-09444-D3A30175; Fri, 15 Apr 2016 00:47:57 +0000 Subject: Re: bug#18147: parted-3.2 build failure To: 18147-done@debbugs.gnu.org References: <53D81524.80305@googlemail.com> From: Phillip Susi Message-ID: <57103A3D.7050601@ubuntu.com> Date: Thu, 14 Apr 2016 20:47:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <53D81524.80305@googlemail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 18147-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Looks like this was fixed a while back: commit a3877115f1956949096d77aca5a703a47ed68397 Author: Felix Janda Date: Sun May 3 10:33:31 2015 +0200 libparted/fs/xfs/platform_defs.h: Include for loff_t This is needed for compilation with musl libc Suggested-by: Travis Tilley Signed-off-by: Brian C. Lane -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCgAGBQJXEDo9AAoJEBB5UWFcu6UWrbAIAI/YxgcHYKuhEysX5D47fxqN n3ewzkH4N0z9Hw7ViW5EdgiDrRp7r6GmYK/TxgzsowvA/t8Td4FqdrgrFRdgRk70 apK3GxgpeIuZN/ClQqkcNcXFKYQOXSep61WDVcaOjAnAmNIPH1qessA+RzziSEGm fdErrg+CHnW5a/XPazQLDc6XEqiAioLZCnJ0vFTInZYuKSQXyoLPaeeHHhXPfwJ+ KPWQw38No1cEt1jTG+iyc2oR5t+Nv6qZDmRSQ22p6uvCXosgM5VGDJmI3sauN9Al 8Oy7rsrmatlRTb2GeIp15Xa3ehoAQ1P9ydq5JVL39ANngYSvAPRmv1A94O8eBcU= =cYtt -----END PGP SIGNATURE----- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 15 03:20:16 2016 Received: (at 18147) by debbugs.gnu.org; 15 Apr 2016 07:20:16 +0000 Received: from localhost ([127.0.0.1]:36084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqy35-0007gd-TT for submit@debbugs.gnu.org; Fri, 15 Apr 2016 03:20:16 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:37964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqy34-0007gQ-92 for 18147@debbugs.gnu.org; Fri, 15 Apr 2016 03:20:14 -0400 Received: by mail-wm0-f44.google.com with SMTP id u206so18959256wme.1 for <18147@debbugs.gnu.org>; Fri, 15 Apr 2016 00:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=NjJeDIfxuZe7QUlrbs6L6G6i4ikJKbEaGmLHnC1dgEc=; b=MEwxmlXM77h3MbjmrJ3QJSgx84TgcGMWp3yA0asRbycyYFCWgGpP+NxLOwZiosgv4Y VTl3BkW2wzJeoIPFYGW6rLF5Y2+j73UAjtEMq7ln/KOrVTTOTX4f9CsPa30pbLCvG36D w0PSYwlR2pnOyveXLuBUBs7KA8V6DWRO8JULchy6kFwwaAW5oBMA/M95UmErBWnMj3Di fDKtNa7LIZj2Q5cK0qru2Q+nrQLrVGlFAjB61Tj2sAPvElfv0MVs1/vaVnAhsbmyrrHN qs3sBLJrz/hGvnG/aKa6+i32Q+NS6wrg59yJ0phvftcsTQdpShoeuIum4A+N0kIpgfU7 DjHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=NjJeDIfxuZe7QUlrbs6L6G6i4ikJKbEaGmLHnC1dgEc=; b=elm5j00Zs8bOuXBohjobWCL8OUZOEVJ96GnbUc6wL4GItu8xeGBBA+t4pFI+A3gvE1 y1Hm5aRwkQ4IJOTg9+Slu+a5Gctx6cwvmmqvOneuEtz7o0zlskGTuD641HOaZweLvYQ5 fButTxChrd/2iYIbHnochodmU71KAOhbp1gVJ3VruS3HSANaHxtLTtrNbD/Po45Dz0OP RfoIpcOV1Ht6Q2vxpZm/ZGz619iwPGzNGQ7KJ/if6tRfcKu0OlmaFHETpoUc69O6Z9Px uyXYn4bfa2Dp/ATJSTAzLg2eoDFWF4DtUutZhGjZQ+kYZxJ18RZFk9L2Vev9vz0UDnAa tDOg== X-Gm-Message-State: AOPr4FWKBzRF3H/dF+FHbXHaj3AMpK5ckmsfOJU+QeimWNWpG2xGyJ9L2UfEuRV9vSLPSA== X-Received: by 10.194.59.138 with SMTP id z10mr19784750wjq.74.1460704808589; Fri, 15 Apr 2016 00:20:08 -0700 (PDT) Received: from [192.168.0.20] (bcdcc534.skybroadband.com. [188.220.197.52]) by smtp.googlemail.com with ESMTPSA id d123sm37068096wmd.9.2016.04.15.00.20.07 for <18147@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=OTHER); Fri, 15 Apr 2016 00:20:07 -0700 (PDT) Subject: Re: bug#18147: closed (Re: bug#18147: parted-3.2 build failure) To: 18147@debbugs.gnu.org References: <57103A3D.7050601@ubuntu.com> <53D81524.80305@googlemail.com> From: Chris Clayton Message-ID: <5710961E.70804@googlemail.com> Date: Fri, 15 Apr 2016 08:19:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 18147 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) The referenced fix is incorrect. The bug that my patch addressed was actually fixed by 7e87ca3c531228d35e13e802d2622006138b104c: libparted/arch/linux.c: Compile without ENABLE_DEVICE_MAPPER", also by Felix Janda. On 15/04/16 01:49, GNU bug Tracking System wrote: > Your bug report > > #18147: parted-3.2 build failure > > which was filed against the parted package, has been closed. > > The explanation is attached below, along with your original report. > If you require more details, please reply to 18147@debbugs.gnu.org. > From unknown Thu Aug 21 14:54:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 13 May 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator