GNU bug report logs - #18147
parted-3.2 build failure

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18147 in the body.
You can then email your comments to 18147 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chris Clayton <chris2553 <at> googlemail.com>
To: bug-parted <at> gnu.org
Subject: parted-3.2 build failure
Date: Tue, 29 Jul 2014 22:41:56 +0100

[Message part 1 (text/plain, inline)]

Hi.

I'm getting the following errors trying to build parted-3.2:

arch/linux.c: In function 'dm_canonical_path':
arch/linux.c:2313:16: warning: implicit declaration of function 'dm_task_create' [-Wimplicit-function-declaration]
         struct dm_task *task = dm_task_create (DM_DEVICE_INFO);
                ^
arch/linux.c:2313:48: error: 'DM_DEVICE_INFO' undeclared (first use in this function)
         struct dm_task *task = dm_task_create (DM_DEVICE_INFO);
                                                ^
arch/linux.c:2313:48: note: each undeclared identifier is reported only once for each function it appears in
arch/linux.c:2316:9: warning: implicit declaration of function 'dm_task_set_major_minor' [-Wimplicit-function-declaration]
         if (!dm_task_set_major_minor (task, arch_specific->major,
         ^
arch/linux.c:2319:9: warning: implicit declaration of function 'dm_task_run' [-Wimplicit-function-declaration]
         if (!dm_task_run(task))
         ^
arch/linux.c:2321:9: warning: implicit declaration of function 'dm_task_get_name' [-Wimplicit-function-declaration]
         char *dev_name = zasprintf ("/dev/mapper/%s", dm_task_get_name (task));
         ^
arch/linux.c:2324:9: warning: implicit declaration of function 'dm_task_destroy' [-Wimplicit-function-declaration]
         dm_task_destroy (task);
         ^
arch/linux.c: In function '_disk_sync_part_table':
arch/linux.c:2949:33: error: '_dm_add_partition' undeclared (first use in this function)
                 add_partition = _dm_add_partition;
                                 ^
arch/linux.c:2950:36: error: '_dm_remove_partition' undeclared (first use in this function)
                 remove_partition = _dm_remove_partition;
                                    ^
arch/linux.c:2951:36: error: '_dm_resize_partition' undeclared (first use in this function)
                 resize_partition = _dm_resize_partition;
                                    ^
arch/linux.c:2952:50: error: '_dm_get_partition_start_and_length' undeclared (first use in this function)
                 get_partition_start_and_length = _dm_get_partition_start_and_length;
                                                  ^
I am passing --disable-device-mapper to configure, but the code causing the errors is not guarded by #ifdef
ENABLE_DEVICE_MAPPER.

The attached patch allows the build to succeed. I think the resultant code is functionally correct, but I'm sure you
will check that :-)

Regards.

Chris

[parted-3.2-device-mapper.patch (text/plain, attachment)]

Message #10 received at 18147-done <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: 18147-done <at> debbugs.gnu.org
Subject: Re: bug#18147: parted-3.2 build failure
Date: Thu, 14 Apr 2016 20:47:57 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Looks like this was fixed a while back:

commit a3877115f1956949096d77aca5a703a47ed68397
Author: Felix Janda <felix.janda <at> posteo.de>
Date:   Sun May 3 10:33:31 2015 +0200

    libparted/fs/xfs/platform_defs.h: Include <fcntl.h> for loff_t

    This is needed for compilation with musl libc

    Suggested-by: Travis Tilley <ttilley <at> gmail.com>

    Signed-off-by: Brian C. Lane <bcl <at> redhat.com>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCgAGBQJXEDo9AAoJEBB5UWFcu6UWrbAIAI/YxgcHYKuhEysX5D47fxqN
n3ewzkH4N0z9Hw7ViW5EdgiDrRp7r6GmYK/TxgzsowvA/t8Td4FqdrgrFRdgRk70
apK3GxgpeIuZN/ClQqkcNcXFKYQOXSep61WDVcaOjAnAmNIPH1qessA+RzziSEGm
fdErrg+CHnW5a/XPazQLDc6XEqiAioLZCnJ0vFTInZYuKSQXyoLPaeeHHhXPfwJ+
KPWQw38No1cEt1jTG+iyc2oR5t+Nv6qZDmRSQ22p6uvCXosgM5VGDJmI3sauN9Al
8Oy7rsrmatlRTb2GeIp15Xa3ehoAQ1P9ydq5JVL39ANngYSvAPRmv1A94O8eBcU=
=cYtt
-----END PGP SIGNATURE-----

Message #13 received at 18147 <at> debbugs.gnu.org (full text, mbox):

From: Chris Clayton <chris2553 <at> googlemail.com>
To: 18147 <at> debbugs.gnu.org
Subject: Re: bug#18147: closed (Re: bug#18147: parted-3.2 build failure)
Date: Fri, 15 Apr 2016 08:19:58 +0100

The referenced fix is incorrect. The bug that my patch addressed was actually fixed by
7e87ca3c531228d35e13e802d2622006138b104c: libparted/arch/linux.c: Compile without ENABLE_DEVICE_MAPPER", also by 	Felix
Janda.

On 15/04/16 01:49, GNU bug Tracking System wrote:
> Your bug report
> 
> #18147: parted-3.2 build failure
> 
> which was filed against the parted package, has been closed.
> 
> The explanation is attached below, along with your original report.
> If you require more details, please reply to 18147 <at> debbugs.gnu.org.
> 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.