GNU bug report logs - #18145
memory leak in pwd

Previous Next

Full log

Message #8 received at 18145 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: srinivas devaki <mr.eightnoteight <at> gmail.com>
Cc: 18145 <at> debbugs.gnu.org
Subject: Re: bug#18145: memory leak in pwd
Date: Tue, 29 Jul 2014 12:55:21 +0100

tag 18145 notabug
close 18145
stop

On 07/29/2014 08:02 AM, srinivas devaki wrote:
> i think there is a memory leak in pwd.c
> I’m extremely sorry if this is wrong. I’m sending the git diff.
> 
> [eightnoteight <at> mr coreutils]$ git diff
> diff --git a/src/pwd.c b/src/pwd.c
> index 4993dfb..13d84cd 100644
> --- a/src/pwd.c
> +++ b/src/pwd.c
> @@ -367,6 +367,7 @@ main (int argc, char **argv)
>        if (wd)
>          {
>            puts (wd);
> +          free (wd);
>            exit (EXIT_SUCCESS);
>          }
>      }
> 
> and how can i contribute to gnu coreutils. how can i understand the code of
> utils. which libraries should i get used to, before contributing to the gnu
> coreutils.

valgrind doesn't concur:

  $ valgrind src/pwd -L
  ==30954== All heap blocks were freed -- no leaks are possible

You can see that logical_getcwd() doesn't allocate,
so no free is necessary.

On the general point of coreutils dev there is:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob;f=README-hacking;hb=HEAD

thanks,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.