GNU bug report logs - #18136
24.4.50; crash in redisplay when calling load-theme

Previous Next

Full log

Message #38 received at 18136 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: mvoteiza <at> udel.edu, 18136 <at> debbugs.gnu.org
Subject: Re: bug#18136: 24.4.50; crash in redisplay when calling load-theme
Date: Wed, 30 Jul 2014 20:18:16 +0300

> Date: Wed, 30 Jul 2014 18:45:02 +0200
> From: martin rudalics <rudalics <at> gmx.at>
> CC: mvoteiza <at> udel.edu, 18136 <at> debbugs.gnu.org
> 
>  >> I think so, especially because that's how they behaved before.
>  >
>  > If so, we agree, and this means the menu bar should be part of the TTY
>  > frame's dimensions.
> 
> Just that for a GUI frame the menubar is never counted in the text
> height.

Yes, I agree.

>  > No, we resize the frame and then redistribute the frame dimensions
>  > between its windows.  When change_frame_size_1 is called with the same
>  > dimensions as the current frame's dimensions, it simply does nothing
>  > and returns.
> 
> change_frame_size_1 _always_ calls adjust_frame_size now.  And the later
> does (almost) nothing only if the following condition holds:
> 
>    if (new_text_width == old_text_width
>        && new_text_height == old_text_height
>        && new_windows_width == old_windows_width
>        && new_windows_height == old_windows_height
>        && new_pixel_width == old_pixel_width
>        && new_pixel_height == old_pixel_height)
>      /* No change.  Sanitize window sizes and return.  */

OK, but that's the moral equivalent of what I described (based on what
the code did previously).  Right?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.