GNU bug report logs - #18133
Suppressing asynchronous command output

Previous Next

Full log

Message #104 received at 18133 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: rudalics <at> gmx.at, 18133 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#18133: Suppressing asynchronous command output
Date: Tue, 27 Dec 2016 08:23:31 +0200

> From: Reuben Thomas <rrt <at> sc3d.org>
> Date: Tue, 27 Dec 2016 01:20:42 +0000
> Cc: martin rudalics <rudalics <at> gmx.at>, 18133 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
> 
> +(defun comint-make-newly-written-buffer-visible (string process)
> +  "Make the output buffer visible when output is added to an empty buffer.
> +Useful in `comint-preoutput-filter-functions'."
> +  (let ((buffer (process-buffer process)))
> +    (when (and (= 0 (buffer-size buffer))
> +               (string-match-p "\\*Async Shell Command\\*"
> +                               (buffer-name buffer)))
> +      (display-buffer (process-buffer process))))
> +  string)

Why are we hard-coding a certain buffer name in a function that is
supposed to be more general, judging by its name and doc string?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.