GNU bug report logs - #18110
24.4.50; [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace from git logs

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 18110 <at> debbugs.gnu.org
Subject: bug#18110: 24.4.50; [PATCH] vc-git-expanded-log-entry no longer strips leading whitespace from git logs
Date: Tue, 23 Feb 2016 23:30:02 +1100

Dima Kogan <dima <at> secretsauce.net> writes:

> When looking at expanded git logs with vc-print-root-log (C-x v L,
> then <enter> by default), emacs was stripping out all leading
> whitespace from git logs. This was done by an (indent-region)
> call. This patch fixes this issue by removing this call. It might be
> good to remove a constant amount of whitespace from the beginning of
> each log line, but it's not obvious that matters, and it seems more
> trouble than it's worth.

[...]

> -    (unless (eobp)
> -      ;; Indent the expanded log entry.
> -      (indent-region (point-min) (point-max) 2)
> -      (buffer-string))))
> +    (unless (eobp) (buffer-string))))

It seems like a deliberate design choice...  I have no idea whether it's
a good one, though.  Anybody?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.