GNU bug report logs -
#18074
24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised
Previous Next
Reported by: Frank Terbeck <ft <at> bewatermyfriend.org>
Date: Mon, 21 Jul 2014 23:09:02 UTC
Severity: normal
Merged with 40336
Found in version 24.3.50
Done: Eli Zaretskii <eliz <at> gnu.org>
Bug is archived. No further changes may be made.
Full log
Message #14 received at 18074 <at> debbugs.gnu.org (full text, mbox):
> From: Mauro Aranda <maurooaranda <at> gmail.com>
> Date: Wed, 26 Aug 2020 09:50:34 -0300
> Cc: 18074 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
>
> > (deftheme foobar "Foobar theme")
> > (custom-theme-set-faces 'foobar
> > '(default ((default :slant normal
> > :weight bold
> > :foreground "white"
> > :background "black")
> > (t :foreground "blue"))))
> >
> > What I would expect is the `blue' foreground definition from the `t'
> > clause to override the `white' foreground definition from the `default'
> > clause. But alas, it doesn't work, the foreground remains white.
>
> I can reproduce this in Emacs 27, but not with current master.
>
> It looks like this was fixed in:
> commit 05d365d3105371ec956f31f109a2de14c5cf67df
> Author: Eli Zaretskii <eliz <at> gnu.org>
> Date: Sat Apr 4 09:59:16 2020 +0300
>
> Fix face spec handling for 'default' "terminal class"
>
> * lisp/faces.el (face-spec-choose): Reverse order of 'defaults'
> and 'result' when generating attribute list, so that the spec for
> 'default' "terminal class" is indeed overridden by the actual
> class's spec, per the documentation. (Bug#40336)
>
> CCing Eli, hoping he can confirm.
Confirmed, thanks.
This bug report was last modified 4 years and 299 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.