From unknown Tue Jun 17 20:20:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18074 <18074@debbugs.gnu.org> To: bug#18074 <18074@debbugs.gnu.org> Subject: Status: 24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised Reply-To: bug#18074 <18074@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:20:52 +0000 retitle 18074 24.3.50; `default' clause in face specs with custom-theme-set= -faces doesn't work as advertised reassign 18074 emacs submitter 18074 Frank Terbeck severity 18074 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 21 19:08:41 2014 Received: (at submit) by debbugs.gnu.org; 21 Jul 2014 23:08:41 +0000 Received: from localhost ([127.0.0.1]:33813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X9MhD-0003Xc-Si for submit@debbugs.gnu.org; Mon, 21 Jul 2014 19:08:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32840) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X9LXG-0001Hx-Io for submit@debbugs.gnu.org; Mon, 21 Jul 2014 17:54:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9LX3-0000EJ-Rm for submit@debbugs.gnu.org; Mon, 21 Jul 2014 17:54:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9LX3-0000EF-PE for submit@debbugs.gnu.org; Mon, 21 Jul 2014 17:54:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9LWx-0003Xt-G3 for bug-gnu-emacs@gnu.org; Mon, 21 Jul 2014 17:54:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X9LWr-0000Df-71 for bug-gnu-emacs@gnu.org; Mon, 21 Jul 2014 17:53:59 -0400 Received: from smtprelay05.ispgateway.de ([80.67.31.98]:59430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X9LWq-0000DR-T5 for bug-gnu-emacs@gnu.org; Mon, 21 Jul 2014 17:53:53 -0400 Received: from [46.183.96.49] (helo=jim.voodoo.lan) by smtprelay05.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1X9LWp-0000Vw-2Y for bug-gnu-emacs@gnu.org; Mon, 21 Jul 2014 23:53:51 +0200 Received: from jim.voodoo.lan (localhost [127.0.0.1]) by jim.voodoo.lan (Postfix) with ESMTP id 08F56936D7 for ; Mon, 21 Jul 2014 23:54:02 +0200 (CEST) From: Frank Terbeck To: bug-gnu-emacs@gnu.org Subject: 24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised Date: Mon, 21 Jul 2014 23:53:53 +0200 Message-ID: <87d2cye5u6.fsf@jim.voodoo.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Df-Sender: NDMwNDQ0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 21 Jul 2014 19:08:38 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The manual says this: =E2=80=98default=E2=80=99 This element of SPEC doesn=E2=80=99t match any terminal; instead, it specifies defaults that apply to all terminals. This element, if used, must be the first element of SPEC. Each of the following elements can override any or all of these defaults. I tried using that in a theme, but the "override" part didn't work. So I did this from "emacs -Q" to see if something else in my setup was screwing things up for me: (deftheme foobar "Foobar theme") (custom-theme-set-faces 'foobar '(default ((default :slant normal :weight bold :foreground "white" :background "black") (t :foreground "blue")))) What I would expect is the `blue' foreground definition from the `t' clause to override the `white' foreground definition from the `default' clause. But alas, it doesn't work, the foreground remains white. I asked gnu.emacs.help whether I was misinterpreting things, but the person who felt compelled to reply agreed that this seems to be a bug. So here's my report of the issue. Regards, Frank In GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.4.2) of 2013-12-25 on jim, modified by Debian (emacs-snapshot package, version 2:20131221-1) Windowing system distributor `The X.Org Foundation', version 11.0.11204000 System Description: Debian GNU/Linux 7.6 (wheezy) Configured using: `configure --build x86_64-linux-gnu --host x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/lib --localstatedir=3D/var --infodir=3D/usr/share/info/emacs-snapshot --mandir=3D/usr/share/man --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs-snapshot:/etc/emacs:/usr/local/share/e= macs/24.3.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24= .3.50/site-lisp:/usr/share/emacs/site-lisp --with-crt-dir=3D/usr/lib/x86_64-linux-gnu/ --with-x=3Dyes --with-x-toolkit=3Dgtk3 --with-imagemagick=3Dyes 'CFLAGS=3D-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=3D5000 -g -O2' CPPFLAGS=3D-D_FORTIFY_SOURCE=3D2 'LDFLAGS=3D-g -Wl,--as-needed -znocombreloc'' Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: ( d e f t h e e m e SPC f o o b a r SPC=20 " F o o b a r SPC t h e m e " ) =20 C-j ( c u s t o m e - t h e m e - s e t=20 - f a c e s ' f o o b a r =20 ( ' ( d e f a u l t SPC ( ( d e f a u l=20 t SPC : s l a n g t SPC n o r m a l SPC=20 : w e i g h t SPC d e f a u l t C-w C-w =20 =20 b o l d SPC : f o r e g r o u n d SPC "=20 w h i t e " SPC : b a c k g r o u n d " SPC =20 SPC " b l a c k " ) ( t SPC :=20 f o r e g r o u n d SPC " b l u e " ) ) ) ) C-j M-x=20 r e p o r t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. kill-region: The mark is not set now, so there is no region [2 times] Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 22 19:48:39 2014 Received: (at 18074) by debbugs.gnu.org; 22 Jul 2014 23:48:40 +0000 Received: from localhost ([127.0.0.1]:35018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X9jnT-0005Sb-1m for submit@debbugs.gnu.org; Tue, 22 Jul 2014 19:48:39 -0400 Received: from smtprelay05.ispgateway.de ([80.67.31.93]:45678) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X9jnQ-0005SP-KM for 18074@debbugs.gnu.org; Tue, 22 Jul 2014 19:48:37 -0400 Received: from [46.183.96.49] (helo=jim.voodoo.lan) by smtprelay05.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1X9jnP-0004RL-17 for 18074@debbugs.gnu.org; Wed, 23 Jul 2014 01:48:35 +0200 Received: by jim.voodoo.lan (Postfix, from userid 1000) id 9B4A6936D7; Wed, 23 Jul 2014 01:48:53 +0200 (CEST) From: Frank Terbeck To: 18074@debbugs.gnu.org Subject: Reproduced with current HEAD of `emacs-24' branch User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) Date: Wed, 23 Jul 2014 01:48:53 +0200 Message-ID: <87k375rm3e.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: NDMwNDQ0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 18074 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I realise, that I reported the issue with a not entirely up-to-date version of emacs. So tonight, I built an emacs from version control; i.e. "M-x version" not yields: GNU Emacs 24.3.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2014-07-23 on jim This is actually based on: commit b9535f929dc5534ba4a6868802947ebcf79ffd0c ...which is the HEAD of the `emacs-24' branch from the git repository at savannah at the time this email is being written. It appears that the bug is present in this version as well. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 26 08:50:54 2020 Received: (at 18074) by debbugs.gnu.org; 26 Aug 2020 12:50:54 +0000 Received: from localhost ([127.0.0.1]:37721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAutB-0006sO-W5 for submit@debbugs.gnu.org; Wed, 26 Aug 2020 08:50:54 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:36170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAut9-0006sA-RA for 18074@debbugs.gnu.org; Wed, 26 Aug 2020 08:50:52 -0400 Received: by mail-wr1-f49.google.com with SMTP id x7so1697448wro.3 for <18074@debbugs.gnu.org>; Wed, 26 Aug 2020 05:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=T3qp+5QWeXCmeqycS+3/pBv0T4CNAN3qyqrgvkd66rI=; b=r7qlChdxmdf3CVCgiGms1qCnUO3oQBETP+BNKGRfqf1h3sJcv+h5GrjTBiunc51QUd 403IyEo7TbNr6SIYtb3io2FXAixY+ImsNw14zMKQECGxberE49okqIiAWbjEkEYYaIb9 a4k/kphqrrjk0tH65HnnJdf+PFEmhzKcLMo5R/H6u80rJJQ1S8BCdi+cUSI+EXYyHink 7GoTAcUivW5wfrq4Y6Uu8V434s7U5P45csEP3GQWIqoVx6cDn8FYjPfn8VMsYXld8hOq MrkgLmR08ktp1uSRuDVQr+jikixfKVokVnsgGalvdbsHB2IGc3RroPh/LR8fwCVCrB6s CDMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=T3qp+5QWeXCmeqycS+3/pBv0T4CNAN3qyqrgvkd66rI=; b=fAJp+RVlWS+Ap5J0d7GrXoSHMrBVPPHaWhBTHH2wO/nNRbh1G/z/bGxFnS2EQbOntc kn8Fj3pc2gc/zcJI79bNpqXfPI1DVIpzN2EAK3G5hYMYvpVKwhLB/wb2zA60bV17E/U1 d5OArTBfcJJ8Ui6e0x8gOpFL0Dhdt6jbRblKWmfQuusdym/Scg7qI+0ED3p/S0rnNO9C kHQrzBqLACWJWQXh+kUnxm22Jz1lST9g6VqwRi62pp0TaAcAedQTipm3QDh8I6KIKJVr 9mi8bb8jx/8zg2GcMhJUsXtWyGoUy6IJn/mCf66mKJAvwacSu/CRAEcliVpWFiX73YCS 9CMA== X-Gm-Message-State: AOAM532xMVx0W3QId1UlcXvcCb2XMP3Z0v8y6yD8uRZtVmp7UWhx99fk dHTjkZXkW4k6Bs1Q74c3GdgNSAIpILi1EptJpKA= X-Google-Smtp-Source: ABdhPJzBGNe5GoSKljEt7qiJAlaY5O7XwhaWE5WZTAygmNVzjF57RSHLbGP2mcUiacd3zFANEwig+owaDD+VzoJC3fA= X-Received: by 2002:adf:e411:: with SMTP id g17mr16436769wrm.77.1598446245877; Wed, 26 Aug 2020 05:50:45 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Wed, 26 Aug 2020 09:50:34 -0300 Message-ID: Subject: Re: bug#18074: 24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised To: Frank Terbeck Content-Type: multipart/alternative; boundary="000000000000ad9d1205adc744b7" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18074 Cc: Eli Zaretskii , 18074@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ad9d1205adc744b7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Frank Terbeck writes: > The manual says this: > > =E2=80=98default=E2=80=99 > This element of SPEC doesn=E2=80=99t match any terminal; instead, = it > specifies defaults that apply to all terminals. This element, if > used, must be the first element of SPEC. Each of the following > elements can override any or all of these defaults. > > I tried using that in a theme, but the "override" part didn't work. > > So I did this from "emacs -Q" to see if something else in my setup was > screwing things up for me: > > (deftheme foobar "Foobar theme") > (custom-theme-set-faces 'foobar > '(default ((default :slant normal > :weight bold > :foreground "white" > :background "black") > (t :foreground "blue")))) > > What I would expect is the `blue' foreground definition from the `t' > clause to override the `white' foreground definition from the `default' > clause. But alas, it doesn't work, the foreground remains white. I can reproduce this in Emacs 27, but not with current master. It looks like this was fixed in: commit 05d365d3105371ec956f31f109a2de14c5cf67df Author: Eli Zaretskii Date: Sat Apr 4 09:59:16 2020 +0300 Fix face spec handling for 'default' "terminal class" * lisp/faces.el (face-spec-choose): Reverse order of 'defaults' and 'result' when generating attribute list, so that the spec for 'default' "terminal class" is indeed overridden by the actual class's spec, per the documentation. (Bug#40336) CCing Eli, hoping he can confirm. --000000000000ad9d1205adc744b7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Frank Terbeck <ft@bewatermyfriend.org> writes:

> The manual says this:<= br>>
> =C2=A0 =E2=80=98default=E2=80=99
> =C2=A0 =C2=A0 =C2= =A0 =C2=A0This element of SPEC doesn=E2=80=99t match any terminal; instead,= it
> =C2=A0 =C2=A0 =C2=A0 =C2=A0specifies defaults that apply to all= terminals. This element, if
> =C2=A0 =C2=A0 =C2=A0 =C2=A0used, must = be the first element of SPEC. Each of the following
> =C2=A0 =C2=A0 = =C2=A0 =C2=A0elements can override any or all of these defaults.
>> I tried using that in a theme, but the "override" part didn= 't work.
>
> So I did this from "emacs -Q" to see= if something else in my setup was
> screwing things up for me:
&g= t;
> (deftheme foobar "Foobar theme")
> (custom-theme= -set-faces 'foobar
> =C2=A0 '(default ((default :slant normal=
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 :weight bold
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :foreground "white"
> = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 :background "black")
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(t :foreground "blue"))))
>
> What I= would expect is the `blue' foreground definition from the `t'
&= gt; clause to override the `white' foreground definition from the `defa= ult'
> clause. But alas, it doesn't work, the foreground rema= ins white.

I can reproduce this in Emacs 27, but not with current ma= ster.

It looks like this was fixed in:
commit 05d365d3105371ec956= f31f109a2de14c5cf67df
Author: Eli Zaretskii <eliz@gnu.org>
Date: =C2=A0 Sat Apr 4 09:59:16 2020 +0300<= br>
=C2=A0 =C2=A0 Fix face spec handling for 'default' "ter= minal class"
=C2=A0 =C2=A0
=C2=A0 =C2=A0 * lisp/faces.el (face-= spec-choose): Reverse order of 'defaults'
=C2=A0 =C2=A0 and '= ;result' when generating attribute list, so that the spec for
=C2=A0= =C2=A0 'default' "terminal class" is indeed overridden b= y the actual
=C2=A0 =C2=A0 class's spec, per the documentation. =C2= =A0(Bug#40336)

CCing Eli, hoping he can confirm.
--000000000000ad9d1205adc744b7-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 26 09:07:22 2020 Received: (at 18074) by debbugs.gnu.org; 26 Aug 2020 13:07:22 +0000 Received: from localhost ([127.0.0.1]:37777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAv98-00015I-9g for submit@debbugs.gnu.org; Wed, 26 Aug 2020 09:07:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAv97-000155-4q for 18074@debbugs.gnu.org; Wed, 26 Aug 2020 09:07:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59549) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAv91-0002Fn-LF; Wed, 26 Aug 2020 09:07:15 -0400 Received: from [176.228.60.248] (port=2598 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kAv90-0007NC-TM; Wed, 26 Aug 2020 09:07:15 -0400 Date: Wed, 26 Aug 2020 16:07:01 +0300 Message-Id: <83sgc936a2.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: (message from Mauro Aranda on Wed, 26 Aug 2020 09:50:34 -0300) Subject: Re: bug#18074: 24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 18074 Cc: ft@bewatermyfriend.org, 18074@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mauro Aranda > Date: Wed, 26 Aug 2020 09:50:34 -0300 > Cc: 18074@debbugs.gnu.org, Eli Zaretskii > > > (deftheme foobar "Foobar theme") > > (custom-theme-set-faces 'foobar > > '(default ((default :slant normal > > :weight bold > > :foreground "white" > > :background "black") > > (t :foreground "blue")))) > > > > What I would expect is the `blue' foreground definition from the `t' > > clause to override the `white' foreground definition from the `default' > > clause. But alas, it doesn't work, the foreground remains white. > > I can reproduce this in Emacs 27, but not with current master. > > It looks like this was fixed in: > commit 05d365d3105371ec956f31f109a2de14c5cf67df > Author: Eli Zaretskii > Date: Sat Apr 4 09:59:16 2020 +0300 > > Fix face spec handling for 'default' "terminal class" > > * lisp/faces.el (face-spec-choose): Reverse order of 'defaults' > and 'result' when generating attribute list, so that the spec for > 'default' "terminal class" is indeed overridden by the actual > class's spec, per the documentation. (Bug#40336) > > CCing Eli, hoping he can confirm. Confirmed, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 26 09:51:34 2020 Received: (at 18074) by debbugs.gnu.org; 26 Aug 2020 13:51:34 +0000 Received: from localhost ([127.0.0.1]:37841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAvpt-0000Kc-TW for submit@debbugs.gnu.org; Wed, 26 Aug 2020 09:51:34 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:41480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAvpn-0000KB-Lc for 18074@debbugs.gnu.org; Wed, 26 Aug 2020 09:51:29 -0400 Received: by mail-wr1-f54.google.com with SMTP id p17so1880800wrj.8 for <18074@debbugs.gnu.org>; Wed, 26 Aug 2020 06:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9tqPF5uxaLc6YWzmNSkllYM1eTvGrRdynvoXbe1ugOo=; b=h0z4Q5JI3zOny7m52G/SsjQWxdyzM1A5oyxnA67k9vKjOxcuWliLCS+h7og97ZOdte tbHVQKQC+AffYaVMR2uTE1OmFPDMtRx0nncbr2/G86pu2ug3Im6y2CvT52Xd2yRFY7yE JJyziIclIX7qXmWBa0YFDFYd9xMgM7812+FpWtxkzYaidWAmjHhltcDSAPMV1ZZxYvgR LTzA/0xOxycVupJ0kQ1C3i0GbYgRqYjY3TfvA/MMxsRKflO+I08jncMspsvMs5KSoiB+ vFaYRrEXqSs2+l/ln0HhHqUvHXfdBipHEI+oseMrhAlLcDdtvYJtn7yG8t/YZFPElxKC RI0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9tqPF5uxaLc6YWzmNSkllYM1eTvGrRdynvoXbe1ugOo=; b=CwurKMM5iEM1+1DbGakNOUomckQ4B/8BhOYwWh6MWGt8j5P9TS3+QYB1aflmeQrFL8 cklfqYYuMU2kf7GCVZTzlpAWIuJqayv6ohu4f4jSmQ4SNyjwxrbO9fVbienpEyKNJKIE Nx7tYX/ILuS29iMqoKoGhkReiiLHYRkLESWSnkxUk+fueWfXzZCzapDdNBkxlN+uyT19 B8n/R4mYN5WeDyIYVXkNgff9rRpTo07WAqwXIgPHzzPTkgMUU/j19vh1CuyPuKqae6Ne Kr8i8Uz8KHSYpHb2GkcYaZnbQLQfRyaDUaf1SWEAAnWUhD0rtasGdcxKh2IxlBAfiXx3 b6Dw== X-Gm-Message-State: AOAM530fZTzayc4KfmsgQEowp7Cild0f2N8vUmjqjSM7fY1wOkp7NPkg GRwmdKI0gUvVqO3W+0R6ljZAnrSk8ch0r6kj75I= X-Google-Smtp-Source: ABdhPJx2ZKi+5C/bbJvQYC4sZNJ6rRr/Ym3c5HY2+ME/XvS6UFa6NNwMQSDGLTKOzXlwRUowcEM9MLXctd7WUDge3mQ= X-Received: by 2002:adf:e452:: with SMTP id t18mr14751665wrm.109.1598449881724; Wed, 26 Aug 2020 06:51:21 -0700 (PDT) MIME-Version: 1.0 References: <83sgc936a2.fsf@gnu.org> In-Reply-To: <83sgc936a2.fsf@gnu.org> From: Mauro Aranda Date: Wed, 26 Aug 2020 10:51:09 -0300 Message-ID: Subject: Re: bug#18074: 24.3.50; `default' clause in face specs with custom-theme-set-faces doesn't work as advertised To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000064395405adc81d8c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18074 Cc: Frank Terbeck , 18074@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000064395405adc81d8c Content-Type: text/plain; charset="UTF-8" unarchive 40336 forcemerge 40336 18074 quit Eli Zaretskii writes: >> From: Mauro Aranda >> Date: Wed, 26 Aug 2020 09:50:34 -0300 >> Cc: 18074@debbugs.gnu.org, Eli Zaretskii >> >> > (deftheme foobar "Foobar theme") >> > (custom-theme-set-faces 'foobar >> > '(default ((default :slant normal >> > :weight bold >> > :foreground "white" >> > :background "black") >> > (t :foreground "blue")))) >> > >> > What I would expect is the `blue' foreground definition from the `t' >> > clause to override the `white' foreground definition from the `default' >> > clause. But alas, it doesn't work, the foreground remains white. >> >> I can reproduce this in Emacs 27, but not with current master. >> >> It looks like this was fixed in: >> commit 05d365d3105371ec956f31f109a2de14c5cf67df >> Author: Eli Zaretskii >> Date: Sat Apr 4 09:59:16 2020 +0300 >> >> Fix face spec handling for 'default' "terminal class" >> >> * lisp/faces.el (face-spec-choose): Reverse order of 'defaults' >> and 'result' when generating attribute list, so that the spec for >> 'default' "terminal class" is indeed overridden by the actual >> class's spec, per the documentation. (Bug#40336) >> >> CCing Eli, hoping he can confirm. > > Confirmed, thanks. Thanks. Merging this bug with Bug#40336. --00000000000064395405adc81d8c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
unarchive 40336
forcemerge 40336 18074=
quit

Eli Zaretskii <eliz@gnu.= org> writes:

>> From: Mauro Aranda <maurooaranda@gmail.com>
>> Date: = Wed, 26 Aug 2020 09:50:34 -0300
>> Cc: 18074@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
>>
>> > (defthem= e foobar "Foobar theme")
>> > (custom-theme-set-faces= 'foobar
>> > =C2=A0 '(default ((default :slant normal<= br>>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 :weight bold
>> > =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :foreground "whit= e"
>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 :background "black")
>> >= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(t :foreground "blue&= quot;))))
>> >
>> > What I would expect is the `blu= e' foreground definition from the `t'
>> > clause to ov= erride the `white' foreground definition from the `default'
>= > > clause. But alas, it doesn't work, the foreground remains whi= te.
>>
>> I can reproduce this in Emacs 27, but not with= current master.
>>
>> It looks like this was fixed in:<= br>>> commit 05d365d3105371ec956f31f109a2de14c5cf67df
>> Aut= hor: Eli Zaretskii <eliz@gnu.org>=
>> Date: =C2=A0 Sat Apr 4 09:59:16 2020 +0300
>>
>= ;> =C2=A0 =C2=A0 Fix face spec handling for 'default' "term= inal class"
>> =C2=A0 =C2=A0
>> =C2=A0 =C2=A0 * lis= p/faces.el (face-spec-choose): Reverse order of 'defaults'
>&= gt; =C2=A0 =C2=A0 and 'result' when generating attribute list, so t= hat the spec for
>> =C2=A0 =C2=A0 'default' "terminal= class" is indeed overridden by the actual
>> =C2=A0 =C2=A0 c= lass's spec, per the documentation. =C2=A0(Bug#40336)
>>
&= gt;> CCing Eli, hoping he can confirm.
>
> Confirmed, thanks= .

Thanks.=C2=A0 Merging this bug with Bug#40336.
--00000000000064395405adc81d8c-- From unknown Tue Jun 17 20:20:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Sep 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator