GNU bug report logs - #1806
dired-pop-to-buffer in wrong place

Previous Next

Full log

Message #365 received at 1806 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> jurta.org>
Cc: 1806 <at> debbugs.gnu.org, Glenn Morris <rgm <at> gnu.org>
Subject: Re: bug#1806: dired-pop-to-buffer in wrong place
Date: Mon, 18 May 2009 10:11:59 +0200

[Message part 1 (text/plain, inline)]

> Could you also fix Proced and Calendar?

I suppose you mean the call in `calendar-basic-setup' here.  In this
case you probably want to split the largest or LRU window vertically
even if your customized settings would imply a horizontal split.  But
you don't insist on splitting the selected window.  Right?

Any opinions, Glenn?

martin

[calendar.el.diff (text/plain, inline)]

*** calendar.el.~1.281.~	2009-03-16 07:35:28.000000000 +0100
--- calendar.el	2009-05-18 09:52:53.203125000 +0200
***************
*** 1291,1297 ****
      (calendar-increment-month month year (- calendar-offset))
      ;; Display the buffer before calling calendar-generate-window so that it
      ;; can get a chance to adjust the window sizes to the frame size.
!     (or nodisplay (pop-to-buffer calendar-buffer))
      (calendar-generate-window month year)
      (if (and calendar-view-diary-initially-flag
               (calendar-date-is-visible-p date))
--- 1291,1301 ----
      (calendar-increment-month month year (- calendar-offset))
      ;; Display the buffer before calling calendar-generate-window so that it
      ;; can get a chance to adjust the window sizes to the frame size.
!     (or nodisplay
! 	(let ((split-height-threshold 0)
! 	      split-width-threshold)
! 	  ;; Prefer vertical splits (Bug#1806).
! 	  (pop-to-buffer calendar-buffer)))
      (calendar-generate-window month year)
      (if (and calendar-view-diary-initially-flag
               (calendar-date-is-visible-p date))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.