GNU bug report logs - #1806
dired-pop-to-buffer in wrong place

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> jurta.org>

Date: Tue, 6 Jan 2009 15:40:04 UTC

Severity: normal

Done: Juri Linkov <juri <at> jurta.org>

Bug is archived. No further changes may be made.

Full log

Message #360 received at 1806 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> jurta.org>
Cc: 1806 <at> debbugs.gnu.org,
        Roland Winkler <Roland.Winkler <at> physik.uni-erlangen.de>
Subject: Re: bug#1806: dired-pop-to-buffer in wrong place
Date: Mon, 18 May 2009 10:11:54 +0200

[Message part 1 (text/plain, inline)]
> Could you also fix Proced and Calendar?

I attached a similar patch for `proced-send-signal'.  I don't know what
to do about `proced' itself.  Roland what do you think?

martin

[proced.el.diff (text/plain, inline)]
*** proced.el.~1.36.~	2009-04-21 07:18:50.000000000 +0200
--- proced.el	2009-05-18 10:01:50.031250000 +0200
***************
*** 1720,1728 ****
            (dolist (process process-alist)
              (insert "  " (cdr process) "\n"))
            (save-window-excursion
!             ;; Analogous to `dired-pop-to-buffer'
!             ;; Don't split window horizontally.  (Bug#1806)
!             (let (split-width-threshold)
                (pop-to-buffer (current-buffer)))
              (fit-window-to-buffer (get-buffer-window) nil 1)
              (let* ((completion-ignore-case t)
--- 1720,1735 ----
            (dolist (process process-alist)
              (insert "  " (cdr process) "\n"))
            (save-window-excursion
!             ;; Analogous to `dired-pop-to-buffer'.
! 	    (let ((split-window-preferred-function
! 		   (lambda (window)
! 		     (or (and (let ((split-height-threshold 0))
! 				(window-splittable-p (selected-window)))
! 			      ;; Try to split the selected window vertically if
! 			      ;; that's possible.  (Bug#1806)
! 			      (split-window-vertically))
! 			 ;; Otherwise, try to split WINDOW sensibly.
! 			 (split-window-sensibly window)))))
                (pop-to-buffer (current-buffer)))
              (fit-window-to-buffer (get-buffer-window) nil 1)
              (let* ((completion-ignore-case t)
This bug report was last modified 12 years and 236 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.