From unknown Tue Jun 24 17:27:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18057: [PATCH] Find tail.c in srcdir, not builddir Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 19 Jul 2014 15:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18057 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 18057@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140578363615467 (code B ref -1); Sat, 19 Jul 2014 15:28:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Jul 2014 15:27:16 +0000 Received: from localhost ([127.0.0.1]:59566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X8WXb-00041O-Dl for submit@debbugs.gnu.org; Sat, 19 Jul 2014 11:27:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53328) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X8WXZ-000419-3q for submit@debbugs.gnu.org; Sat, 19 Jul 2014 11:27:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8WXM-0005H9-Rk for submit@debbugs.gnu.org; Sat, 19 Jul 2014 11:27:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8WXM-0005Gx-PN for submit@debbugs.gnu.org; Sat, 19 Jul 2014 11:27:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8WXG-0000nc-RE for bug-coreutils@gnu.org; Sat, 19 Jul 2014 11:27:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8WXA-0005B4-US for bug-coreutils@gnu.org; Sat, 19 Jul 2014 11:26:54 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:43473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8WXA-0005AY-NO for bug-coreutils@gnu.org; Sat, 19 Jul 2014 11:26:48 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3hFtN72qFWz3hj9j for ; Sat, 19 Jul 2014 17:26:47 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3hFtN72N3Qz7QQ52 for ; Sat, 19 Jul 2014 17:26:47 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id qk8hpJirOVrx for ; Sat, 19 Jul 2014 17:26:46 +0200 (CEST) X-Auth-Info: 3nImXMAQlBp5UkjOBIh/O+Ck+rce8CQ3NTYaljptu7U= Received: from igel.home (ppp-188-174-152-0.dynamic.mnet-online.de [188.174.152.0]) by mail.mnet-online.de (Postfix) with ESMTPA for ; Sat, 19 Jul 2014 17:26:46 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 6631C2C0507; Sat, 19 Jul 2014 17:26:46 +0200 (CEST) From: Andreas Schwab X-Yow: .. does your DRESSING ROOM have enough ASPARAGUS? Date: Sat, 19 Jul 2014 17:26:46 +0200 Message-ID: <87silxbc95.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh index c25f354..7140871 100755 --- a/tests/tail-2/inotify-race.sh +++ b/tests/tail-2/inotify-race.sh @@ -37,7 +37,7 @@ case $(cat gdb.out) in *) skip_ "can't run gdb";; esac -break_src="$abs_top_builddir/src/tail.c" +break_src="$abs_top_srcdir/src/tail.c" break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_ break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_ -- 2.0.2 -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Tue Jun 24 17:27:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18057: [PATCH] Find tail.c in srcdir, not builddir Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 23 Jul 2014 14:39:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18057 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Andreas Schwab , 18057@debbugs.gnu.org Received: via spool by 18057-submit@debbugs.gnu.org id=B18057.140612630512944 (code B ref 18057); Wed, 23 Jul 2014 14:39:03 +0000 Received: (at 18057) by debbugs.gnu.org; 23 Jul 2014 14:38:25 +0000 Received: from localhost ([127.0.0.1]:35718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X9xgS-0003MX-B8 for submit@debbugs.gnu.org; Wed, 23 Jul 2014 10:38:24 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:59597) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X9xgL-0003Lq-KI for 18057@debbugs.gnu.org; Wed, 23 Jul 2014 10:38:18 -0400 Received: from [10.0.4.15] (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mreue004) with ESMTP (Nemesis) id 0MRQMu-1Wyv381xV2-00SbOv; Wed, 23 Jul 2014 16:38:06 +0200 Message-ID: <53CFC8AD.7090704@bernhard-voelker.de> Date: Wed, 23 Jul 2014 16:37:33 +0200 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 References: <87silxbc95.fsf@igel.home> In-Reply-To: <87silxbc95.fsf@igel.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:oSGn720Q4+Bnr3X2WjIE5F8jHib9G9TMyP46v3h0nBO C0W+F7UR1ouvIoEpsVnfmMnGWu/R3O3XVINguKPj+0/7REU/qn nbargnlCxe4cNU7Fy6j7VwXcMcnqXaDMWwhdCAGfSGXGrrW7PQ fnS9YQMoI/mQbd66sM8Qq4LeB8tLuFOvWYvQy+iolXdh7BOjIC aFNNmd6mm4dvv/zak+R3ZZ9rPUrdRs9xvScgZHq0ycV9wA6GMs qE9F1wCKrHWw+gzDjOD12Kb7QwDvXpRTREcvj2vcDm713whLcG nQInNMZQKLfCXQRWeYft7RpOXgVjyh5qf1wFDAOIdcnBadc3Se g0u/fclTNpZ6UorfdFp1sXFrkKAb/nFx/LpXfLJNY X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 07/19/2014 05:26 PM, Andreas Schwab wrote: > diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh > index c25f354..7140871 100755 > --- a/tests/tail-2/inotify-race.sh > +++ b/tests/tail-2/inotify-race.sh > @@ -37,7 +37,7 @@ case $(cat gdb.out) in > *) skip_ "can't run gdb";; > esac > > -break_src="$abs_top_builddir/src/tail.c" > +break_src="$abs_top_srcdir/src/tail.c" > break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_ > break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_ > Thanks for the patch. However, what's wrong with $abs_top_builddir? ... given that it's successfully used in 21 other places: $ git grep abs_top_builddir -- tests | wc -l 22 Thanks & have a nice day, Berny From unknown Tue Jun 24 17:27:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18057: [PATCH] Find tail.c in srcdir, not builddir Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 23 Jul 2014 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18057 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Bernhard Voelker Cc: 18057@debbugs.gnu.org Received: via spool by 18057-submit@debbugs.gnu.org id=B18057.14061341243949 (code B ref 18057); Wed, 23 Jul 2014 16:49:02 +0000 Received: (at 18057) by debbugs.gnu.org; 23 Jul 2014 16:48:44 +0000 Received: from localhost ([127.0.0.1]:35801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X9ziZ-00011V-Oh for submit@debbugs.gnu.org; Wed, 23 Jul 2014 12:48:43 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:56143) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X9ziT-00011A-Q1 for 18057@debbugs.gnu.org; Wed, 23 Jul 2014 12:48:37 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3hJN0b56YWz3hhnl; Wed, 23 Jul 2014 18:48:31 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3hJN0b4rDXz7S6Qc; Wed, 23 Jul 2014 18:48:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id wywZftTvKfbF; Wed, 23 Jul 2014 18:48:31 +0200 (CEST) X-Auth-Info: PSRuI0JlJEwvBJzDyf9SLuFHP9pTTkIsb2G2d1URGnA= Received: from igel.home (host-188-174-220-142.customer.m-online.net [188.174.220.142]) by mail.mnet-online.de (Postfix) with ESMTPA; Wed, 23 Jul 2014 18:48:31 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id BE5342C36E4; Wed, 23 Jul 2014 18:48:30 +0200 (CEST) From: Andreas Schwab References: <87silxbc95.fsf@igel.home> <53CFC8AD.7090704@bernhard-voelker.de> X-Yow: I just had my entire INTESTINAL TRACT coated with TEFLON! Date: Wed, 23 Jul 2014 18:48:30 +0200 In-Reply-To: <53CFC8AD.7090704@bernhard-voelker.de> (Bernhard Voelker's message of "Wed, 23 Jul 2014 16:37:33 +0200") Message-ID: <87d2cw3tsx.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Bernhard Voelker writes: > On 07/19/2014 05:26 PM, Andreas Schwab wrote: >> diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh >> index c25f354..7140871 100755 >> --- a/tests/tail-2/inotify-race.sh >> +++ b/tests/tail-2/inotify-race.sh >> @@ -37,7 +37,7 @@ case $(cat gdb.out) in >> *) skip_ "can't run gdb";; >> esac >> >> -break_src="$abs_top_builddir/src/tail.c" >> +break_src="$abs_top_srcdir/src/tail.c" >> break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_ >> break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_ >> > > Thanks for the patch. > However, what's wrong with $abs_top_builddir? Is that a serious question? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Tue Jun 24 17:27:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18057: [PATCH] Find tail.c in srcdir, not builddir Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 23 Jul 2014 17:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18057 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Andreas Schwab , Bernhard Voelker Cc: 18057@debbugs.gnu.org Received: via spool by 18057-submit@debbugs.gnu.org id=B18057.14061356848192 (code B ref 18057); Wed, 23 Jul 2014 17:15:02 +0000 Received: (at 18057) by debbugs.gnu.org; 23 Jul 2014 17:14:44 +0000 Received: from localhost ([127.0.0.1]:35826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XA07m-000280-EF for submit@debbugs.gnu.org; Wed, 23 Jul 2014 13:14:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1485) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XA07i-00027f-Am for 18057@debbugs.gnu.org; Wed, 23 Jul 2014 13:14:40 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6NHEWq1004688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Jul 2014 13:14:33 -0400 Received: from [10.3.113.59] (ovpn-113-59.phx2.redhat.com [10.3.113.59]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6NHEWbf027105; Wed, 23 Jul 2014 13:14:32 -0400 Message-ID: <53CFED77.9000800@redhat.com> Date: Wed, 23 Jul 2014 11:14:31 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 References: <87silxbc95.fsf@igel.home> <53CFC8AD.7090704@bernhard-voelker.de> <87d2cw3tsx.fsf@igel.home> In-Reply-To: <87d2cw3tsx.fsf@igel.home> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V23SwI5O7UVHtSqbuqwBolTRa4Tiq3lKL" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V23SwI5O7UVHtSqbuqwBolTRa4Tiq3lKL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/23/2014 10:48 AM, Andreas Schwab wrote: > Bernhard Voelker writes: >=20 >> On 07/19/2014 05:26 PM, Andreas Schwab wrote: >>> diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race= =2Esh >>> index c25f354..7140871 100755 >>> --- a/tests/tail-2/inotify-race.sh >>> +++ b/tests/tail-2/inotify-race.sh >>> @@ -37,7 +37,7 @@ case $(cat gdb.out) in >>> *) skip_ "can't run gdb";; >>> esac >>> >>> -break_src=3D"$abs_top_builddir/src/tail.c" >>> +break_src=3D"$abs_top_srcdir/src/tail.c" >>> break_line=3D$(grep -n ^tail_forever_inotify "$break_src") || frame= work_failure_ >>> break_line=3D$(echo "$break_line" | cut -d: -f1) || framework_failu= re_ >>> >> >> Thanks for the patch. >> However, what's wrong with $abs_top_builddir? >=20 > Is that a serious question? That's where a good commit message would have spared some time. If you had mentioned something like this in the commit message: tail.c lives in srcdir; for users that test in-tree, this happens to be the same as builddir. But this is not true for a VPATH build, and was breaking 'make check' with the following error message: =2E... then it could have prevented this back-and-forth. The patch looks correct and necessary to me, but it is always better to give a maintainer zero excuse for not applying a patch by giving them full justification up front instead of making them figure out on their own what you already learned while writing the patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --V23SwI5O7UVHtSqbuqwBolTRa4Tiq3lKL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTz+13AAoJEKeha0olJ0Nq/CgIAJ+xN2atjCLFdKuDLew5a1IR omuFhMIUk/5Fm+RYwvOxyZBQPxn2dBopDw+ZV3NQ6EAZ81+CZYVy+cr0ym+EiotC BoOE4uA13FV8PW+Y/dLAl0aI7RLvuxkj94eJ2+rPh3Zjtlqx3P3Avkbz1cTVZW3R g0vbXtyWVhl/jZ5FFZuqkP2RgzCIWDvt/sS71VmJOON/QShtYIl9/TJk7bl74PfR vJauHl9FDJ8eXUgSm0NVKg21jq92aieHQdHfka8NQ3taK9iXUxqddsXPrBccQZR/ 6ENFeBZE2fNgxKxlZQpnSuVFM62OSverGMoYw43gBJdIf1SHsOU6PJgACEFxEh8= =mK3Y -----END PGP SIGNATURE----- --V23SwI5O7UVHtSqbuqwBolTRa4Tiq3lKL-- From unknown Tue Jun 24 17:27:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18057: [PATCH] Find tail.c in srcdir, not builddir Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 26 Jul 2014 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18057 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Andreas Schwab Cc: 18057@debbugs.gnu.org, Bernhard Voelker Received: via spool by 18057-submit@debbugs.gnu.org id=B18057.140640807319613 (code B ref 18057); Sat, 26 Jul 2014 20:55:02 +0000 Received: (at 18057) by debbugs.gnu.org; 26 Jul 2014 20:54:33 +0000 Received: from localhost ([127.0.0.1]:39064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XB8zA-00056G-Hw for submit@debbugs.gnu.org; Sat, 26 Jul 2014 16:54:32 -0400 Received: from mail6.vodafone.ie ([213.233.128.184]:7376) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XB8z7-000561-M1 for 18057@debbugs.gnu.org; Sat, 26 Jul 2014 16:54:30 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoBAP4U1FNtTiZw/2dsb2JhbAANS4NgV8tWh00BgSCEewEBBDIBRhALDQsJJQ8CRgYNAQUCAQGIQ6Uml2gXjnsBAU8HhEoFjleUPJBPa4EM Received: from unknown (HELO [192.168.1.79]) ([109.78.38.112]) by mail3.vodafone.ie with ESMTP; 26 Jul 2014 21:54:23 +0100 Message-ID: <53D4157E.608@draigBrady.com> Date: Sat, 26 Jul 2014 21:54:22 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <87silxbc95.fsf@igel.home> <53CFC8AD.7090704@bernhard-voelker.de> <87d2cw3tsx.fsf@igel.home> In-Reply-To: <87d2cw3tsx.fsf@igel.home> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 07/23/2014 05:48 PM, Andreas Schwab wrote: > Bernhard Voelker writes: > >> On 07/19/2014 05:26 PM, Andreas Schwab wrote: >>> diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh >>> index c25f354..7140871 100755 >>> --- a/tests/tail-2/inotify-race.sh >>> +++ b/tests/tail-2/inotify-race.sh >>> @@ -37,7 +37,7 @@ case $(cat gdb.out) in >>> *) skip_ "can't run gdb";; >>> esac >>> >>> -break_src="$abs_top_builddir/src/tail.c" >>> +break_src="$abs_top_srcdir/src/tail.c" >>> break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_ >>> break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_ >>> >> >> Thanks for the patch. >> However, what's wrong with $abs_top_builddir? > > Is that a serious question? Please be constructive. Bernhard was referring to the other instances with VPATH issues, that may only be passing now accidentally. I.E.: git grep "abs_top_builddir}\?/" thanks, P�draig. From unknown Tue Jun 24 17:27:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18057: [PATCH] Find tail.c in srcdir, not builddir Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 26 Jul 2014 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18057 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: =?UTF-8?Q?P=C3=A1draig?= Brady Cc: 18057@debbugs.gnu.org, Bernhard Voelker Received: via spool by 18057-submit@debbugs.gnu.org id=B18057.140641015723087 (code B ref 18057); Sat, 26 Jul 2014 21:30:02 +0000 Received: (at 18057) by debbugs.gnu.org; 26 Jul 2014 21:29:17 +0000 Received: from localhost ([127.0.0.1]:39079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XB9Wm-00060J-Kd for submit@debbugs.gnu.org; Sat, 26 Jul 2014 17:29:16 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:36350) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XB9Wk-00060A-5N for 18057@debbugs.gnu.org; Sat, 26 Jul 2014 17:29:15 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3hLL545Cjsz3hhjQ; Sat, 26 Jul 2014 23:29:12 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3hLL544tTcz7S6Rv; Sat, 26 Jul 2014 23:29:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id gg8VDxDoA1or; Sat, 26 Jul 2014 23:29:11 +0200 (CEST) X-Auth-Info: SvhCQY+eG4AL47ucfA4iVDqKYMO33h2A7jufFla05ts= Received: from igel.home (ppp-188-174-61-194.dynamic.mnet-online.de [188.174.61.194]) by mail.mnet-online.de (Postfix) with ESMTPA; Sat, 26 Jul 2014 23:29:11 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id C35A22C3812; Sat, 26 Jul 2014 23:29:10 +0200 (CEST) From: Andreas Schwab References: <87silxbc95.fsf@igel.home> <53CFC8AD.7090704@bernhard-voelker.de> <87d2cw3tsx.fsf@igel.home> <53D4157E.608@draigBrady.com> X-Yow: They collapsed.... like nuns in the street... they had no teen appeal! Date: Sat, 26 Jul 2014 23:29:10 +0200 In-Reply-To: <53D4157E.608@draigBrady.com> ("=?UTF-8?Q?P=C3=A1draig?= Brady"'s message of "Sat, 26 Jul 2014 21:54:22 +0100") Message-ID: <8738dnvmft.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Pádraig Brady writes: > Bernhard was referring to the other instances with VPATH issues, > that may only be passing now accidentally. Please don't mix unrelated issues. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Tue Jun 24 17:27:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Andreas Schwab Subject: bug#18057: closed (Re: bug#18057: [PATCH] Find tail.c in srcdir, not builddir) Message-ID: References: <53DBEFE3.9010303@cs.ucla.edu> <87silxbc95.fsf@igel.home> X-Gnu-PR-Message: they-closed 18057 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 18057@debbugs.gnu.org Date: Fri, 01 Aug 2014 19:53:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1406922783-10864-1" This is a multi-part message in MIME format... ------------=_1406922783-10864-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18057: [PATCH] Find tail.c in srcdir, not builddir which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18057@debbugs.gnu.org. --=20 18057: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18057 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1406922783-10864-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18057-done) by debbugs.gnu.org; 1 Aug 2014 19:52:14 +0000 Received: from localhost ([127.0.0.1]:54161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XDIsA-0002nv-2s for submit@debbugs.gnu.org; Fri, 01 Aug 2014 15:52:14 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:39952) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XDIs7-0002nf-Ha for 18057-done@debbugs.gnu.org; Fri, 01 Aug 2014 15:52:12 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 1FBE1A6006A; Fri, 1 Aug 2014 12:52:05 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZB6ofwX3f062; Fri, 1 Aug 2014 12:52:04 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id D081FA60016; Fri, 1 Aug 2014 12:52:03 -0700 (PDT) Message-ID: <53DBEFE3.9010303@cs.ucla.edu> Date: Fri, 01 Aug 2014 12:52:03 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Andreas Schwab , 18057-done@debbugs.gnu.org Subject: Re: bug#18057: [PATCH] Find tail.c in srcdir, not builddir References: <87silxbc95.fsf@igel.home> In-Reply-To: <87silxbc95.fsf@igel.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 18057-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Andreas Schwab wrote: > -break_src="$abs_top_builddir/src/tail.c" > +break_src="$abs_top_srcdir/src/tail.c" Thanks; I installed that. ------------=_1406922783-10864-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Jul 2014 15:27:16 +0000 Received: from localhost ([127.0.0.1]:59566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X8WXb-00041O-Dl for submit@debbugs.gnu.org; Sat, 19 Jul 2014 11:27:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53328) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X8WXZ-000419-3q for submit@debbugs.gnu.org; Sat, 19 Jul 2014 11:27:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8WXM-0005H9-Rk for submit@debbugs.gnu.org; Sat, 19 Jul 2014 11:27:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8WXM-0005Gx-PN for submit@debbugs.gnu.org; Sat, 19 Jul 2014 11:27:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8WXG-0000nc-RE for bug-coreutils@gnu.org; Sat, 19 Jul 2014 11:27:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8WXA-0005B4-US for bug-coreutils@gnu.org; Sat, 19 Jul 2014 11:26:54 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:43473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8WXA-0005AY-NO for bug-coreutils@gnu.org; Sat, 19 Jul 2014 11:26:48 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3hFtN72qFWz3hj9j for ; Sat, 19 Jul 2014 17:26:47 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3hFtN72N3Qz7QQ52 for ; Sat, 19 Jul 2014 17:26:47 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id qk8hpJirOVrx for ; Sat, 19 Jul 2014 17:26:46 +0200 (CEST) X-Auth-Info: 3nImXMAQlBp5UkjOBIh/O+Ck+rce8CQ3NTYaljptu7U= Received: from igel.home (ppp-188-174-152-0.dynamic.mnet-online.de [188.174.152.0]) by mail.mnet-online.de (Postfix) with ESMTPA for ; Sat, 19 Jul 2014 17:26:46 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 6631C2C0507; Sat, 19 Jul 2014 17:26:46 +0200 (CEST) From: Andreas Schwab To: bug-coreutils@gnu.org Subject: [PATCH] Find tail.c in srcdir, not builddir X-Yow: .. does your DRESSING ROOM have enough ASPARAGUS? Date: Sat, 19 Jul 2014 17:26:46 +0200 Message-ID: <87silxbc95.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) diff --git a/tests/tail-2/inotify-race.sh b/tests/tail-2/inotify-race.sh index c25f354..7140871 100755 --- a/tests/tail-2/inotify-race.sh +++ b/tests/tail-2/inotify-race.sh @@ -37,7 +37,7 @@ case $(cat gdb.out) in *) skip_ "can't run gdb";; esac -break_src="$abs_top_builddir/src/tail.c" +break_src="$abs_top_srcdir/src/tail.c" break_line=$(grep -n ^tail_forever_inotify "$break_src") || framework_failure_ break_line=$(echo "$break_line" | cut -d: -f1) || framework_failure_ -- 2.0.2 -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ------------=_1406922783-10864-1-- From unknown Tue Jun 24 17:27:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18057: [PATCH] Find tail.c in srcdir, not builddir Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 01 Aug 2014 21:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18057 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 18057@debbugs.gnu.org, eggert@cs.ucla.edu, schwab@linux-m68k.org Received: via spool by 18057-submit@debbugs.gnu.org id=B18057.140692791818872 (code B ref 18057); Fri, 01 Aug 2014 21:19:02 +0000 Received: (at 18057) by debbugs.gnu.org; 1 Aug 2014 21:18:38 +0000 Received: from localhost ([127.0.0.1]:54175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XDKDl-0004uK-PE for submit@debbugs.gnu.org; Fri, 01 Aug 2014 17:18:38 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:7374) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XDKDi-0004u0-JG for 18057@debbugs.gnu.org; Fri, 01 Aug 2014 17:18:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBAPkC3FNtTijp/2dsb2JhbAANTg6HIM1Mgx0BgSGEewEBBCMPAVYLDQsCAgUWCwICCQMCAQIBRQcMCAEBiEOwEXeXWBeBLI4ngnmBUgEEo0SQF0M Received: from unknown (HELO [192.168.1.79]) ([109.78.40.233]) by mail2.vodafone.ie with ESMTP; 01 Aug 2014 22:18:28 +0100 Message-ID: <53DC03F3.4010408@draigBrady.com> Date: Fri, 01 Aug 2014 22:17:39 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <87silxbc95.fsf@igel.home> <53DBEFE3.9010303@cs.ucla.edu> In-Reply-To: <53DBEFE3.9010303@cs.ucla.edu> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 08/01/2014 08:52 PM, Paul Eggert wrote: > Andreas Schwab wrote: >> -break_src="$abs_top_builddir/src/tail.c" >> +break_src="$abs_top_srcdir/src/tail.c" > > Thanks; I installed that. Looks good thanks. I thought there might also be an issue with at least "$abs_top_builddir/src/coreutils.h", but that's generated in the builddir so is fine. cheers, Pádraig.