GNU bug report logs - #18051
24.3.92; ls-lisp: Sorting; make ls-lisp-string-lessp a normal function?

Previous Next

Full log

Message #23 received at 18051 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 18051 <at> debbugs.gnu.org
Subject: Re: bug#18051: 24.3.92; ls-lisp: Sorting;
 make ls-lisp-string-lessp a normal function?
Date: Fri, 18 Jul 2014 11:37:19 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> > could I please get my `ls-lisp-string-lessp' defined as a function?
>
> You can always redefine the functions that call it, no?

That would cover the whole switch processing algorithm,
`ls-lisp-handle-switches', 60 lines of code.  I would shadow any future
change in that code by redefining that huge function.  That's why I
wanted to avoid that.

What's the advantage of `ls-lisp-string-lessp' being a defsubst?  If it
really makes it significantly faster (it's called a lot of times, of
course), then ok, let's keep it.


Thanks,

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.