GNU bug report logs - #18051
24.3.92; ls-lisp: Sorting; make ls-lisp-string-lessp a normal function?

Previous Next

Full log

Message #209 received at 18051 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>, 
 Eli Zaretskii <eliz <at> gnu.org>
Cc: dmantipov <at> yandex.ru, 18051 <at> debbugs.gnu.org
Subject: Re: bug#18051: [Emacs-diffs] trunk r117726: Add string collation.
Date: Wed, 27 Aug 2014 12:00:29 -0700

I found the following issues and installed what I hope are fixes as 
trunk bzr 117751.

First, the code should use wcscoll_t rather than uselocale, as uselocale 
modifies thread state and this is less robust; for example, it wasn't 
safe to call 'error' right after the first call to uselocale.

Second, if the locale is invalid, string-collate-lessp should throw an 
error, the same way it throws an error when the strings are invalid.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.