GNU bug report logs - #18039
24.3; Broken docstring in cl-style functions

Previous Next

Package: emacs;

Reported by: Thorsten Jolitz <tjolitz <at> gmail.com>

Date: Wed, 16 Jul 2014 23:25:02 UTC

Severity: normal

Merged with 21839

Found in versions 24.3, 25.0.50, 24.5

Fixed in version 25.0.94

Done: Noam Postavsky <npostavs <at> users.sourceforge.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Thorsten Jolitz <tjolitz <at> gmail.com>, 18039 <at> debbugs.gnu.org
Subject: bug#18039: 24.3; Broken docstring in cl-style functions
Date: Sat, 19 Jul 2014 12:50:23 -0400

> The newline character in the (printed) argument list makes a
> difference in this expression in help-add-fundoc-usage:

>     (if (and (stringp arglist)
> 	     (string-match "\\`([^ ]+\\(.*\\))\\'" arglist))
> 	(concat "(fn" (match-string 1 arglist) ")")
>       (format "%S" (help-make-usage 'fn arglist)))

> (help-make-usage doesn't seem to expect a stringp arglist).  Should the
> regexp given to string-match be changed?

Indeed, we have a bug there.  We should/could probably arrange for
arglist to be on a single line (quote newlines as \n), but we should
also make the code more robust such that when the regexp fails to match
we signal an error rather than fallback to the non-string case which
then burps.


        Stefan
This bug report was last modified 8 years and 335 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.