From unknown Sun Jun 22 11:39:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18039: 24.3; Broken docstring in cl-style functions Resent-From: Thorsten Jolitz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Jul 2014 23:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18039@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140555308818083 (code B ref -1); Wed, 16 Jul 2014 23:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jul 2014 23:24:48 +0000 Received: from localhost ([127.0.0.1]:56929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X7YZ5-0004hZ-Ak for submit@debbugs.gnu.org; Wed, 16 Jul 2014 19:24:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50977) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X7YZ1-0004hL-4x for submit@debbugs.gnu.org; Wed, 16 Jul 2014 19:24:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7YYq-0003B0-G5 for submit@debbugs.gnu.org; Wed, 16 Jul 2014 19:24:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7YYq-0003Aw-Cx for submit@debbugs.gnu.org; Wed, 16 Jul 2014 19:24:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7YYk-0001d6-SB for bug-gnu-emacs@gnu.org; Wed, 16 Jul 2014 19:24:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7YYf-00038H-6R for bug-gnu-emacs@gnu.org; Wed, 16 Jul 2014 19:24:26 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:37997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7YYe-000381-RV for bug-gnu-emacs@gnu.org; Wed, 16 Jul 2014 19:24:21 -0400 Received: by mail-we0-f174.google.com with SMTP id x48so1660087wes.33 for ; Wed, 16 Jul 2014 16:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=TpsMFhJVpUxaK9Lbf1MN5UhD0NGBrN7I0c6g9X1vJWM=; b=ODW3pP2YvmTl04phrdQV24oFBxsiZYVRL2YI93RIqWPVL5qOAbvx+OHOTd8yWExbX2 m5qQ/NJlGqLDs+xl2G5JtHGmzQsgfjsOaf2mprRO9fyuLhQrbYesX9P1ffZrk5GbPykR tGtr5yIVAadSZDBOH34m/fygKCoFMMam140Ih3rl3mPh8+XFjIi3PJgvXMA8h+ng2F8m NPsJ2jRJ/CL6ZXQsEslMhNdU/iVXMM5Lii1FRORR6dG1rASXWqwwz5BvESZ8gpyfpqgX pGXXfUa1E4wEubbr75tMP8NDqOMDprjJvYvQf26Xjd1+GK/wEM6HB6Ti5m3NzXMWgemS 6VNA== X-Received: by 10.180.24.66 with SMTP id s2mr16961421wif.33.1405553059783; Wed, 16 Jul 2014 16:24:19 -0700 (PDT) Received: from localhost (g231233164.adsl.alicedsl.de. [92.231.233.164]) by mx.google.com with ESMTPSA id l2sm1651382wjw.31.2014.07.16.16.24.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jul 2014 16:24:18 -0700 (PDT) From: Thorsten Jolitz Date: Thu, 17 Jul 2014 01:24:17 +0200 Message-ID: <87vbqwanvi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Certain combinations of normal function args with &key args result in broken docstrings for functions defined with `defun*'. Recipe: 0. emacs -Q 1. download and load https://raw.githubusercontent.com/tj64/puml/master/puml.el 2. ,----[ C-h f puml-key-val RET ] | puml-key-val is a Lisp function in `puml.el'. | | (puml-key-val KEY VAL &key CRLF INS) | | Return or insert PlantUML key-val pair. `---- OK 3. ,----[ C-h f puml-arrow RET ] | puml-arrow is a Lisp function in `puml.el'. | | (puml-arrow &key (LEN 2) DIR (SHAFT "-") (LHEAD "") (RHEAD ">") LEXTRA | REXTRA INS) | | Return or insert PlantUML arrow. `---- OK 4. ,----[ C-h f puml-skinparam RET ] | puml-skinparam is a Lisp function in `puml.el'. | | (puml-skinparam 40 102 110 32 75 69 89 45 86 65 76 45 83 84 82 71 32 | 38 107 101 121 32 69 76 69 77 32 40 67 82 76 70 32 34 10 34 41 32 73 | 78 83 41) | | Return or insert PlantUML skinparam. `---- BUG signature looks like this: (defun* puml-skinparam (key-val-strg &key elem (crlf "\n") ins) thus the bug seems to be in the combination of normal args 'key-val-strg and &key args with default values '(crlf "\n"). In GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2) of 2014-06-11 on var-lib-archbuild-staging-x86_64-jgc Configured using: `configure '--prefix=/usr' '--sysconfdir=/etc' '--libexecdir=/usr/lib' '--localstatedir=/var' '--with-x-toolkit=gtk3' '--with-xft' 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong --param=ssp-buffer-size=4' 'LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro' 'CPPFLAGS=-D_FORTIFY_SOURCE=2'' Important settings: value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x d g i t / p u m TAB RET n n n L y C-x 3 C-h f p u m l - a c t TAB i TAB RET f C-v C-v C-v C-v C-v C-v C-v C-v C-v C-h f p u m l - s k i TAB RET C-v C-h f p u m l - a r r o w RET C-g C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-h f p u m l - k e TAB RET C-h f p u m l - n o t e RET ESC x e m a DEL DEL DEL b u TAB g TAB TAB ESC b C-k C-b C-g ESC x r e p TAB o TAB r TAB RET Recent messages: Load: 1 file. Making completion list... Type "q" in help window to restore its previous buffer. Loading vc-git...done [2 times] Quit [2 times] Making completion list... [2 times] Quit Making completion list... [2 times] Load-path shadows: /usr/share/emacs/24.3/lisp/org/.dir-locals hides /usr/share/emacs/24.3/lisp/gnus/.dir-locals Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-git help-mode easymenu puml help-fns cl-macs gv cl cl-lib dired-aux dired time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) -- cheers, Thorsten From unknown Sun Jun 22 11:39:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18039: 24.3; Broken docstring in cl-style functions Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Jul 2014 00:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Thorsten Jolitz Cc: 18039@debbugs.gnu.org Received: via spool by 18039-submit@debbugs.gnu.org id=B18039.140555709324132 (code B ref 18039); Thu, 17 Jul 2014 00:32:02 +0000 Received: (at 18039) by debbugs.gnu.org; 17 Jul 2014 00:31:33 +0000 Received: from localhost ([127.0.0.1]:56958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X7Zbf-0006H4-OJ for submit@debbugs.gnu.org; Wed, 16 Jul 2014 20:31:32 -0400 Received: from mout.web.de ([212.227.17.11]:51624) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X7Zba-0006Gf-9r for 18039@debbugs.gnu.org; Wed, 16 Jul 2014 20:31:29 -0400 Received: from drachen.dragon ([94.217.127.201]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0LsyZi-1WRScH08S2-012WBP; Thu, 17 Jul 2014 02:31:19 +0200 From: Michael Heerdegen References: <87vbqwanvi.fsf@gmail.com> Date: Thu, 17 Jul 2014 02:31:17 +0200 In-Reply-To: <87vbqwanvi.fsf@gmail.com> (Thorsten Jolitz's message of "Thu, 17 Jul 2014 01:24:17 +0200") Message-ID: <87y4vshlm2.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:foBdT9+ohNsVQdVKKgxX1azfUdGGSBa34gyJRnin92JYdlsxKne VA2Lu/BSs/5PSH5rYPtwiVxZwDrW47kx8hfITQaqNTneFfpMuW8O/r8FftFa1w8Ua4uIURv 5JStNEUzQvDpIotikzmb6YiLRrITNa84nb/IynUsFwQModP79gia8qxdB+YHLH9aEaqm5vC QtPtaWGDZBSPUhqtiV7ZA== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Thorsten Jolitz writes: > thus the bug seems to be in the combination of normal args > 'key-val-strg and &key args with default values '(crlf "\n"). Indeed. Eval this in emacs -Q: M-: (require 'cl) M-: (cl-defun test (&key (c "\n")) "Test" nil) M-: (symbol-function 'test) ==> (lambda (&rest --cl-rest--) "Test (fn 40 102 110 32 38 107 101 121 32 40 67 32 34 10 34 41 41) ...) The newline character in the (printed) argument list makes a difference in this expression in help-add-fundoc-usage: (if (and (stringp arglist) (string-match "\\`([^ ]+\\(.*\\))\\'" arglist)) (concat "(fn" (match-string 1 arglist) ")") (format "%S" (help-make-usage 'fn arglist))) (help-make-usage doesn't seem to expect a stringp arglist). Should the regexp given to string-match be changed? Michael. From unknown Sun Jun 22 11:39:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18039: 24.3; Broken docstring in cl-style functions Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jul 2014 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: Thorsten Jolitz , 18039@debbugs.gnu.org Received: via spool by 18039-submit@debbugs.gnu.org id=B18039.140578863423197 (code B ref 18039); Sat, 19 Jul 2014 16:51:02 +0000 Received: (at 18039) by debbugs.gnu.org; 19 Jul 2014 16:50:34 +0000 Received: from localhost ([127.0.0.1]:59608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X8XqE-000624-AE for submit@debbugs.gnu.org; Sat, 19 Jul 2014 12:50:34 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:39479) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X8Xq9-00061o-Hv for 18039@debbugs.gnu.org; Sat, 19 Jul 2014 12:50:30 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="78099916" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Jul 2014 12:50:23 -0400 Received: by pastel.home (Postfix, from userid 20848) id 33D0960BEC; Sat, 19 Jul 2014 12:50:23 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87vbqwanvi.fsf@gmail.com> <87y4vshlm2.fsf@web.de> Date: Sat, 19 Jul 2014 12:50:23 -0400 In-Reply-To: <87y4vshlm2.fsf@web.de> (Michael Heerdegen's message of "Thu, 17 Jul 2014 02:31:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > The newline character in the (printed) argument list makes a > difference in this expression in help-add-fundoc-usage: > (if (and (stringp arglist) > (string-match "\\`([^ ]+\\(.*\\))\\'" arglist)) > (concat "(fn" (match-string 1 arglist) ")") > (format "%S" (help-make-usage 'fn arglist))) > (help-make-usage doesn't seem to expect a stringp arglist). Should the > regexp given to string-match be changed? Indeed, we have a bug there. We should/could probably arrange for arglist to be on a single line (quote newlines as \n), but we should also make the code more robust such that when the regexp fails to match we signal an error rather than fallback to the non-string case which then burps. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 14:04:24 2016 Received: (at control) by debbugs.gnu.org; 2 Jun 2016 18:04:24 +0000 Received: from localhost ([127.0.0.1]:52004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8Wym-0005R9-JQ for submit@debbugs.gnu.org; Thu, 02 Jun 2016 14:04:24 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:34654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8Wyl-0005Qx-0b for control@debbugs.gnu.org; Thu, 02 Jun 2016 14:04:23 -0400 Received: by mail-oi0-f50.google.com with SMTP id e72so89953141oib.1 for ; Thu, 02 Jun 2016 11:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to; bh=bnZ4GLt0Bf83Yx38srxDVZ7vPzcinu3MJwBpwUN4WuQ=; b=ytfq0RTqQlo88rMfOAJ/5T8EQicpDWqyyeCOrkOPZOGp3yCYPwUzcbRqgq36GMX+wz o+Hfo9KDkKw/gZ1D08JGCVI7lNTU8AiNxkKWqqnBvMwFq+ljEIlaqw438LKJjZN5U/9q ldHn7cPum2+Jgc8wYrr2cLbM1rxrGWWGt6x+g3JKLRQ8GDnixI7atPgDRtRUOGYoVpFn S98DcgpKSrLXyrlJWVF/LT+wOjdxXT78LRKkAib8fqUOh8kB55H0ITyey3TWVkUYva73 BH5CMHIIWS0YRopCjE2a3QkVauI5S7zzAUxCUY2+W07pJ4BZdXzD8Bczt4yW8bpHZ54l ZlQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:date:message-id:subject:from :to; bh=bnZ4GLt0Bf83Yx38srxDVZ7vPzcinu3MJwBpwUN4WuQ=; b=SJEwpuG2HgEIKs+/or6ecVUKKjbThg66fd+pNHQWZwwBBJZqshA8rV1QCV7XAb3riw 9pidFKjjI60oib00xBDwr8oUklaStN4WZdNv9Kv5nDR9oaGWR3V3jFXoCAxN9sXHv5b0 a4awB2EOqZZjZi/TdUIFfSYin0xhr/KewCknr6F7rszkz8N3ESnxB90SDQ5QF7rToMkG B+lJGS6ys/6VFYGz6YFJ+2mbpfPzF1kXwuukkET7GaoTvqaE63norqMLqyCEcMe4coSW 3y7RGCuECk9yuHJjRU6vNrePz+SZDbnAsY2t+UVKPrngJ0T/mE0AldJUY5XqLMc71f+d w28w== X-Gm-Message-State: ALyK8tKvNfwCvvCXuuK23MNEehaSrhNPfcSbiS4UfDbjVQGZjQrjur5PR06/0ABVh62kHLQIG0g0SgndXv4BAQ== MIME-Version: 1.0 X-Received: by 10.202.168.131 with SMTP id r125mr1973962oie.40.1464890657282; Thu, 02 Jun 2016 11:04:17 -0700 (PDT) Received: by 10.157.34.169 with HTTP; Thu, 2 Jun 2016 11:04:17 -0700 (PDT) Date: Thu, 2 Jun 2016 14:04:17 -0400 X-Google-Sender-Auth: DIbznSTbLj823hPbnjxK9_Eyc-w Message-ID: Subject: Re: bug#18039: 24.3; Broken docstring in cl-style functions From: Noam Postavsky To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) found 18039 24.5 fixed 18034 25.0.94 close 18039 merge 18039 21839 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 26 01:40:37 2016 Received: (at control) by debbugs.gnu.org; 26 Jun 2016 05:40:37 +0000 Received: from localhost ([127.0.0.1]:55977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bH2o8-00079t-Tg for submit@debbugs.gnu.org; Sun, 26 Jun 2016 01:40:37 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:33182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bH2o7-00079c-V1; Sun, 26 Jun 2016 01:40:36 -0400 Received: by mail-oi0-f46.google.com with SMTP id u201so164112318oie.0; Sat, 25 Jun 2016 22:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to; bh=n7AGC4cJzCvGYHPo0vq5/eZK1Az97/LkAvOkpVZxeGE=; b=pGWklxGOerB4sjJ+cHyNnckUqHc3XoT1MSAP4gEtDpkagGKqwzRjfHkbtS+NaO21Sn HPl8Dmiedt1/EN2lnS4fEVdZDXaDJEB7WXnA9/zgW67YvgYQ9/z3m4j6b31+VasTcTLX rzPI0qVBQL8b/kqGZDkAwVVQibe57XvYRx7lFfMAd0cJ6KFoYkDKeNkBTymxFdlOGgVF 6GsaOEBVQneeiuGx9+zuUl7ruvbmkPPov/Hg5r4ovcueXDC03FpyqEalXjgjvMsSIom9 4q7BGQR5ZGCDWiuB2uAGy42QJPFMQdo883mnVhaVqHmNyuRyRTCzyINDu3I4fPVhiNyz tLaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=n7AGC4cJzCvGYHPo0vq5/eZK1Az97/LkAvOkpVZxeGE=; b=bx3bmbsBkmwsYg5U5RnIH3ja6FVQvicuE8ClhNmvP24CDuXfyg0LY/Jv1illmKfzH3 R0ivFlCSiBc53nyS+llgMvWKI+Iaq/O+2DAD9Qbk5ycKnzm49o1uxT5Pv/oQWfMKRJUF BUONANapIgEqvP5a1biLzuu+gt0zDUOEivnJMptwEYL7kPgqb/0F3pBL7JePz/7F2PH4 ONbdezuLoXFXGX/hQNihRPpNK5AoFkZWKSmjRK8hyRS6pig/h4NlrmEd5oARiHPY8DQw s2bmwThdmSExmBqm6/iXttBWV+mc77nyndTw6NhTszBbVrDgLRapZ9PoNYVRIA+3ZJF5 HXZA== X-Gm-Message-State: ALyK8tI3CundH5wGIhtXwNjUfx0oVn1SsgUQh66oAoRYkZegFhUMUOKZbyzDF96OS0JinUiyCJWBHswtQd1UMA== X-Received: by 10.202.207.16 with SMTP id f16mr6491125oig.178.1466919630353; Sat, 25 Jun 2016 22:40:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.52.238 with HTTP; Sat, 25 Jun 2016 22:40:30 -0700 (PDT) From: Noam Postavsky Date: Sun, 26 Jun 2016 01:40:30 -0400 X-Google-Sender-Auth: RyP4tpJGeObNUm2OdclUvMp-jec Message-ID: Subject: Bug #18034: toggle-read-only used in the code To: GNU bug tracker automated control server , 18034-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) # I accidentally marked 18034 fixed due to typo but I meant 18039 fixed 18039 25.0.94 quit However, this bug is fixed as well. I ran the find+gawk expression against emacs-25 sources, only 3 occurences left, and they are acceptable uses kept for backwards compat reasons. I've added context to each hit: ~/src/emacs$ find emacs-25/lisp/ -type f -name \*.el -exec gawk 'FILENAME ~ /\/ { print FILENAME ":" FNR ":\t" $0; }' {} + ;; toggle-read-only is obsolete since 24.3, but since vc-t-r-o was made ;; obsolete earlier, it is ok for the latter to be an alias to the former, ;; since the latter will be removed first. We can't just make it ;; an alias for read-only-mode, since that is not 100% the same. emacs-25/lisp/vc/vc-hooks.el:573: (defalias 'vc-toggle-read-only 'toggle-read-only) (substitute-key-definition 'read-only-mode 'hide-ifdef-toggle-outside-read-only map) ;; `toggle-read-only' is obsoleted by `read-only-mode'. (substitute-key-definition emacs-25/lisp/progmodes/hideif.el:195: 'toggle-read-only 'hide-ifdef-toggle-outside-read-only map) (define-key map [remap read-only-mode] 'dired-toggle-read-only) ;; `toggle-read-only' is an obsolete alias for `read-only-mode' emacs-25/lisp/dired.el:1561: (define-key map [remap toggle-read-only] 'dired-toggle-read-only)