GNU bug report logs - #18034
toggle-read-only used in the code

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: toggle-read-only used in the code
Date: Tue, 15 Jul 2014 18:44:28 +0000

[Message part 1 (text/plain, inline)]

Package:  emacs
Severity: minor

	Even though toggle-read-only was marked as obsolete back in
	2012, there’re still a handful of references to it remaining in
	the code, most notably in vc/*.el.  Consider, e. g.:

$ find lisp/ -type f -name \*.el \
      -exec gawk 'FILENAME ~ /\<files\.el$/ || /^\s*[;"]|"$/ { next; }
                  /[^-[:alnum:]]toggle-read-only\>/ {
                      print FILENAME ":" FNR ":\t" $0;
                  }' {} + 
lisp/dired.el:1553:	    (define-key map [remap toggle-read-only] 'dired-toggle-read-only)
lisp/progmodes/hideif.el:192:	     'toggle-read-only 'hide-ifdef-toggle-outside-read-only map)
lisp/vc/vc-hooks.el:637:	  'vc-toggle-read-only 'toggle-read-only "24.1")
lisp/vc/ediff-init.el:1349:	(defvar ediff-toggle-read-only-function 'toggle-read-only
lisp/vc/ediff-util.el:1030:					   'toggle-read-only)
lisp/vc/ediff-util.el:1031:					  (file-writable 'toggle-read-only)
lisp/vc/ediff-util.el:1042:			   (setq toggle-ro-cmd 'toggle-read-only))
lisp/vc/ediff-util.el:1057:			   (setq toggle-ro-cmd 'toggle-read-only)
lisp/vc/ediff-util.el:1063:			 (string-match "toggle-read-only" (symbol-name toggle-ro-cmd)))
$ 

	For one thing, typing A or B in when using Ediff results in the
	respective message:

`toggle-read-only' is an obsolete command (as of 24.3); use `read-only-mode' instead.

	I suggest these be replaced with read-only-mode as appropriate.

	TIA.

-- 
FSF associate member #7257	http://boycottsystemd.org/

[Message part 2 (text/plain, inline)]

commit e7b7bf65b489c5890c4f64245769b8dc5c7fd916
Author:     Stefan Monnier <monnier <at> iro.umontreal.ca>
AuthorDate: Wed Aug 29 11:11:51 2012 -0400

    * lisp/files.el (read-only-mode): New minor mode.
    (toggle-read-only): Use it and mark obsolete.
    (find-file--read-only):
    * lisp/vc/vc.el (vc-next-action, vc-checkout):
    * lisp/vc/vc-cvs.el (vc-cvs-checkout):
    * lisp/obsolete/vc-mcvs.el (vc-mcvs-update):
    * lisp/ffap.el (ffap--toggle-read-only): Update callers.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.